From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt Newsgroups: gmane.emacs.devel Subject: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes Date: Sat, 30 Sep 2023 11:20:04 +0200 Message-ID: <6cb93006-19ac-1ef5-a132-481e9c9791e9@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20818"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: emacs-devel@gnu.org, Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 30 11:21:20 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmWA4-0005Ac-00 for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Sep 2023 11:21:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmW9O-0002aX-Li; Sat, 30 Sep 2023 05:20:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmW9J-0002ZT-Is for emacs-devel@gnu.org; Sat, 30 Sep 2023 05:20:33 -0400 Original-Received: from mr5.vodafonemail.de ([145.253.228.165]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmW9H-0003D4-5w for emacs-devel@gnu.org; Sat, 30 Sep 2023 05:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1696065618; bh=PT4rCbzGn9RnPk9a+P6/OBpQFzDr5K21Ola+8R5+E20=; h=Message-ID:Date:User-Agent:Content-Language:From:To:Subject: Content-Type:From; b=RD4QgSB3UjvSwLpxS2CAZXjcUWDjwyCcr1E2l10DssmITrsVW8hb/kcm1EXCuKLxj 8gTjEhgnyK735+JIX5ux5NqDWsrCROWa6mRyg9c/VPOai4iPHc28qWDQxL5vybK0tQ PoLlMpG3JhluwEw7Kyn1s6lHelyalgxHuz5JVk6M= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4RyMBV1Rdsz1y1f; Sat, 30 Sep 2023 09:20:18 +0000 (UTC) Original-Received: from [192.168.178.41] (port-83-236-57-119.dynamic.as20676.net [83.236.57.119]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4RyMBM3JcCzMm5T; Sat, 30 Sep 2023 09:20:08 +0000 (UTC) Content-Language: de-DE-frami, en-US X-purgate-type: clean X-purgate: clean X-purgate-size: 928 X-purgate-ID: 155817::1696065614-2DFF3228-23ED995E/0/0 Received-SPF: pass client-ip=145.253.228.165; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr5.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311197 Archived-At: Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has introduced a regression. The following fixes it: diff --git a/test/lisp/emacs-lisp/cl-print-tests.el b/test/lisp/emacs-lisp/cl-print-tests.el index 3073a42e39d..3aac161b344 100644 --- a/test/lisp/emacs-lisp/cl-print-tests.el +++ b/test/lisp/emacs-lisp/cl-print-tests.el @@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector (ert-deftest cl-print-tests-ellipsis-string () "Ellipsis expansion works in strings." - (let ((print-length 4) + (let ((cl-print-string-length 4) + (print-length 4) (print-level 3)) (cl-print-tests-check-ellipsis-expansion "abcdefg" "\"abcd...\"" "efg") But the fact that one has to bind `cl-print-string-length' *and* `print-length' could indicate that the commit probably is not "complete" yet. In the sense that more occurrences of `print-length' need to be modified in cl-print.el.