all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
To: emacs-devel@gnu.org, Alan Mackenzie <acm@muc.de>
Subject: Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes
Date: Sat, 30 Sep 2023 11:20:04 +0200	[thread overview]
Message-ID: <6cb93006-19ac-1ef5-a132-481e9c9791e9@vodafonemail.de> (raw)

Seems commit 01229fe0096e936ea8f4fad0d64967671c4b1892 has
introduced a regression.  The following fixes it:


diff --git a/test/lisp/emacs-lisp/cl-print-tests.el b/test/lisp/emacs-lisp/cl-print-tests.el
index 3073a42e39d..3aac161b344 100644
--- a/test/lisp/emacs-lisp/cl-print-tests.el
+++ b/test/lisp/emacs-lisp/cl-print-tests.el
@@ -60,7 +60,8 @@ cl-print-tests-ellipsis-vector
 
 (ert-deftest cl-print-tests-ellipsis-string ()
   "Ellipsis expansion works in strings."
-  (let ((print-length 4)
+  (let ((cl-print-string-length 4)
+        (print-length 4)
         (print-level 3))
     (cl-print-tests-check-ellipsis-expansion
      "abcdefg" "\"abcd...\"" "efg")


But the fact that one has to bind `cl-print-string-length' *and*
`print-length' could indicate that the commit probably is not
"complete" yet.  In the sense that more occurrences of `print-length'
need to be modified in cl-print.el.



             reply	other threads:[~2023-09-30  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30  9:20 Jens Schmidt [this message]
2023-09-30 14:36 ` Regression test `cl-print-tests-ellipsis-string' fails after latest cl-print changes Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cb93006-19ac-1ef5-a132-481e9c9791e9@vodafonemail.de \
    --to=jschmidt4gnu@vodafonemail.de \
    --cc=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.