Re: emacs.pdmp not always rebuilt

[Gregory Heytings <gregory@heytings.org>]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]


>> I think avoiding the call if the function is not available is the 
>> cleanest solution, one that we use elsewhere in Emacs in similar cases.
>
> That sounds reasonable, yes.
>

And here is the patch.  As I just said, I'm not entirely convinced that 
it's better, but it isn't much worse either.

[-- Attachment #2: Type: text/x-diff, Size: 983 bytes --]

From 0d7dbb4801d914be00ac9b9685fdb5c7b3d619ab Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Mon, 4 Oct 2021 14:13:46 +0000
Subject: [PATCH] Fix problem with outputting error messages while dumping
 Emacs better

* src/print.c (print_error_message): Don't call substitute-command-keys
when it isn't bound.
---
 src/print.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/print.c b/src/print.c
index ef01738436..221e7b8c2a 100644
--- a/src/print.c
+++ b/src/print.c
@@ -941,7 +941,7 @@ print_error_message (Lisp_Object data, Lisp_Object stream, const char *context,
   else
     {
       Lisp_Object error_conditions = Fget (errname, Qerror_conditions);
-      if (will_bootstrap_p () || will_dump_p ())
+      if (NILP (Fboundp (Qsubstitute_command_keys)))
 	errmsg = Fget (errname, Qerror_message);
       else
 	errmsg = call1 (Qsubstitute_command_keys, Fget (errname, Qerror_message));
-- 
2.33.0