From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: emacs.pdmp not always rebuilt Date: Mon, 04 Oct 2021 13:05:11 +0000 Message-ID: <6c697805381c56ec6eda@heytings.org> References: <87h7dyqo02.fsf@gnus.org> <83k0iu8e2u.fsf@gnu.org> <87czomqmn6.fsf@gnus.org> <878rzaqilg.fsf@gnus.org> <83pmsl7cc9.fsf@gnu.org> <6c69780538e7dcf21be8@heytings.org> <83fsth6jjr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37586"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 04 15:06:29 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXNfp-0009W8-7Q for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 15:06:29 +0200 Original-Received: from localhost ([::1]:37440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXNfn-0004LJ-UZ for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 09:06:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXNeh-0002ni-6Z for emacs-devel@gnu.org; Mon, 04 Oct 2021 09:05:20 -0400 Original-Received: from heytings.org ([95.142.160.155]:36806) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXNed-0000aw-9j; Mon, 04 Oct 2021 09:05:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1633352711; bh=/sMEzei1oHw4nDDzpMQTmqTGajRGUXZS9830vQIgRKA=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=U9pgNtvqr7nrF5M+M/duxOnihVSYWajYGyVqdSBtTbTbIhMbWcKzp7mjG283pPUCN zLaip//EpDNMQ901mv1ULGmI4SQ80GKWhVfCofHziejjOMQhrFOjOMlDSW4fMMluSB 9d7P9ecDoXq8NaLURJSyZ7pd8ItkniBM3BHmARnzFSKOGHdBl++Q2lbwiSCG7H53kT ig+74jmMTJMEREFQJr/AWPd4dhTOPPNmXmRqsnjnr1UOU2OJWh7lK4YNZjaokfC82W FAySp7ANIafOrc64MFLNGfQQQ/1q+eaWbUaIlGgCOhbsT+xWVyHVT9UYbO98nwhSZP lipgOPQ5uS5Dw== In-Reply-To: <83fsth6jjr.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276180 Archived-At: > > But what is the underlying problem? > It's obviously that the Elisp substitute-command-keys is not defined during the first steps of loadup. > > Is it perhaps that substitute-command-keys is defined in help.el, and > help.el is loaded by loadup only after simple.el? If so, I think there > could be a better solution to this: either change the order of loading, > No, because that would require to load help.el before all other files (e.g. the error could happen in subr.el), and actually even before itself (because the error could also happen inside help.el). > > or simply test if substitute-command-keys is fboundp, and avoid using it > if not. > That would be another option, yes. I don't think it's much better though, as Stefan K said a few hours ago the potential effect on substitute-command-keys on error messages during the build is minor.