From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#8337: patches that fixes the problem in appt Date: Tue, 07 Jun 2011 03:28:45 -0400 Message-ID: <6c62oigkwi.fsf@fencepost.gnu.org> References: <8739mcfr82.fsf@kanis.fr> <877hay7ev3.fsf@kanis.fr> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1307431769 7463 80.91.229.12 (7 Jun 2011 07:29:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Jun 2011 07:29:29 +0000 (UTC) Cc: 8337@debbugs.gnu.org To: Ivan Kanis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 07 09:29:25 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QTqj7-0007YS-3a for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2011 09:29:25 +0200 Original-Received: from localhost ([::1]:54300 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqj5-0005sS-Mp for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Jun 2011 03:29:23 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqim-0005rt-Qs for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2011 03:29:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QTqil-0004JQ-2U for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2011 03:29:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqik-0004JF-NA for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2011 03:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QTqik-0006VF-4k; Tue, 07 Jun 2011 03:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2011 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8337-submit@debbugs.gnu.org id=B8337.130743173524984 (code B ref 8337); Tue, 07 Jun 2011 07:29:02 +0000 Original-Received: (at 8337) by debbugs.gnu.org; 7 Jun 2011 07:28:55 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTqic-0006Uv-RA for submit@debbugs.gnu.org; Tue, 07 Jun 2011 03:28:55 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QTqib-0006Uk-E8 for 8337@debbugs.gnu.org; Tue, 07 Jun 2011 03:28:54 -0400 Original-Received: from localhost ([127.0.0.1]:58525) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QTqiT-00017w-Om; Tue, 07 Jun 2011 03:28:45 -0400 X-Spook: Roswell MD5 EuroFed credit card Abbas Baranyi Verisign X-Ran: )$q}bXA2\iDFDLz0M[g:i06MI`Bn#+%57ye@^{)g"a7+z$Xn\<1R]ph\!*oPHklpEl X-Hue: black X-Attribution: GM In-Reply-To: <877hay7ev3.fsf@kanis.fr> (Ivan Kanis's message of "Wed, 13 Apr 2011 10:08:32 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 07 Jun 2011 03:29:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:47019 Archived-At: Sorry about the delay. I do think this is something that needs to be fixed, though I don't think it (ie, overlapping appointments) is very important and I expect to be busy over the next several weeks. Thanks for sending the patch and rest assured I won't forget about it. The patch seems far too large to me though, and is hard to follow since presented as a set of 14 consecutive patches, many of which seem unrelated to the actual issue. They include a lot of stuff that isn't directly relevant and that I don't want (deletion/addition of options, renaming of local variables, what seems like unnecessary refactoring, etc.). It looks like I've done some of this independently in the meantime (patches 1, 2, at first glance). Of the rest: 3 and 6 are entirely cosmetic; 5 is unrelated and incorrect; 10 I don't want, and it and others like it just make subsequent patches harder to follow. At first sight, I'd just like the minimum change: appt-check to not stop at the first relevant entry from appt-time-msg-list, but instead accumulate all the relevant ones. In case of multiple appointments, the modeline should just say "Appts in 3,5,...mins", and the appointment display should just concatenate multiple appts on new lines. No need for new display options. I don't see that this should require such large changes. Maybe this is buried down in patch 12 somewhere, but it looks like it will take some extracting, hence the delay.