From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19923: 24.4: diredp-do-bookmark fails: claims "Wrong number of arguments" Date: Sun, 22 Feb 2015 12:33:58 -0800 (PST) Message-ID: <6b84fedc-a350-4b34-924f-3da4fd0e937b@default> References: <54EA1A7F.60701@gmx.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1424637331 11757 80.91.229.3 (22 Feb 2015 20:35:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Feb 2015 20:35:31 +0000 (UTC) To: Boruch Baum , 19923@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 22 21:35:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YPdFB-00042D-77 for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Feb 2015 21:35:13 +0100 Original-Received: from localhost ([::1]:41177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPdFA-0003oe-K9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Feb 2015 15:35:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPdF6-0003m7-GQ for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 15:35:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPdF1-0004HT-4n for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 15:35:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPdF1-0004GE-1M for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 15:35:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YPdF0-0007KC-HJ for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2015 15:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Feb 2015 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19923-submit@debbugs.gnu.org id=B19923.142463725328089 (code B ref 19923); Sun, 22 Feb 2015 20:35:02 +0000 Original-Received: (at 19923) by debbugs.gnu.org; 22 Feb 2015 20:34:13 +0000 Original-Received: from localhost ([127.0.0.1]:50902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPdED-0007Iy-38 for submit@debbugs.gnu.org; Sun, 22 Feb 2015 15:34:13 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:28910) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPdE9-0007Im-3J for 19923@debbugs.gnu.org; Sun, 22 Feb 2015 15:34:10 -0500 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t1MKY6FP030854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 22 Feb 2015 20:34:07 GMT Original-Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t1MKY5RG001970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 22 Feb 2015 20:34:06 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id t1MKY4AE020107; Sun, 22 Feb 2015 20:34:05 GMT In-Reply-To: <54EA1A7F.60701@gmx.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99708 Archived-At: Boruch, Should be OK now. Please download the latest dired+.el from Emacs Wiki, or wait up to a day for it to be mirrored on MELPA. http://www.emacswiki.org/emacs/download/dired%2b.el. Thanks for the bug report. In answer to your questions: 1. Why function `diredp-bookmark' has parameter NO-MSG-P? Non-nil is passed for that arg when called from `diredp-do-bookmark' and `diredp-do-bookmark-recursive', which create multiple bookmarks. This is to prevent umpteen progress messages. 2. Why the funky error message? Dunno why the file name was shown as `', unless somehow `dired-get-file-for-visit' returned that. The rest of the error message is from `error-message-string', from the error that was raised. Why that looks like byte-code, I don't know. That part looks like an Emacs bug, to me. And the error is raised by the vanilla `bookmark-store' code in bookmark.el. 3. Why doesn't `diredp-do-bookmark' prompt the user for a bookmark, and just assumes that the user wants the bookmark name to be the filename? That's the feature. ;-) `diredp-do-bookmark' etc. are really aimed at quickly creating multiple bookmarks without naming them, in which case you (I, at least)) would not want to have to provide a bookmark name for each file. In addition, these commands are most useful in conjunction with library Bookmark+, in which case the aim is precisely to have (so-called "autofile") bookmarks whose names are the (non-directory) file names, so they can be manipulated using file commands etc. It might be possible to have these commands prompt for the bookmark name in the case where they act on only one bookmark, but I'm not in favor of that either; sorry. You can easily write a modified version of `diredp-bookmark' that does that, for your own use. 4. Why the comment about keeping part of the code in sync with the code for `bmkp-make-record-for-target-file', and where is that function? This is a note to myself, so that if I improve one of these functions later I will remember to consider improving the other one similarly. Function `bmkp-make-record-for-target-file' is in library Bookmark+: http://www.emacswiki.org/emacs/BookmarkPlus HTH.