Re: master 1069364 2/2: Simplify by using attribute.h macros

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

On 5/5/20 10:11 AM, Glenn Morris wrote:

> emacs-module.c:252:3: error: #error "__attribute__ ((cleanup)) not
> supported by this compiler; try GCC"
>   #error "__attribute__ ((cleanup)) not supported by this compiler; try GCC"
>    ^

Thanks, I installed the attached.

[-- Attachment #2: 0001-Don-t-assume-__has_attribute-in-emacs-module.c.patch --]
[-- Type: text/x-patch, Size: 1119 bytes --]

From 4658a44f1464c274f377f593717b1a40bbfd47e5 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 5 May 2020 17:16:49 -0700
Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20assume=20=5F=5Fhas=5Fattribute?=
 =?UTF-8?q?=20in=20emacs-module.c?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Problem reported by Glenn Morris in:
https://lists.gnu.org/r/emacs-devel/2020-05/msg00724.html
* src/emacs-module.c: Use HAS_ATTRIBUTE instead of assuming
the compiler supports __has_attribute.
---
 src/emacs-module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/emacs-module.c b/src/emacs-module.c
index e43e4907d2..3d1827c7da 100644
--- a/src/emacs-module.c
+++ b/src/emacs-module.c
@@ -248,7 +248,7 @@ module_decode_utf_8 (const char *str, ptrdiff_t len)
    of `internal_condition_case' etc., and to avoid worrying about
    passing information to the handler functions.  */
 
-#if !__has_attribute (cleanup)
+#if !HAS_ATTRIBUTE (cleanup)
  #error "__attribute__ ((cleanup)) not supported by this compiler; try GCC"
 #endif
 
-- 
2.17.1