From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ian W Newsgroups: gmane.emacs.bugs Subject: bug#50370: Fix bug in ispell-init-process error handling Date: Fri, 3 Sep 2021 20:53:24 -0700 Message-ID: <6aeebcfa-8a3a-4668-987b-dbe665c514ad@Spark> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="6132edb9_7c3dbd3d_53c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29077"; mail-complaints-to="usenet@ciao.gmane.io" To: 50370@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 04 13:40:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMU2I-0007Kj-UF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Sep 2021 13:40:39 +0200 Original-Received: from localhost ([::1]:47662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mMU2H-0001zu-0S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Sep 2021 07:40:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMU1j-0001xG-0E for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2021 07:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMU1i-0004XU-NA for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2021 07:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mMU1i-0001v0-IN for bug-gnu-emacs@gnu.org; Sat, 04 Sep 2021 07:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ian W Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Sep 2021 11:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50370 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16307555437280 (code B ref -1); Sat, 04 Sep 2021 11:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Sep 2021 11:39:03 +0000 Original-Received: from localhost ([127.0.0.1]:46770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMU0k-0001tK-FK for submit@debbugs.gnu.org; Sat, 04 Sep 2021 07:39:02 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mMMkM-0004e3-OW for submit@debbugs.gnu.org; Fri, 03 Sep 2021 23:53:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mMMkK-0007SM-TL for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 23:53:36 -0400 Original-Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:42716) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mMMkH-00068j-Tt for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 23:53:36 -0400 Original-Received: by mail-pf1-x432.google.com with SMTP id 18so997344pfh.9 for ; Fri, 03 Sep 2021 20:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wahbe-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:message-id:in-reply-to:references:subject:mime-version; bh=SfwyRcab4D6zwMdH2Fiem9uE4h7bwuVErP3oSY1t+pk=; b=dG3I1LOOZv5SbHcwJG7cwJhNIL80dww2vlFhjiygNgXVYHTRz95AEgFi413gX7xewZ YOm9W1hntpA9+mDkJ0ElPn4eu4z1s5Ta9tG/SSKmGNs75CMEBgaEbDkeDaIeJhczYGQk VtQMEWDp+3DXSUgfsgfxcgq981g7LMqowOTQcgCuxe/drGhoVL+Ydfoz8AAruq//ShcZ 2PmYa8iyL1YVkQ98QcTVSa3vI2GKPaksVo6MVDPpb+EZEMV+ck2ZpTURwla4iuHllF5M NLZw6hwyRCk+R998VooDZD3GM9ZkENhjC/kq8gGYuZrwlnW2hw/ZaxIqdF8piHWVPp/w MSVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:message-id:in-reply-to:references :subject:mime-version; bh=SfwyRcab4D6zwMdH2Fiem9uE4h7bwuVErP3oSY1t+pk=; b=K43rBkLomWby7mGzgyIhha8G56H1jDoKZrzSf1uNnP3z3FjbPzzD6C0ZBJeA8/Qfao ccxN058RdP31IZW8wKDu9YdTWKbhOul2ZjmH3sDRFQyQH5Yo67l3JE9lQfqEwpvYb/FQ qiAvmYGDbZzJ/rogpv8qs6OGQ8J7ABZoxszJwXWtLHMcKJ1nyVWjjDtaeAbcPv5YjqPQ tNCGT1F95NowKPCKZMdIKX6Y+k/w35fxhPXK/fGEOc1V4BphHJmS0zkPAHsY/bjU9NBQ HJiJn+2PbUHo45xC98llUVQJCdJjjpOF9qRIoDxus8DFaVWU6JX886pBGDpNdAhPRUCg cUgQ== X-Gm-Message-State: AOAM531FGqXjQD/KwxTbURTJY+RbO4BiRP+HDcGMAerMif8SvAbnOKVg TjoCeS+kykRtar/OAZyk5/lrQ6FjWl/Q2Q== X-Google-Smtp-Source: ABdhPJzepWLTh1WEsba4lt97GaqV59eQQAB4O69bHbT0qBKeiI0hAzvDrcXjlXc4MQHoPHtXigZUdA== X-Received: by 2002:a63:3717:: with SMTP id e23mr1996469pga.10.1630727610841; Fri, 03 Sep 2021 20:53:30 -0700 (PDT) Original-Received: from [192.168.7.54] (c-24-16-210-149.hsd1.wa.comcast.net. [24.16.210.149]) by smtp.gmail.com with ESMTPSA id q9sm721439pfs.40.2021.09.03.20.53.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Sep 2021 20:53:30 -0700 (PDT) In-Reply-To: X-Readdle-Message-ID: 6aeebcfa-8a3a-4668-987b-dbe665c514ad@Spark Received-SPF: none client-ip=2607:f8b0:4864:20::432; envelope-from=ian@wahbe.com; helo=mail-pf1-x432.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 04 Sep 2021 07:39:01 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213415 Archived-At: --6132edb9_7c3dbd3d_53c Content-Type: multipart/alternative; boundary="6132edb9_1e7ff521_53c" --6132edb9_1e7ff521_53c Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline This fixes the error handling in ispell-init-process. I encountered this = bug, and also saw it mentioned here:=C2=A0https://mail.gnu.org/archive/ht= ml/auctex/2021-08/msg00007.html The previous behavior involved the ispell process terminating prematurely (correct behavior, invalid input) and then calling ispell-accept-output. Because ispell-process had terminated, ispell-accept-output threw its own error, which prevented the underlying error from being displayed. The bug resulted in the following interaction: ispell-word would print out: =22Starting new Ispell process aspell with default dictionary...done=22 =22ispell-accept-output: No Ispell process to read output from=21=22 The correct behavior is: =22Starting new Ispell process aspell with default dictionary...done=22 =22cond: Error: =7E/.emacs.d/.local/etc/ispell/.pws: The language =22nil=22= is not known. This is probably because: the file =22/usr/local/Cellar/as= pell/0.60.8/lib/aspell-0.60/nil.dat=22 can not be opened for reading.=22=22= In GNU Emacs 28.0.50 (build 1, x86=5F64-apple-darwin20.5.0, NS appkit-202= 2.50 Version 11.4 (Build 20=4671)) =C2=A0of 2021-08-15 built on Ians-MacBook-Pro-2.local Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.5.2 Configured using: =C2=A0'configure --disable-dependency-tracking --disable-silent-rules =C2=A0--enable-locallisppath=3D/usr/local/share/emacs/site-lisp =C2=A0--infodir=3D/usr/local/Cellar/emacs-plus=4028/28.0.50/share/info/em= acs =C2=A0--prefix=3D/usr/local/Cellar/emacs-plus=4028/28.0.50 --with-xml2 =C2=A0--with-gnutls --with-native-compilation --without-dbus =C2=A0--with-imagemagick --with-modules --with-rsvg --with-xwidgets --wit= h-ns =C2=A0--disable-ns-self-contained 'C=46LAGS=3D-I/usr/local/opt/gcc/includ= e =C2=A0-I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include =C2=A0-I/usr/local/opt/jpeg/include' 'LD=46LAGS=3D-L/usr/local/lib/gcc/11= =C2=A0-I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include =C2=A0-I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include'' The patch is attached. Ian --6132edb9_1e7ff521_53c Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
This fixes the error handling in ispell-init-proces= s. I encountered this bug, and also saw it mentioned here:&=23160;https://mail.gnu.org/archive/html/auctex/2021-08/m= sg00007.html

The previous behavior involved the ispell process terminating
prematurely (correct behavior, invalid input) and then calling
ispell-accept-output. Because ispell-process had terminated,
ispell-accept-output threw its own error, which prevented the underlying<= br /> error from being displayed.

The bug resulted in the following interaction:
ispell-word would print out:
=22Starting new Ispell process aspell with default dictionary...done=22 =22ispell-accept-output: No Ispell process to read output from=21=22

The correct behavior is:
=22Starting new Ispell process aspell with default dictionary...done=22 =22cond: Error: =7E/.emacs.d/.local/etc/ispell/.pws: The language =22nil=22= is not known. This is probably because: the file =22/usr/local/Cellar/as= pell/0.60.8/lib/aspell-0.60/nil.dat=22 can not be opened for reading.=22=22=


In GNU Emacs 28.0.50 (build 1, x86=5F64-apple-darwin20.5.0, NS appkit-202= 2.50 Version 11.4 (Build 20=4671))
&=23160;of 2021-08-15 built on Ians-MacBook-Pro-2.local
Windowing system distributor 'Apple', version 10.3.2022
System Description: macOS 11.5.2

Configured using:
&=23160;'configure --disable-dependency-tracking --disable-silent-rules &=23160;--enable-locallisppath=3D/usr/local/share/emacs/site-lisp
&=23160;--infodir=3D/usr/local/Cellar/emacs-plus=4028/28.0.50/share/info/= emacs
&=23160;--prefix=3D/usr/local/Cellar/emacs-plus=4028/28.0.50 --with-xml2<= br /> &=23160;--with-gnutls --with-native-compilation --without-dbus
&=23160;--with-imagemagick --with-modules --with-rsvg --with-xwidgets --w= ith-ns
&=23160;--disable-ns-self-contained 'C=46LAGS=3D-I/usr/local/opt/gcc/incl= ude
&=23160;-I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include &=23160;-I/usr/local/opt/jpeg/include' 'LD=46LAGS=3D-L/usr/local/lib/gcc/= 11
&=23160;-I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include &=23160;-I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''

The patch is attached.&=23160;

Ian
--6132edb9_1e7ff521_53c-- --6132edb9_7c3dbd3d_53c Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch" ZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbCBiL2xpc3AvdGV4dG1vZGVzL2lz cGVsbC5lbAppbmRleCBjMmY2YjM1ZGY4Li5jZTA2NTNjNDM0IDEwMDY0NAotLS0gYS9saXNwL3Rl eHRtb2Rlcy9pc3BlbGwuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCkBAIC0yOTIz LDcgKzI5MjMsMTMgQEAgS2VlcHMgYXJndW1lbnQgbGlzdCBmb3IgZnV0dXJlIElzcGVsbCBpbnZv Y2F0aW9ucyBmb3Igbm8gYXN5bmMgc3VwcG9ydC4iCiAJICAgICA7OyBCdXQgZmlyc3Qgd2FpdCB0 byBzZWUgaWYgc29tZSBtb3JlIG91dHB1dCBpcyBnb2luZyB0byBhcnJpdmUuCiAJICAgICA7OyBP dGhlcndpc2Ugd2UgZ2V0IGNvb2wgZXJyb3JzIGxpa2UgIkNhbid0IG9wZW4gIi4KIAkgICAgIChz bGVlcC1mb3IgMSkKLQkgICAgIChpc3BlbGwtYWNjZXB0LW91dHB1dCAzKQorICAgICAgICAgICAg IDs7IFRvIGF2b2lkIGBpc3BlbGwtYWNjZXB0LW91dHB1dCcgdGhyb3dpbmcgaXQncyBvd24KKyAg ICAgICAgICAgICA7OyBlcnJvciwgd2UgY2hlY2sgdGhhdCBpdCB3aWxsIHJlY2VpdmUgZnJvbSBh IHZhbGlkCisgICAgICAgICAgICAgOzsgcHJvY2Vzcy4KKwkgICAgICh3aGVuIChpZiBpc3BlbGwt YXN5bmMtcHJvY2Vzc3AKKyAgICAgICAgICAgICAgICAgICAgICAgICAocHJvY2Vzcy1saXZlLXAg aXNwZWxsLXByb2Nlc3MpCisgICAgICAgICAgICAgICAgICAgICAgIGlzcGVsbC1wcm9jZXNzKQor ICAgICAgICAgICAgICAgKGlzcGVsbC1hY2NlcHQtb3V0cHV0IDMpKQogCSAgICAgKGVycm9yICIl cyIgKG1hcGNvbmNhdCAjJ2lkZW50aXR5IGlzcGVsbC1maWx0ZXIgIlxuIikpKSkKICAgICAgIChz ZXRxIGlzcGVsbC1maWx0ZXIgbmlsKQkJOyBEaXNjYXJkIHZlcnNpb24gSUQgbGluZQogICAgICAg KGxldCAoKGV4dGVuZGVkLWNoYXItbW9kZSAoaXNwZWxsLWdldC1leHRlbmRlZC1jaGFyYWN0ZXIt bW9kZSkpKQo= --6132edb9_7c3dbd3d_53c--