From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: mail--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#48280: 28.0.50; Fix moving directories with the same name to trash Date: Fri, 07 May 2021 19:31:23 +0000 Message-ID: <6ae67348-9c12-ba4c-318a-5d6b50cfd92c@codrut.pro> Reply-To: =?UTF-8?Q?Codru=C8=9B?= Constantin =?UTF-8?Q?Gu=C8=99oi?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_X2sWHRwUecuitarYh1KaxK8p7xdNJOpM5LgfoUut4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8625"; mail-complaints-to="usenet@ciao.gmane.io" To: 48280@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 22:00:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf6eC-000226-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 22:00:28 +0200 Original-Received: from localhost ([::1]:42568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf6eA-0006BV-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 16:00:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf6du-0006AU-Lp for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 16:00:17 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf6dm-00037p-Rp for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 16:00:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf6dm-0002eu-QR for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 16:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Codru=C8=9B?= Constantin =?UTF-8?Q?Gu=C8=99oi?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48280 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162041754510165 (code B ref -1); Fri, 07 May 2021 20:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 May 2021 19:59:05 +0000 Original-Received: from localhost ([127.0.0.1]:45683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf6cq-0002dr-Rd for submit@debbugs.gnu.org; Fri, 07 May 2021 15:59:05 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:42468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf6CJ-0002L2-Qu for submit@debbugs.gnu.org; Fri, 07 May 2021 15:31:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf6CJ-0002mz-Gy for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 15:31:39 -0400 Original-Received: from mail2.protonmail.ch ([185.70.40.22]:44177) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf6CF-0005aT-B8 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 15:31:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codrut.pro; s=protonmail; t=1620415890; bh=f2EQuO0fXWoAeAEo9xQZoKUPUWB98gMROhZ1gzbr+84=; h=Date:To:From:Reply-To:Subject:From; b=NP5/ezHxec3WbToDpA6400fuYUGTruFdiSudDH3xrMRMKeOuLwBloToazQp9ZGtwC 6OQRrHxBbFYGrQ5aHeeEqzOjRDrQk/laMSfEMt5ppxlI4pSHEI2SK+hP757Cq/ZZiI pu9RTrg3yOOKlJGNLbzLrdYarpkyVjSQ/MxzSTaPxNj+AwyxvsxeYq0uaAK8p5PhsU 7db+NDwOvfYVYOKDbZq/ZOJ7zd/ROp+HKtT4lhkJ5KyTB6Mj+znS3ltivpwXCV3NNp AICRlGdQdnJ8j/qJcORN8/SPBNQKkC32FzggCsQKwYdZzgRzS/XN3iQAP7Iy8bpdi5 636le8B+XRucQ== Received-SPF: pass client-ip=185.70.40.22; envelope-from=mail@codrut.pro; helo=mail2.protonmail.ch X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_PRO_TLD=1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 07 May 2021 15:59:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" X-ACL-Warn: , =?UTF-8?Q?Codru=C8=9B?= Constantin =?UTF-8?Q?Gu=C8=99oi?= Xref: news.gmane.io gmane.emacs.bugs:205961 Archived-At: This is a multi-part message in MIME format. --b1_X2sWHRwUecuitarYh1KaxK8p7xdNJOpM5LgfoUut4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, I've attached a patch for this bug I was dealing with while trying out 28.0.50 commit a2842a11728336fc8110eedb5176ecfbe71bbc79. Refs: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D47135 To reproduce, save this to a `bug.el` file: ```elisp (setq delete-by-moving-to-trash t) (let ((test-dir "~/test123")) =C2=A0 (progn =C2=A0=C2=A0=C2=A0 (message "Creating directory: 1") =C2=A0=C2=A0=C2=A0 (make-directory test-dir) =C2=A0=C2=A0=C2=A0 (message "Deleting directory: 1") =C2=A0=C2=A0=C2=A0 (delete-directory test-dir t t) =C2=A0=C2=A0=C2=A0 (message "Creating directory: 2") =C2=A0=C2=A0=C2=A0 (make-directory test-dir) =C2=A0=C2=A0=C2=A0 (message "Deleting directory: 2") =C2=A0=C2=A0=C2=A0 (delete-directory test-dir t t) =C2=A0=C2=A0=C2=A0 (message "Success!"))) ``` And execute with: `emacs -nw -Q -l ./bug.el`. Expected: "Success!" Actual: "Renaming: Not a directory, /home/me/test123, /home/me/.local/share/Trash/files/test123Wiibmk" Please let me know what you think, looking forward to getting this fixed. Cheers, Codru=C8=9B www.codrut.pro --b1_X2sWHRwUecuitarYh1KaxK8p7xdNJOpM5LgfoUut4 Content-Type: text/x-patch; name=0001-Fix-moving-directories-with-the-same-name-to-trash.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Fix-moving-directories-with-the-same-name-to-trash.patch RnJvbSA4YWExZTljOWU1NWQ0ZDNjODU3MDQ4YjJiYzVmNTIwNjZkOTUzYWM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogPT9VVEYtOD9xP0NvZHJ1PUM4PTlCPTIwQ29uc3RhbnRpbj0y MEd1PUM4PTk5b2k/PQ0KIDxtYWlsK2VtYWNzQGNvZHJ1dC5wcm8+DQpEYXRlOiBGcmksIDcgTWF5 IDIwMjEgMTk6MjA6NDUgKzAxMDANClN1YmplY3Q6IEZpeCBtb3ZpbmcgZGlyZWN0b3JpZXMgd2l0 aCB0aGUgc2FtZSBuYW1lIHRvIHRyYXNoDQoNClJlZnM6IGh0dHBzOi8vZGViYnVncy5nbnUub3Jn L2NnaS9idWdyZXBvcnQuY2dpP2J1Zz00NzEzNQ0KDQpUbyByZXByb2R1Y2UsIHNhdmUgdGhpcyB0 byBhIGBidWcuZWxgIGZpbGU6DQoNCmBgYGVsaXNwDQooc2V0cSBkZWxldGUtYnktbW92aW5nLXRv LXRyYXNoIHQpDQoNCihsZXQgKCh0ZXN0LWRpciAifi90ZXN0MTIzIikpDQogIChwcm9nbg0KICAg IChtZXNzYWdlICJDcmVhdGluZyBkaXJlY3Rvcnk6IDEiKQ0KICAgIChtYWtlLWRpcmVjdG9yeSB0 ZXN0LWRpcikNCiAgICAobWVzc2FnZSAiRGVsZXRpbmcgZGlyZWN0b3J5OiAxIikNCiAgICAoZGVs ZXRlLWRpcmVjdG9yeSB0ZXN0LWRpciB0IHQpDQoNCiAgICAobWVzc2FnZSAiQ3JlYXRpbmcgZGly ZWN0b3J5OiAyIikNCiAgICAobWFrZS1kaXJlY3RvcnkgdGVzdC1kaXIpDQogICAgKG1lc3NhZ2Ug IkRlbGV0aW5nIGRpcmVjdG9yeTogMiIpDQogICAgKGRlbGV0ZS1kaXJlY3RvcnkgdGVzdC1kaXIg dCB0KQ0KDQogICAgKG1lc3NhZ2UgIlN1Y2Nlc3MhIikpKQ0KYGBgDQoNCkFuZCBleGVjdXRlIHdp dGg6IGBlbWFjcyAtbncgLVEgLWwgLi9idWcuZWxgLg0KDQpFeHBlY3RlZDogIlN1Y2Nlc3MhIg0K QWN0dWFsOiAiUmVuYW1pbmc6IE5vdCBhIGRpcmVjdG9yeSwgL2hvbWUvbWUvdGVzdDEyMywNCi9o b21lL21lLy5sb2NhbC9zaGFyZS9UcmFzaC9maWxlcy90ZXN0MTIzV2lpYm1rIg0KDQpMb29rcyBs aWtlIHRoZSBjb2RlIHdhcyBjcmVhdGluZyBhIHRlbXAgZmlsZSBpbiB0aGUgdHJhc2ggYmluIGFu ZCB0aGVuDQp0cnlpbmcgdG8gbW92ZSB0aGUgZGlyZWN0b3J5IG92ZXJ3cml0aW5nIGl0LiBJIGFz c3VtZSB0aGUgaW50ZW50IHdhcyB0bw0Kb25seSBnZXQgYSB1bmlxdWUgZmlsZSBuYW1lLCBhbmQg bm90IGFjdHVhbGx5IGNyZWF0ZSBhIGZpbGUsIHJlYXNvbiB3aHkNCkkgY2FuZ2VkIHRoZSBmdW5j dGlvbiBjYWxsIHRvIGJlIGBtYWtlLXRlbXAtbmFtZWAuDQotLS0NCiBsaXNwL2ZpbGVzLmVsIHwg MiArLQ0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KDQpk aWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3AvZmlsZXMuZWwNCmluZGV4IDkzYTBlMDdh YmEuLmRhMzNlZTgxNWYgMTAwNjQ0DQotLS0gYS9saXNwL2ZpbGVzLmVsDQorKysgYi9saXNwL2Zp bGVzLmVsDQpAQCAtNzkzMiw3ICs3OTMyLDcgQEAgbW92ZS1maWxlLXRvLXRyYXNoDQogICAgICAg ICAgICAgICAgICAgICAgICAgKGV4cGFuZC1maWxlLW5hbWUgZmlsZXMtYmFzZSB0cmFzaC1maWxl cy1kaXIpKQ0KICAgICAgICAgICAgICAgICAgICAoc2V0cSBvdmVyd3JpdGUgdA0KICAgICAgICAg ICAgICAgICAgICAgICAgICBmaWxlcy1iYXNlIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5DQotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChtYWtlLXRlbXAtZmlsZQ0KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAobWFrZS10ZW1wLW5hbWUNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChleHBhbmQtZmlsZS1uYW1lDQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmlsZXMtYmFzZSB0cmFzaC1maWxlcy1k aXIpKSkpKQ0KIAkJIChzZXRxIGluZm8tZm4gKGV4cGFuZC1maWxlLW5hbWUNCi0tIA0KMi4zMS4x DQoNCg== --b1_X2sWHRwUecuitarYh1KaxK8p7xdNJOpM5LgfoUut4--