From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Change module interface to no longer use GMP objects directly. Date: Sat, 23 Nov 2019 15:10:27 -0800 Organization: UCLA Computer Science Department Message-ID: <6ae3224d-6f39-fb55-49e6-b032885da209@cs.ucla.edu> References: <20191117183828.82379-1-phst@google.com> <089f3d06-e227-27da-c8fe-afcbbbbc934a@cs.ucla.edu> <10cefdff-38ce-438b-881d-15d2fe816a8b@cs.ucla.edu> <3d727645-911e-fc71-1f86-364aa82d06ba@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="50577"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Philipp Stephani , Stefan Monnier , Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 24 00:10:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iYeYA-000D3c-LU for ged-emacs-devel@m.gmane.org; Sun, 24 Nov 2019 00:10:46 +0100 Original-Received: from localhost ([::1]:33112 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYeY9-0000L7-Bh for ged-emacs-devel@m.gmane.org; Sat, 23 Nov 2019 18:10:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36013) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iYeY1-0000IR-Nh for emacs-devel@gnu.org; Sat, 23 Nov 2019 18:10:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iYeY0-0007L7-PJ for emacs-devel@gnu.org; Sat, 23 Nov 2019 18:10:37 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33232) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iYeY0-0007I2-JR for emacs-devel@gnu.org; Sat, 23 Nov 2019 18:10:36 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 57FDE16027E; Sat, 23 Nov 2019 15:10:29 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 5luAnTHPkMqN; Sat, 23 Nov 2019 15:10:27 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DCD381604E9; Sat, 23 Nov 2019 15:10:27 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4qBUm3aqasPD; Sat, 23 Nov 2019 15:10:27 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AFE5216027E; Sat, 23 Nov 2019 15:10:27 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242667 Archived-At: On 11/23/19 12:08 PM, Philipp Stephani wrote: > stdio.h is part of the C implementation, but emacs-module.h is not. >> > And developers do not expect /usr/include/stdio.h to be the same >> > on all platforms; why would they expect /usr/include/emacs-module.h to >> > be the same? > > Because stdio.h is part of the C implementation, but emacs-module.h is not. What difference does that make to the module developer? emacs-module.h includes and other files that are implementation-dependent. Because of this, from the developer's point of view "#include " is just as implementation-dependent as "#include " is, which means developers must be cognizant of platform dependencies anyway. So I still don't why it's crucial that emacs-module.h is byte-for-byte identical on all platforms. > - Documenting the restriction on the number of magnitude array elements. > - Using a typedef emacs_limb_t for the magnitude array elements, with > the guarantee that's is a stable unsigned integer type. I will make > emacs_limb_t an alias of unsigned long long if ULONG_MAX <= > 0xFFFFFFFF, and an alias of unsigned long otherwise. Thanks, that'll be an improvement.