From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#14925: 24.3.50; `image-dired.el' code (minor) Date: Sun, 21 Jul 2013 12:37:24 -0700 (PDT) Message-ID: <6a9c11fa-71ad-44f9-9771-35626a56ee01@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1374435488 24990 80.91.229.3 (21 Jul 2013 19:38:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Jul 2013 19:38:08 +0000 (UTC) To: 14925@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 21 21:38:08 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V0zSK-0005EL-MN for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2013 21:38:08 +0200 Original-Received: from localhost ([::1]:34450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0zSJ-0006I3-UA for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Jul 2013 15:38:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0zSG-0006Hw-01 for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0zSF-0007MS-2L for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:38:03 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0zSE-0007MO-Uf for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V0zSE-0002vZ-Lk for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Jul 2013 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14925 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.137443545811165 (code B ref -1); Sun, 21 Jul 2013 19:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Jul 2013 19:37:38 +0000 Original-Received: from localhost ([127.0.0.1]:41280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V0zRp-0002ty-F3 for submit@debbugs.gnu.org; Sun, 21 Jul 2013 15:37:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55137) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V0zRm-0002tf-Hx for submit@debbugs.gnu.org; Sun, 21 Jul 2013 15:37:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0zRg-0007Go-05 for submit@debbugs.gnu.org; Sun, 21 Jul 2013 15:37:29 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:33772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0zRf-0007Gk-TM for submit@debbugs.gnu.org; Sun, 21 Jul 2013 15:37:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0zRe-0006GA-SN for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:37:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0zRd-0007GO-Dx for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:37:26 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:40094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0zRd-0007G8-4X for bug-gnu-emacs@gnu.org; Sun, 21 Jul 2013 15:37:25 -0400 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r6LJbNHl021249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 21 Jul 2013 19:37:24 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6LJbMgT000611 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 21 Jul 2013 19:37:23 GMT Original-Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r6LJbMxV002533 for ; Sun, 21 Jul 2013 19:37:22 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76551 Archived-At: Generally, it would be better if `image-dired.el' followed the conventions used in dired.el, dired-aux.el, and dired-x.el wrt (a) naming and (b) parameter ARG (prefix argument). That helps users by providing relatively consistent command names and UI behavior. Also a minor coding remark (#1). 1. `image-dired-dired-file-marked-p' uses regexp "^ .*$", which I think is the same as "^ " (which is simpler). I also wonder why it does not just use `dired-re-mark'. 2. Commands that act on the marked files should perhaps follow the naming convention used in dired.el, dired-aux.el, and dired-x.el: `*-do-*'. Thus perhaps rename `image-dired-dired-comment-files', `image-dired-tag-files', `image-dired-delete-tag', `image-dired-display-thumbs', `image-dired-copy-with-exif-file-name', `image-dired-dired-edit-comment-and-tags', and `image-dired-create-thumbs'. The equivalent Dired command that acts on the current file only, when available, is named similarly, but without the `*-do-*' part. 3. Those commands do not treat parameter ARG the same way as do the Dired `*-do-*' commands. For the image-dired commands, ARG is essentially boolean (and should thus have a name that reflects that). Wouldn't it be better for it to be the `prefix-numeric-value' and let you act on the next ARG files? That would give users more flexibility and provide a more consistent UI. Is there a downside I am missing? In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-07-14 on ODIEONE Bzr revision: 113423 lekktu@gmail.com-20130715004922-i67tg2ois14h3fpm Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs CFLAGS=3D'-O0 -g3' CPPFLAGS=3D'-Ic:/Devel/emacs/include' LDFLAGS=3D'-Lc:/Devel/emacs/lib''