From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: David Ponce Newsgroups: gmane.emacs.bugs Subject: bug#66846: 30.0.50; unexpected behavior of icon with non-existing image file? Date: Tue, 31 Oct 2023 13:29:43 +0100 Message-ID: <6a6a88f4-dc7c-44a4-9f09-5b3f184df971@orange.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36453"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: 66846@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 31 13:30:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxntR-0009Nh-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Oct 2023 13:30:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxnt8-0007yu-Cv; Tue, 31 Oct 2023 08:30:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxnt6-0007yb-ND for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 08:30:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxnt6-0007UG-Ei for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 08:30:28 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxntd-0002Yt-Sz for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 08:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Ponce Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Oct 2023 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66846 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16987554369812 (code B ref -1); Tue, 31 Oct 2023 12:31:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 Oct 2023 12:30:36 +0000 Original-Received: from localhost ([127.0.0.1]:47688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxntE-0002YB-51 for submit@debbugs.gnu.org; Tue, 31 Oct 2023 08:30:36 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:56160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxntB-0002Xt-0T for submit@debbugs.gnu.org; Tue, 31 Oct 2023 08:30:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxnsV-0007wo-KW for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 08:29:51 -0400 Original-Received: from smtp-27.smtpout.orange.fr ([80.12.242.27] helo=smtp.smtpout.orange.fr) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxnsT-0007AL-4Q for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2023 08:29:51 -0400 Original-Received: from [192.168.1.15] ([2.7.71.181]) by smtp.orange.fr with ESMTPA id xnsNqdsNh4FJ9xnsNquQMf; Tue, 31 Oct 2023 13:29:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1698755384; bh=1jTLg2IBQ8NGR1q1zOIJBPMtEkePyLfLWlbO8Hf2h+E=; h=Date:To:From:Subject; b=lQfXUka0sidS89rAg9/a6es/+V5KCL0gl4SQ5c5WIFtYlpcAqlAK5p9QQYqdLBFvk iP9aErpd6jXvpr33ooVHbhX+DRjWES6Qb6CBmUuNmPscuvInjfzwVhVBll/7VOzwvr MbMhwfc6I3vjKoc91omqZmcw7zueHcRmNIZ3C7JXMuLbtLT2fwQeG9KYghu1MS87ZM pyGac62guWnUHBZ0eT1nRH3JHi/klPzwiSxS9vUNpAA9pOeaH0WOMXTGL5lwgRS7Ls MHp/fm80OLtXF8fUW2ZgPmz9Lc222/Egi54TC6x3USG6+tXmVAiimtPi+hwU6cNfmh Gi1a8J4ePGBgQ== X-ME-Helo: [192.168.1.15] X-ME-Auth: ZGFfdmlkQHdhbmFkb28uZnI= X-ME-Date: Tue, 31 Oct 2023 13:29:44 +0100 X-ME-IP: 2.7.71.181 Content-Language: fr, en-US Received-SPF: pass client-ip=80.12.242.27; envelope-from=da_vid@orange.fr; helo=smtp.smtpout.orange.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273564 Archived-At: Hello, I found a possible unexpected behavior with image in icon spec. Here are 2 small recipes that illustrate this. In both cases the image doesn't exist and maybe `icon-string' should return the text value of the icon, instead of failing like illustrated below (emacs -Q): ;; TEST 1 with relative file name. ;; Raise a wrong-type-argument error instead of inserting the text ;; "test". (define-icon test nil '((image "does-not-exist.svg") (text "test")) "Test icon." :version "30") (insert (icon-string 'test)) Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match("\\.png\\'" nil nil t) image-supported-file-p(nil) ... ;; TEST 2 with absolute file name. ;; Insert an invalid image instead of the text "test". (define-icon test1 nil '((image "/does-not-exist.svg") (text "test")) "Test1 icon." :version "30") ((button custom-icon) (test1 custom-icon)) (insert (icon-string 'test1)) nil Please find a possible fix in the below patch to icons.el: diff --git a/lisp/emacs-lisp/icons.el b/lisp/emacs-lisp/icons.el index 9a6d26243c7..dec8eaa9fac 100644 --- a/lisp/emacs-lisp/icons.el +++ b/lisp/emacs-lisp/icons.el @@ -188,10 +188,11 @@ icons--merge-spec (cl-defmethod icons--create ((_type (eql 'image)) icon keywords) (let ((file (if (file-name-absolute-p icon) - icon + (and (file-readable-p icon) icon) (and (fboundp 'image-search-load-path) (image-search-load-path icon))))) - (and (display-images-p) + (and file + (display-images-p) (fboundp 'image-supported-file-p) (image-supported-file-p file) (propertize In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) Repository revision: ecc8870981ef1a802f9504b1d0f261d19ab372b1 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 38 (KDE Plasma) Configured using: 'configure PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/usr/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_TIME: fr_FR.utf8 value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 37932 10514) (symbols 48 5212 0) (strings 32 13264 1275) (string-bytes 1 378221) (vectors 16 10360) (vector-slots 8 157502 10085) (floats 8 38 21) (intervals 56 220 0) (buffers 992 10))