all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: pillule <pillule@riseup.net>
Cc: 48367@debbugs.gnu.org
Subject: bug#48367: 28.0.50; quit-restore-window may jam
Date: Wed, 12 May 2021 14:32:49 +0200	[thread overview]
Message-ID: <6a45ac55-4727-adca-009c-f4634619c21b@gmx.at> (raw)
In-Reply-To: <87v97o42io.fsf@host.localdomain>

 > Looking at the CONTRIBUTE file, I have done this new version with `git format-patch -l1',
 > Is that overall better ?

Yes.

 > Is that OK to call a cl-lib function in the second patch even if this library is not required in window.el ?

No.  I only re-compiled and did not build.  Please try to avoid it since
otherwise we get a

In end of data:
../../lisp/window.el:5039:29: Warning: the function ‘cl-find-if-not’ is not
     known to be defined.

warning.

 >> Also, have you signed the copyright agreement for Emacs?  How should I
 >> call you in the commit?  "pillule"?
 >
 > No, I have not yet signed the agreement, I contact assign@gnu.org today to do so. I was hoping sloppily that you consider these contributions as trivial.

They are trivial and we don't need an assignment for them.  But signing
the agreement is always a good idea.

 > If it is fine for you to use my pseudonym, it is fine for me.

Then "pillule" be it.

Thanks again, martin






  reply	other threads:[~2021-05-12 12:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 20:26 bug#48367: 28.0.50; quit-restore-buffer may jam pillule
2021-05-12  8:47 ` martin rudalics
2021-05-12 11:25   ` bug#48367: 28.0.50; quit-restore-window " pillule
2021-05-12 12:32     ` martin rudalics [this message]
2021-05-12 14:10       ` pillule
2021-05-12 16:40         ` martin rudalics
2021-05-15  8:56         ` martin rudalics
2021-05-15 10:34           ` pillule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a45ac55-4727-adca-009c-f4634619c21b@gmx.at \
    --to=rudalics@gmx.at \
    --cc=48367@debbugs.gnu.org \
    --cc=pillule@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.