all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kbrown@cornell.edu, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows
Date: Sat, 29 Jun 2019 21:08:46 -0700	[thread overview]
Message-ID: <6a3dbb42-d2ca-82ea-0cfb-0139e0a70f6e@cs.ucla.edu> (raw)
In-Reply-To: <83lfxjg5jj.fsf@gnu.org>

Eli Zaretskii wrote:
> divide_double part obfuscates the code for no good reason.

I'm sure we can clear it up. It replaces the check against FLT_MIN, which to my 
mind was even more obscure as there are no 'float' values in sight.

What is the failure scenario here? Is it not floating-point division by zero?



  reply	other threads:[~2019-06-30  4:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190629115503.5317.97999@vcs0.savannah.gnu.org>
     [not found] ` <20190629115506.BDED9208EA@vcs0.savannah.gnu.org>
2019-06-29 19:21   ` [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows Ken Brown
2019-06-30  0:00     ` Paul Eggert
2019-06-30  2:39       ` Eli Zaretskii
2019-06-30  4:08         ` Paul Eggert [this message]
2019-06-30 14:21           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a3dbb42-d2ca-82ea-0cfb-0139e0a70f6e@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kbrown@cornell.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.