From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) Date: Thu, 4 May 2023 02:39:21 +0300 Message-ID: <6a09451b-88dd-ff00-2bdc-cb34d457adef@gutov.dev> References: <168263878553.23108.4718240877999827191@vcs2.savannah.gnu.org> <20230427233949.44D31C22A13@vcs2.savannah.gnu.org> <20f53b0a-d6ff-8ec0-2f8c-e0e22b2d49dc@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11968"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: emacs-devel@gnu.org To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 04 01:40:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puM56-0002w8-OK for ged-emacs-devel@m.gmane-mx.org; Thu, 04 May 2023 01:40:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puM4L-00076J-1X; Wed, 03 May 2023 19:39:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puM4I-000761-7h for emacs-devel@gnu.org; Wed, 03 May 2023 19:39:30 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puM4G-0000Or-27 for emacs-devel@gnu.org; Wed, 03 May 2023 19:39:29 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B16D13200A82; Wed, 3 May 2023 19:39:24 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 03 May 2023 19:39:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1683157164; x=1683243564; bh=s/p3tpmjdSOfOT6YX67zO4LatOchEndJEUT HN6xbuAE=; b=R9lw6xFKR2QrhCJoBN8PiiymmNCnVkWlrWwEG6dMumKP6H69/oD tc+aGFTcUCscsd1lryHhpX1oGV2RR70bckGSkVfFDi9ws8Q2TF4HDhnFCNKr/1EC JZ4fXOtwZKQB7+rL+9jSkiAitT2xIYK7lHtjCtJitV6Di2TBaa8NPjCD1m1D+n/8 +l03FvCZkMK93tvv0fcuohItM7tYkQxF6/Epvj2UQxebczELw6NjGZ+5y/2NZndr iHNOqH4wS+jTAMlsvx0DkwBKtV7BJgj+5pcfwiyjV8Tf9l0mU5w189PV3Rp0MKAb w3oVNZk3wbNt0/TCUOMCuKTIJZ3jd6+JfoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683157164; x=1683243564; bh=s/p3tpmjdSOfOT6YX67zO4LatOchEndJEUT HN6xbuAE=; b=Z2uFt7ZwrCTs3mHKovuK+N5iZMtgjrXiZYJu3rVEKKFKKPdlZRa u4FH5lXjh4Cp8jm8DuGOLOh0VbwDIQ3o70vcPOfkD7uUSvC5pXoHjmxx1SQvZogZ aOERY6Yr1eM8FJcGWptIwzunS1oyYTiFi9dlNJbfYKrwOhpW6kc3/OmoiH05gulT rWIYnsahSJxwRJgtpdE55xCRDcytECHQ+Uayynj/LXHFkjXQuS5aY47CnMLwxogR VMWfUOVW3vFIv/lR6eVpRaDP+m2chbRFuflLeoSnWA8Yjucx8OJTnlKbKKOxIauK 4s6ClwHnqC2sF2lzou75NMdUQvaAVTeXnJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvledgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepvdetffektdfftdelledtgedtuddufffhvdeilefgfedujefhheeiueeugfeh geeunecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 May 2023 19:39:23 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=64.147.123.20; envelope-from=dmitry@gutov.dev; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -70 X-Spam_score: -7.1 X-Spam_bar: ------- X-Spam_report: (-7.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.28, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305805 Archived-At: On 04/05/2023 02:31, João Távora wrote: > On Wed, May 3, 2023 at 11:48 PM Dmitry Gutov wrote: >> On 28/04/2023 03:35, João Távora wrote: >>> On Fri, Apr 28, 2023 at 12:53 AM Dmitry Gutov wrote: >>>> Hi! >>>> >>>> On 28/04/2023 02:39, João Távora wrote: >>>>> * lisp/progmodes/eglot.el (eglot-update): New command. >>>> Should it be called eglot-upgrade now as well? >>> No objection, don't feel strongly about it. If you want to >>> change it, go ahead, but remember to change the manual as >>> well. >> Ok, I did the rename. > Hmmm, unfortunate. I thought you had abandoned the idea, > as you didn't reply to that part specifically. I did reply, with a question. > The problem > is that Eglot 1.15, released in the meantime, now has > eglot-update. So I think we should rename it back in Emacs 29, > sorry. Either that or release Eglot 1.16 asap. I figured it wouldn't be required of me to fix the consistency of function naming in your package. But nobody else did it. I don't think it's really important to keep backward compatibility between Eglot 1.15 and 1.16 (as we've noted before, only the latest version remains). And just like there's likely no callers of package-update out-of-tree, I don't imagine there's going to be a lot of Lisp code calling eglot-update as well. Up to you either way. >> Two more things: >> >> - Commit 44ebd9cbd56 also removed the call to (eldoc) from the end of >> eglot-completion-at-point which has been there for a few years. Was that >> intentional? Didn't look like it. > Not intentional no. Well, at least not for that commit. > Not pretty, but I wouldn't worry about it. So it's not a breakage? Okay then. >> - Consider the issue that I brought up in >> https://debbugs.gnu.org/62720#715 regarding (cadr (assoc 'eglot >> package-archive-contents)). I'm not sure there's even a guarantee that >> the available versions are sorted, but even if they are obeying >> package-archive-priorities seems like a good idea. Though I can >> understand if it's not your first priority in this command. > Is this a problem that can affect the Eglot package > specifically? In which conditions? The user customizes priorities for GNU ELPA and GNU-devel, and 'M-x eglot-upgrade' upgrades to a version from the archive with lower priority. Something like that.