all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: Christophe TROESTLER <Christophe.TROESTLER@umons.ac.be>
Cc: Eli Zaretskii <eliz@gnu.org>,
	"73877@debbugs.gnu.org" <73877@debbugs.gnu.org>,
	Stefan Kangas <stefankangas@gmail.com>
Subject: bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals
Date: Fri, 15 Nov 2024 00:11:54 +0000	[thread overview]
Message-ID: <6Lmo0XWams3ZDY4jnbU-3T-4oJIwmc-2NDwLWRUj6KG305DWdW_uT3MXPN4otagtPXr7gf8QcdE3CjoIKkJUIrY9c-Ulj-QC1JNJm2yKKac=@rjt.dev> (raw)
In-Reply-To: <878qtquf1l.fsf@poincare.umons.ac.be>

On Monday, November 11th, 2024 at 07:32, Christophe TROESTLER <Christophe.TROESTLER@umons.ac.be> wrote:
> 
> 
> 
> Thanks Eli Zaretskii and Randy Taylor for your remarks. An undated patch is attached.
> 
> On 2 November 2024 at 20:48 +01, Randy Taylor dev@rjt.dev wrote:
> 
> > […] Unless I am missing something, the variables should reset
> > automatically. They are only changed in the context of the test.
> > 
> > How are you running them that you are seeing otherwise?
> 
> 
> I now am using the command line but, if I evaluate the tests (C-xC-e) and then run them with M-x ert, the variable 'rust-ts-mode-fontify-number-suffix-as-type' is not reset to its original value.
> 
> Best,
> C.

Ah, sorry. I had only tried with treesit-font-lock-level myself since
the patch didn't apply cleanly for me and I didn't have a chance to
manually apply it, and I glossed over how the variables are set
differently. If you do the same as treesit-font-lock-level, i.e.,
place it in the let instead of setq, then it will reset properly.
You will also need to: (require 'rust-ts-mode)
After you make that change, I think you should be able to get rid of
this:
+(put 'rust-ts-mode-fontify-number-suffix-as-type 'safe-local-variable
+     'booleanp)

In the font-lock-number.rs file, it looks like there is an extraneous
newline at the top of the file.

BTW the current patch still doesn't apply against the latest master
for me.





  reply	other threads:[~2024-11-15  0:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19 10:56 bug#73877: 30; rust-ts-mode: highlight the possible type suffix of number literals Christophe TROESTLER
2024-10-20 12:00 ` Stefan Kangas
2024-10-22 23:05   ` Randy Taylor
2024-10-24 15:22     ` Christophe TROESTLER
2024-10-27 19:07       ` Randy Taylor
2024-10-28 21:56         ` Christophe TROESTLER
2024-11-02 11:01           ` Eli Zaretskii
2024-11-02 19:48           ` Randy Taylor
2024-11-11 12:32             ` Christophe TROESTLER
2024-11-15  0:11               ` Randy Taylor [this message]
2024-11-18 15:14                 ` Christophe TROESTLER
2024-11-22  0:57                   ` Randy Taylor
2024-11-22  7:23                     ` Christophe TROESTLER
2024-11-23 12:58                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='6Lmo0XWams3ZDY4jnbU-3T-4oJIwmc-2NDwLWRUj6KG305DWdW_uT3MXPN4otagtPXr7gf8QcdE3CjoIKkJUIrY9c-Ulj-QC1JNJm2yKKac=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=73877@debbugs.gnu.org \
    --cc=Christophe.TROESTLER@umons.ac.be \
    --cc=eliz@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.