From: Randy Taylor <dev@rjt.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yordanm@proton.me, casouri@gmail.com, 63708@debbugs.gnu.org
Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe
Date: Mon, 29 May 2023 13:20:58 +0000 [thread overview]
Message-ID: <6KowwZUmaJ_qJFx3ZNXCIxvjbM0ii9GDN6UnqJvuzTtmpoJeZ9hQkH8CWJaDInCSQMszlpw-C0r9DwyISsxq4wG_i1ugunSVUrYtbvMRx8Y=@rjt.dev> (raw)
In-Reply-To: <83leh7gu1g.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]
On Monday, May 29th, 2023 at 09:12, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Mon, 29 May 2023 12:18:38 +0000
>
> > From: Randy Taylor dev@rjt.dev
> > Cc: yordanm@proton.me, 63708@debbugs.gnu.org, casouri@gmail.com
> >
> > On Monday, May 29th, 2023 at 08:12, Eli Zaretskii eliz@gnu.org wrote:
> >
> > > > Date: Mon, 29 May 2023 01:29:31 +0000
> > >
> > > > From: Randy Taylor dev@rjt.dev
> > > > Cc: Eli Zaretskii eliz@gnu.org, 63708@debbugs.gnu.org, casouri@gmail.com
> > > >
> > > > I won't be committing them (don't have the ability) but Eli likely will.
> > > >
> > > > If you'd like to go through them all and check, that would be great. However, for non-trivial contributions (i.e. more than 15 lines of code changes across all your contributions I believe) you will need to assign copyright to the FSF, otherwise the changes can't be accepted. Eli can send you the form to fill out if you're interested.
> > >
> > > It is unfortunate that the patch was posted before asking about such
> > > non-trivial submissions, because we are now stuck due to lack of
> > > copyright assignment, and the release branch must either wait for the
> > > assignment or live with the bug.
> > >
> > > Йордан, can you think of a way of rewriting the go-ts-mode patch so
> > > that it uses fewer than 15 lines?
> >
> > The go-ts-mode patch can be rewritten in a single line by just updating the syntax table directly like I suggested. Then we should be OK.
>
>
> Thanks, then please post such a patch.
Attached.
>
> What about rust-ts-mode?
I will reply to that thread directly.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-go-ts-mode-Treat-apostrophes-as-strings-Bug-63708.patch --]
[-- Type: text/x-patch; name=0001-go-ts-mode-Treat-apostrophes-as-strings-Bug-63708.patch, Size: 940 bytes --]
From 8994c842946da4e8234d8b87068827d1c6185342 Mon Sep 17 00:00:00 2001
From: Randy Taylor <dev@rjt.dev>
Date: Mon, 29 May 2023 09:16:10 -0400
Subject: [PATCH] go-ts-mode: Treat apostrophes as strings (Bug#63708)
* lisp/progmodes/go-ts-mode.el (go-ts-mode--syntax-table): Treat
apostrophes as strings.
---
lisp/progmodes/go-ts-mode.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/progmodes/go-ts-mode.el b/lisp/progmodes/go-ts-mode.el
index 4233b115f19..698c6424ea2 100644
--- a/lisp/progmodes/go-ts-mode.el
+++ b/lisp/progmodes/go-ts-mode.el
@@ -58,6 +58,7 @@ go-ts-mode--syntax-table
(modify-syntax-entry ?< "." table)
(modify-syntax-entry ?> "." table)
(modify-syntax-entry ?\\ "\\" table)
+ (modify-syntax-entry ?\' "\"" table)
(modify-syntax-entry ?/ ". 124b" table)
(modify-syntax-entry ?* ". 23" table)
(modify-syntax-entry ?\n "> b" table)
--
2.40.1
next prev parent reply other threads:[~2023-05-29 13:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 21:40 bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-24 22:05 ` bug#63709: " yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25 5:28 ` Eli Zaretskii
2023-05-25 5:31 ` bug#63708: " Eli Zaretskii
2023-05-25 12:52 ` Randy Taylor
2023-05-25 13:13 ` Eli Zaretskii
2023-05-26 2:21 ` Randy Taylor
2023-05-26 19:14 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-27 3:00 ` Randy Taylor
2023-05-28 19:51 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-28 19:52 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 11:25 ` Eli Zaretskii
2023-05-29 13:34 ` Randy Taylor
2023-05-29 1:29 ` Randy Taylor
2023-05-29 12:13 ` Eli Zaretskii
2023-05-29 12:18 ` Randy Taylor
2023-05-29 13:13 ` Eli Zaretskii
2023-05-29 13:20 ` Randy Taylor [this message]
2023-05-29 14:13 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-29 14:27 ` Eli Zaretskii
2023-05-29 14:54 ` Йордан Миладинов
2023-05-29 14:59 ` Eli Zaretskii
2023-05-30 0:14 ` Randy Taylor
2023-05-30 9:44 ` yordanm--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-03 8:35 ` Eli Zaretskii
2023-05-30 9:10 ` Йордан Миладинов
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6KowwZUmaJ_qJFx3ZNXCIxvjbM0ii9GDN6UnqJvuzTtmpoJeZ9hQkH8CWJaDInCSQMszlpw-C0r9DwyISsxq4wG_i1ugunSVUrYtbvMRx8Y=@rjt.dev' \
--to=dev@rjt.dev \
--cc=63708@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=yordanm@proton.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.