From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: bookmarks / switch-to-buffer Date: Thu, 10 Nov 2005 00:49:15 +0000 Message-ID: <6FE5EC78-45A4-462C-B927-1480A2B2CE75@gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (Apple Message framework v746.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1131583879 12939 80.91.229.2 (10 Nov 2005 00:51:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 10 Nov 2005 00:51:19 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 10 01:51:09 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ea0dH-0005Ii-Ff for ged-emacs-devel@m.gmane.org; Thu, 10 Nov 2005 01:49:39 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ea0dG-00061b-Pk for ged-emacs-devel@m.gmane.org; Wed, 09 Nov 2005 19:49:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ea0d1-0005y0-VZ for emacs-devel@gnu.org; Wed, 09 Nov 2005 19:49:24 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ea0cz-0005vi-T3 for emacs-devel@gnu.org; Wed, 09 Nov 2005 19:49:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ea0cz-0005vc-Oh for emacs-devel@gnu.org; Wed, 09 Nov 2005 19:49:21 -0500 Original-Received: from [64.233.182.199] (helo=nproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Ea0cz-0004US-TM for emacs-devel@gnu.org; Wed, 09 Nov 2005 19:49:22 -0500 Original-Received: by nproxy.gmail.com with SMTP id k27so107376nfc for ; Wed, 09 Nov 2005 16:49:20 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:mime-version:content-transfer-encoding:message-id:content-type:to:from:subject:date:x-mailer; b=Nzi/kKny7yiUrgoSNszkSq/1y4sf5jfGrTW8wmeOoJtOp/5UtKEz/NzoudPrWnsQcP+W9/13RMfS9Cs3H3g1nY/dunC0HVdqi1lP4edIjuNMIxSJ3D9hXefRPlmi0vv9p+oxYsN4TNpEKfa/05Ay0HF2uj66ML4vJ5zVF0j04JM= Original-Received: by 10.48.225.4 with SMTP id x4mr71516nfg; Wed, 09 Nov 2005 16:49:20 -0800 (PST) Original-Received: from ?10.0.0.34? ( [82.13.31.46]) by mx.gmail.com with ESMTP id m16sm1366710nfc.2005.11.09.16.49.16; Wed, 09 Nov 2005 16:49:16 -0800 (PST) Original-To: Emacs-Devel ' X-Mailer: Apple Mail (2.746.2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45649 Archived-At: The function `bookmark-jump' failed to work in my environment, where switch-to-buffer is advised. The reason was that bookmark-jump expects switch-to-buffer to return a non-nil value (if succeeded), but switch-to-buffer is not actually documented to do so. Therefore I'd suggest to ignore the return value of switch-to-buffer in bookmark's bookmark-jump function. This fixed the problem for me. *** bookmark.el 19 Oct 2005 09:45:43 -0000 1.84 --- bookmark.el 10 Nov 2005 00:46:21 -0000 *************** *** 1062,1068 **** (bookmark-maybe-historicize-string bookmark) (let ((cell (bookmark-jump-noselect bookmark))) (and cell ! (switch-to-buffer (car cell)) (goto-char (cdr cell)) (progn (run-hooks 'bookmark-after-jump-hook) t) (if bookmark-automatically-show-annotations --- 1062,1068 ---- (bookmark-maybe-historicize-string bookmark) (let ((cell (bookmark-jump-noselect bookmark))) (and cell ! (or (switch-to-buffer (car cell)) t) (goto-char (cdr cell)) (progn (run-hooks 'bookmark-after-jump-hook) t)