all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Reitter <david.reitter@gmail.com>
Subject: bookmarks / switch-to-buffer
Date: Thu, 10 Nov 2005 00:49:15 +0000	[thread overview]
Message-ID: <6FE5EC78-45A4-462C-B927-1480A2B2CE75@gmail.com> (raw)

The function `bookmark-jump' failed to work in my environment, where  
switch-to-buffer is advised.

The reason was that bookmark-jump expects switch-to-buffer to return  
a non-nil value (if succeeded), but switch-to-buffer is not actually  
documented to do so.

Therefore I'd suggest to ignore the return value of switch-to-buffer  
in bookmark's bookmark-jump function. This fixed the problem for me.

*** bookmark.el 19 Oct 2005 09:45:43 -0000      1.84
--- bookmark.el 10 Nov 2005 00:46:21 -0000
***************
*** 1062,1068 ****
     (bookmark-maybe-historicize-string bookmark)
     (let ((cell (bookmark-jump-noselect bookmark)))
       (and cell
!          (switch-to-buffer (car cell))
            (goto-char (cdr cell))
          (progn (run-hooks 'bookmark-after-jump-hook) t)
          (if bookmark-automatically-show-annotations
--- 1062,1068 ----
     (bookmark-maybe-historicize-string bookmark)
     (let ((cell (bookmark-jump-noselect bookmark)))
       (and cell
!          (or (switch-to-buffer (car cell)) t)
            (goto-char (cdr cell))
          (progn (run-hooks 'bookmark-after-jump-hook) t)

             reply	other threads:[~2005-11-10  0:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-10  0:49 David Reitter [this message]
2005-11-10  1:08 ` bookmarks / switch-to-buffer Luc Teirlinck
2005-11-11  6:45   ` Karl Fogel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6FE5EC78-45A4-462C-B927-1480A2B2CE75@gmail.com \
    --to=david.reitter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.