[22.1.90]: Barf in left margin in *stack frames of emacs*

[22.1.90]: Barf in left margin in *stack frames of emacs*

[Marshall, Simon]

In *stack frames of emacs*, I can left-click in the right margin to
horizontally scroll the window.  Gud is good.  However, when I
left-click in the left margin to horizontally scroll back, I get an
error.

emacs -Q
M-x gdb RET RET	; for me, running gdb on emacs
In *gud-emacs*, put a breakpoint somewhere that will get hit and "r -Q"

When the breakpoint hits, select "Options | Enter Debugger on Error" and
"Gud | GDB-Frames | Stack" to popup the *stack frames of emacs* frame.
Left-click in the right margin to horizontally scroll the *stack frames
of emacs* window, then left-click in the left margin to scroll back.  I
get:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-name-nondirectory(nil)
  gud-format-command("break %f:%l" nil)
  gud-call("break %f:%l" nil)
  gud-break(nil)
  gdb-mouse-set-clear-breakpoint((mouse-1 (#<window 27 on *stack frames
of emacs*> left-fringe (2 . 32) 178127836 nil 250 (0 . 2) nil (2 . 6) (8
. 13))))
  call-interactively(gdb-mouse-set-clear-breakpoint)

It shouldn't signal an error, but it appears to be trying to do
something which is not what I would expect it to do.  I would not expect
to be setting breakpoints from the stack frame window in any case.


 "Misys" is the trade name for Misys plc (registered in England and Wales). Registration Number: 01360027. Registered office: Burleigh House, Chapel Oak, Salford Priors, Evesham WR11 8SP. For a list of Misys group operating companies please go to http://www.misys.com/html/about_us/group_operating_companies/. This email and any attachments have been scanned for known viruses using multiple scanners. 
 
We believe that this email and any attachments are virus free, however the recipient must take full responsibility for virus checking. This email message is intended for the named recipient only. It may be privileged and/or confidential. If you are not the named recipient of this email please notify us immediately and do not copy it or use it for any purpose, nor disclose its contents to any other person. This email does not constitute the commencement of legal relations between you and Misys plc. Please refer to the executed contract between you and the relevant member of the Misys group for the identity of the contracting party with which you are dealing. 

Re: [22.1.90]: Barf in left margin in *stack frames of emacs*

[Nick Roberts]

 > In *stack frames of emacs*, I can left-click in the right margin to
 > horizontally scroll the window.  Gud is good.  However, when I
 > left-click in the left margin to horizontally scroll back, I get an
 > error.
 > 
 > emacs -Q
 > M-x gdb RET RET	; for me, running gdb on emacs
 > In *gud-emacs*, put a breakpoint somewhere that will get hit and "r -Q"
 > 
 > When the breakpoint hits, select "Options | Enter Debugger on Error" and
 > "Gud | GDB-Frames | Stack" to popup the *stack frames of emacs* frame.
 > Left-click in the right margin to horizontally scroll the *stack frames
 > of emacs* window, then left-click in the left margin to scroll back.  I
 > get:
 > 
 > Debugger entered--Lisp error: (wrong-type-argument stringp nil)
 >   file-name-nondirectory(nil)
 >   gud-format-command("break %f:%l" nil)
 >   gud-call("break %f:%l" nil)
 >   gud-break(nil)
 >   gdb-mouse-set-clear-breakpoint((mouse-1 (#<window 27 on *stack frames
 > of emacs*> left-fringe (2 . 32) 178127836 nil 250 (0 . 2) nil (2 . 6) (8
 > . 13))))
 >   call-interactively(gdb-mouse-set-clear-breakpoint)

Good catch.  Does the patch below (on EMACS_22_BASE), fix it?

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** gdb-ui.el	19 Feb 2008 21:55:10 +1300	1.206.2.19
--- gdb-ui.el	21 Feb 2008 00:47:52 +1300	
*************** static char *magick[] = {
*** 1972,1986 ****
    (interactive "e")
    (mouse-minibuffer-check event)
    (let ((posn (event-end event)))
!     (if (numberp (posn-point posn))
! 	(with-selected-window (posn-window posn)
! 	  (save-excursion
! 	    (goto-char (posn-point posn))
! 	    (if (or (posn-object posn)
! 		    (eq (car (fringe-bitmaps-at-pos (posn-point posn)))
! 			'breakpoint))
! 		(gud-remove nil)
! 	      (gud-break nil)))))))
  
  (defun gdb-mouse-toggle-breakpoint-margin (event)
    "Enable/disable breakpoint in left margin with mouse click."
--- 1972,1988 ----
    (interactive "e")
    (mouse-minibuffer-check event)
    (let ((posn (event-end event)))
!     (if (buffer-file-name)
! 	(if (numberp (posn-point posn))
! 	    (with-selected-window (posn-window posn)
! 	      (save-excursion
! 		(goto-char (posn-point posn))
! 		(if (or (posn-object posn)
! 			(eq (car (fringe-bitmaps-at-pos (posn-point posn)))
! 			    'breakpoint))
! 		    (gud-remove nil)
! 		  (gud-break nil)))))
!       (posn-set-point posn))))
  
  (defun gdb-mouse-toggle-breakpoint-margin (event)
    "Enable/disable breakpoint in left margin with mouse click."

RE: [22.1.90]: Barf in left margin in *stack frames of emacs*

[Marshall, Simon]

> Good catch.  Does the patch below (on EMACS_22_BASE), fix it?

Yes, thanks, tried with 22.1.91.


 "Misys" is the trade name for Misys plc (registered in England and Wales). Registration Number: 01360027. Registered office: Burleigh House, Chapel Oak, Salford Priors, Evesham WR11 8SP. For a list of Misys group operating companies please go to http://www.misys.com/html/about_us/group_operating_companies/. This email and any attachments have been scanned for known viruses using multiple scanners. 
 
We believe that this email and any attachments are virus free, however the recipient must take full responsibility for virus checking. This email message is intended for the named recipient only. It may be privileged and/or confidential. If you are not the named recipient of this email please notify us immediately and do not copy it or use it for any purpose, nor disclose its contents to any other person. This email does not constitute the commencement of legal relations between you and Misys plc. Please refer to the executed contract between you and the relevant member of the Misys group for the identity of the contracting party with which you are dealing.