From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Would (Eval-when-compile (require 'treesit)) eliminate the need for (declare-function)s? Date: Sun, 16 Apr 2023 20:12:22 -0700 Message-ID: <6E9242F5-EC30-4BA5-A290-0AA6CCB7ECE7@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20531"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 17 05:13:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poFIx-0005Ey-5r for ged-emacs-devel@m.gmane-mx.org; Mon, 17 Apr 2023 05:13:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poFII-0005aw-8C; Sun, 16 Apr 2023 23:12:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poFIF-0005aP-B5 for emacs-devel@gnu.org; Sun, 16 Apr 2023 23:12:39 -0400 Original-Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poFIC-0000fe-KN for emacs-devel@gnu.org; Sun, 16 Apr 2023 23:12:39 -0400 Original-Received: by mail-pl1-x635.google.com with SMTP id n17so8232490pln.8 for ; Sun, 16 Apr 2023 20:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681701154; x=1684293154; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=PHo41MV/C/y6Szk+MStCf217MhgnkxE7QJuzb8TIlgk=; b=ZSRtRdKRx9cUUWkh0xBoMzntEMYgvvFNNA7bUKo384bnT4ekQ9zAUY41T3Z7cYnMTR skRutUMVN1iCj3KVCZ7Y/B3isNnW1obKznjWuNQWtfuqROfrbWR9ubTLzh+uHrtSELC4 DeT/aoATrho0DeyhKpv7Eqm3XisyxZIEveKsG/SBfCnYPlJXwwzGTrsD8r44lcibgurf FUYIapnGcleiB3nUceyNuNc9u283ZQgdmKH9iLXztZIOm/+ZkB7m7TnT1kYOgKJNIOor EMRUeLAaImDVHGJfo2YpO48ww5+Ydx9to9r6pBB6I25Nr8Cios1dremNLKLm9vWePCpY Wiow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681701154; x=1684293154; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PHo41MV/C/y6Szk+MStCf217MhgnkxE7QJuzb8TIlgk=; b=DEUOHPO+Ved6I30JJQEXYGGNsR3EX8CP9b/0M8roLe36RAv2Sym6D5bN7E3rzqxRyL IcuigCQUtTiLyScoFd1CDuQ+FohB0MpC3EeTQDPMSPKh4yj+QRyGhkzsG4raNpnh8R5W dpAyg35dKxOwQ/0GOAW3G3tqXYinZfPaetO604jE/hYG0TRn9lpSanB0JtR1IfMyNNPU ipFoysrBZbuLvkI8K1xt0AzXfDwJIgMrYPOEDSDKucc5s1+4MwF3dxlUgxgzq//2e0n4 M/E9mrgG/npRtPfzGhO8v7l29lp62wBmxSRtVPd6VrIz1K+HbBDHU3vZKmQwYC4Z+vbI 9WMg== X-Gm-Message-State: AAQBX9cW3NuDJnfZUjgCMF8rcVv79ztrizsnU7T5ZDrOLUTGBRTZ3sJL 7L9VHcxTJYIKhSY3pZq767oVUn7KNNbD+Q== X-Google-Smtp-Source: AKy350YENKeHlhkKR5Qo5BJL4BOqLRQa3RmcLOLP3zKpgWMkR7X5j9VSNQs+Ve/1TT3UwaTpkYYIpQ== X-Received: by 2002:a05:6a20:3ca5:b0:ee:4618:2df5 with SMTP id b37-20020a056a203ca500b000ee46182df5mr12270532pzj.4.1681701154157; Sun, 16 Apr 2023 20:12:34 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b33-20020a630c21000000b004fbd91d9716sm5812754pgl.15.2023.04.16.20.12.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Apr 2023 20:12:33 -0700 (PDT) X-Mailer: Apple Mail (2.3731.500.231) Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=casouri@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305356 Archived-At: I=E2=80=99ve made the mistake of forgetting to add (declare-function = treesit-xxx) when using functions from treesit.c far too many times = (sorry!). Since treesit.el contains declare-function=E2=80=99s for every = function in treesit.c, if we use (eval-when-compile (require = =E2=80=99treesit)), would it eliminate the need for adding = declare-function=E2=80=99s? Should we do that? Yuan=