From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Date: Sat, 26 Nov 2022 18:36:45 -0800 Message-ID: <6E82ED98-32C7-4E46-B439-C37841689824@gmail.com> References: <87wn7o6c9c.fsf@yahoo.com> <701BF611-6506-403E-B70B-2D93F3339E0C@acm.org> <83v8n82yzl.fsf@gnu.org> <83fsec2qq3.fsf@gnu.org> <83edtw2pz3.fsf@gnu.org> <835yf82oc4.fsf@gnu.org> <942C72E7-3DA9-4E2B-8B40-137B8FB23473@acm.org> <04236EB0-122B-41D0-B696-CC2EFA4B6A93@gmail.com> <6822E77F-3094-4E73-A7E7-EF5C096FC08F@acm.org> <104387C6-BF9A-4243-AD64-1ADCC25CBBA0@acm.org> <83y1s0up7z.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5635"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Stefan Kangas , 59426@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 03:37:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz7Xe-0001Ht-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 03:37:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz7XU-0005V2-1S; Sat, 26 Nov 2022 21:37:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz7XS-0005S8-Eb for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 21:37:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oz7XS-0006mW-3P for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 21:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oz7XR-00024Y-Ta for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 21:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 02:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59426 X-GNU-PR-Package: emacs Original-Received: via spool by 59426-submit@debbugs.gnu.org id=B59426.16695166177959 (code B ref 59426); Sun, 27 Nov 2022 02:37:01 +0000 Original-Received: (at 59426) by debbugs.gnu.org; 27 Nov 2022 02:36:57 +0000 Original-Received: from localhost ([127.0.0.1]:41773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz7XN-00024J-AL for submit@debbugs.gnu.org; Sat, 26 Nov 2022 21:36:57 -0500 Original-Received: from mail-pj1-f46.google.com ([209.85.216.46]:46821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz7XJ-00024D-Dv for 59426@debbugs.gnu.org; Sat, 26 Nov 2022 21:36:54 -0500 Original-Received: by mail-pj1-f46.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so5831819pjd.5 for <59426@debbugs.gnu.org>; Sat, 26 Nov 2022 18:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GkllL0tpMfSihB5Pbhp03DgS+84px31kdEcMHzZNWSA=; b=el83vYr2q/i6ffHG0sVSDUfj6GThRlVu5vZT5tQ7UhUkInfPLsVWXSI7WfpL1AaHKJ g0jTcUAQRpWgdBqSmvsmq2w6gE0zai3OYINAsNJPAJBUAAQD5XohDlargy2JHdDM2y+c 5wYyZKk5PgGL1sdHmqjt57XwvhASETjqVtV9DKN76zKCpC/vg4IDEd0Eus912wDkymRC RpcLPDnZzKD61yGl9MxJ/Fh+46ewL8Mxecp9pjDv9aUU+MRpJ1aYuUQGqUVPNZPDtd/X QqZlyBjHGW6hVojDQrB9+Bxbjq8nM/XUIWGubnoA1zx+PYMZggi56Km9P5pDiuEU5Bnt dvgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GkllL0tpMfSihB5Pbhp03DgS+84px31kdEcMHzZNWSA=; b=n6GGj0AnjSw0SXMGZQ2v9dgQ/Gm5UdUOr3dWMsF1QL2G0kg0Y9aCAeemgUJMxoCQvV djxUnmQhFszZg+9rJ4qliFDsxB+RpDSRND0QUkYogLJv9eFV/OXqaoHh7h7Olv0+1p2r O5sS8SNw0fGWOXQ6QXhhRHke/2UFarFmIb79K68JqikSa089iOfEC6GI62cRCQjhYvKX GrsEvZRP1r6yREBAOTtavv6KEyW4ns9pb7xXmUfpjKzr1hq0kkTREKZy0x/6kFMtAI7A JGd5SNUHa1qsE9VPnU1C1buEjKdKBfZ4ug1Que2smER6Ef7kJ+UjadOG8KnhJlg/P017 x3lw== X-Gm-Message-State: ANoB5plYzBWuPKZCo/z+o0yyRQf3TkzZv0uAoGfa+7ZRXBJ7wxM5PR2J GhfFqrUYwlyaOqFuNCwsGk4= X-Google-Smtp-Source: AA0mqf62ucvhWHl1dd6y3wFGRQAymM+9m8qOeZXYKVtFq9+FTscpGlsnWfv3cBFx43x5eGDn5DzNzg== X-Received: by 2002:a17:90b:3551:b0:218:f477:da29 with SMTP id lt17-20020a17090b355100b00218f477da29mr18262474pjb.245.1669516607580; Sat, 26 Nov 2022 18:36:47 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id pl18-20020a17090b269200b00218f830c63esm5140198pjb.1.2022.11.26.18.36.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Nov 2022 18:36:47 -0800 (PST) In-Reply-To: <83y1s0up7z.fsf@gnu.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249161 Archived-At: > On Nov 24, 2022, at 11:28 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 24 Nov 2022 11:25:58 -0800 >> Cc: Eli Zaretskii , >> Po Lu , >> Stefan Kangas , >> 59426@debbugs.gnu.org >>=20 >> That brings us back to the original question: what limit should we = use? I suggest we use a smaller number since normal tree should never be = very tall. Running the following code tells me the height of the tree = for xdisp.c is 30: >>=20 >> (defun measure-height (node) >> (let ((children (treesit-node-children node t))) >> (if children >> (1+ (apply #'max (mapcar #'measure-height children))) >> 1))) >> ;; In xdisp.c: >> (measure-height (treesit-buffer-root-node)) >>=20 >> Maybe a limit in the range of hundreds or thousands? 800? >=20 > I suggest 1000. Ok, I added the default limit in cc086f37e89. Yuan=