From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Po Lu" <luangruo@yahoo.com>,
"Mattias Engdegård" <mattiase@acm.org>,
"Stefan Kangas" <stefankangas@gmail.com>,
59426@debbugs.gnu.org
Subject: bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit
Date: Sat, 26 Nov 2022 18:36:45 -0800 [thread overview]
Message-ID: <6E82ED98-32C7-4E46-B439-C37841689824@gmail.com> (raw)
In-Reply-To: <83y1s0up7z.fsf@gnu.org>
> On Nov 24, 2022, at 11:28 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 24 Nov 2022 11:25:58 -0800
>> Cc: Eli Zaretskii <eliz@gnu.org>,
>> Po Lu <luangruo@yahoo.com>,
>> Stefan Kangas <stefankangas@gmail.com>,
>> 59426@debbugs.gnu.org
>>
>> That brings us back to the original question: what limit should we use? I suggest we use a smaller number since normal tree should never be very tall. Running the following code tells me the height of the tree for xdisp.c is 30:
>>
>> (defun measure-height (node)
>> (let ((children (treesit-node-children node t)))
>> (if children
>> (1+ (apply #'max (mapcar #'measure-height children)))
>> 1)))
>> ;; In xdisp.c:
>> (measure-height (treesit-buffer-root-node))
>>
>> Maybe a limit in the range of hundreds or thousands? 800?
>
> I suggest 1000.
Ok, I added the default limit in cc086f37e89.
Yuan
next prev parent reply other threads:[~2022-11-27 2:36 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 0:53 bug#59426: 29.0.50; [tree-sitter] Some functions exceed maximum recursion limit Yuan Fu
2022-11-21 6:40 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-21 7:38 ` Stefan Kangas
2022-11-21 12:00 ` Mattias Engdegård
2022-11-21 13:55 ` Eli Zaretskii
2022-11-21 14:46 ` Mattias Engdegård
2022-11-21 16:43 ` Yuan Fu
2022-11-21 16:54 ` Eli Zaretskii
2022-11-21 17:10 ` Eli Zaretskii
2022-11-21 17:45 ` Eli Zaretskii
2022-11-21 18:20 ` Mattias Engdegård
2022-11-21 18:26 ` Eli Zaretskii
2022-11-21 18:59 ` Mattias Engdegård
2022-11-21 19:00 ` Yuan Fu
2022-11-22 9:08 ` Mattias Engdegård
2022-11-22 23:19 ` Yuan Fu
2022-11-23 10:40 ` Mattias Engdegård
2022-11-23 18:46 ` Yuan Fu
2022-11-23 20:01 ` Mattias Engdegård
2022-11-24 9:17 ` Yuan Fu
2022-11-24 10:24 ` Mattias Engdegård
2022-11-24 19:25 ` Yuan Fu
2022-11-24 19:28 ` Eli Zaretskii
2022-11-27 2:36 ` Yuan Fu [this message]
2022-11-24 10:24 ` Eli Zaretskii
2022-11-21 16:56 ` Mattias Engdegård
2022-11-21 17:01 ` Yuan Fu
2022-11-21 17:44 ` Eli Zaretskii
2022-11-22 1:46 ` Stefan Kangas
2022-11-22 0:27 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-22 8:59 ` Mattias Engdegård
2022-11-21 13:19 ` Eli Zaretskii
2022-11-21 16:52 ` Yuan Fu
2022-11-21 17:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E82ED98-32C7-4E46-B439-C37841689824@gmail.com \
--to=casouri@gmail.com \
--cc=59426@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=mattiase@acm.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.