From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 8ef8463: Accept lexical lambda in auto-insert-alist Date: Mon, 22 Jun 2020 17:34:58 +0200 Message-ID: <6CD3045E-2843-4905-A5B0-E68E0D60C5E2@acm.org> References: <20200622111631.31420.48804@vcs0.savannah.gnu.org> <20200622111633.AB9FA20A26@vcs0.savannah.gnu.org> <875zbjyyw6.fsf@tcd.ie> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="33400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 22 17:38:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jnOWn-0008Wh-Cn for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 17:38:33 +0200 Original-Received: from localhost ([::1]:37694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnOWm-0004Jd-Dt for ged-emacs-devel@m.gmane-mx.org; Mon, 22 Jun 2020 11:38:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnOTa-0006hx-HZ for emacs-devel@gnu.org; Mon, 22 Jun 2020 11:35:14 -0400 Original-Received: from mail238c50.megamailservers.eu ([91.136.10.248]:56276 helo=mail56c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnOTX-0002Od-5E for emacs-devel@gnu.org; Mon, 22 Jun 2020 11:35:14 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1592840101; bh=+iIH4FXoYpSKZys8z3eelrqpBcWXp6DLB0f7IBxGE+Q=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OF0ZNiv3tLH00ZJAPPB4iPiKdIQfqS43zwYIL1sMw0zXDbTHDt8gzvwVsKESkBrTl 4EB1ZfLJibIVxSZwOLnpIK94ArH/GmpWNC/413AvCvvh7bFbDPwqJtjGRdyCmEvuKw SY0BivCvvxc1o4051FfpUi2+D5HK/dIrFHqVe5Js= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-4e4ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.78]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 05MFYwNg019931; Mon, 22 Jun 2020 15:35:00 +0000 In-Reply-To: <875zbjyyw6.fsf@tcd.ie> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F21.5EF0CF20.00A0:SCFSTAT68638221, ss=1, re=-4.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UqsdyN4B c=1 sm=1 tr=0 a=klNLuyVZdLUgl+K5Uafb2A==:117 a=klNLuyVZdLUgl+K5Uafb2A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=N9yNoLYqFifmO-txnOsA:9 a=CjuIK1q_8ugA:10 Received-SPF: softfail client-ip=91.136.10.248; envelope-from=mattiase@acm.org; helo=mail56c50.megamailservers.eu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/22 11:35:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:252512 Archived-At: 22 juni 2020 kl. 16.10 skrev Basil L. Contovounesios : > I wonder why I didn't get any test failures > with 'make bootstrap && make check', though? Did you run the tests as > 'cd test; make autoinsert-tests' instead? Would that make a = difference? I don't remember, but maybe you ran the tests byte-compiled? A compiled = closure won't look like a list, and wouldn't trigger the bug. There may be more instances of the same bug (ie, not recognising lexical = closures correctly). I only had a quick look and didn't find anything = outright wrong, but could very well have missed something.