From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#37483: [PATCH] macOS build error (aligned_alloc) Date: Sun, 22 Sep 2019 19:25:49 +0200 Message-ID: <6CB9FE84-5DF1-458C-B6A9-6C10DDADF601@acm.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_AA071EEA-5635-4B68-A9A6-708FDAC20B6B" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195856"; mail-complaints-to="usenet@blaine.gmane.org" To: 37483@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 22 19:26:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iC5ck-000omI-GH for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Sep 2019 19:26:14 +0200 Original-Received: from localhost ([::1]:48004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iC5cj-0002hX-CR for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Sep 2019 13:26:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59897) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iC5cZ-0002hO-Hj for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:26:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iC5cY-0004mN-IT for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iC5cY-0004lV-EH for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iC5cY-0006kj-Ab for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Sep 2019 17:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 37483 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.156917316025947 (code B ref -1); Sun, 22 Sep 2019 17:26:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Sep 2019 17:26:00 +0000 Original-Received: from localhost ([127.0.0.1]:34464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iC5cV-0006kR-Ti for submit@debbugs.gnu.org; Sun, 22 Sep 2019 13:26:00 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:54262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iC5cU-0006kJ-7m for submit@debbugs.gnu.org; Sun, 22 Sep 2019 13:25:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59866) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iC5cT-0002er-49 for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:25:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iC5cR-0004IR-Rw for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:25:56 -0400 Original-Received: from mail177c50.megamailservers.eu ([91.136.10.187]:41318 helo=mail51c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iC5cR-00045a-9L for bug-gnu-emacs@gnu.org; Sun, 22 Sep 2019 13:25:55 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1569173151; bh=xXzyaPb7UER1HnvklAgOAjwavSIZmktcxxAXDATagFE=; h=From:Subject:Date:To:From; b=auIj2lTAThhVVfTpgguktsr0Fsufaa7unghtAejYFh5ePa3SzbTRRKLEQszvbT4rN wc1hztVhq5XGb89fcEMCh2FC8TnSOxiPp89boHwap15yOwBBT7Kpi3aNXUYYarTJhu LJ8O3++ab0pBsQZk1ZW92eTb7AwUsESh9/AFNp1Q= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] ([188.150.171.71]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x8MHPo2V002033 for ; Sun, 22 Sep 2019 17:25:51 +0000 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0207.5D87AE9F.0035, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=GNR27dFK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=IVnU1KnFDFHgcnO52VYA:9 a=CjuIK1q_8ugA:10 a=4lcGVWqOKnyg1ljerY4A:9 a=B2y7HmGcmWMA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166929 Archived-At: --Apple-Mail=_AA071EEA-5635-4B68-A9A6-708FDAC20B6B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii After upgrading the macOS system dev tools, building Emacs fails because = aligned_alloc is present in the system headers and can be linked with = but isn't actually in the dynamic library (macOS 10.14, Xcode 11). This means that the configure check for that function needs to be = strengthened a bit. Proposed patch attached; please say if it breaks on = a different platform. I'm not the greatest fan of autoconf, and am = likely to have made mistakes. --Apple-Mail=_AA071EEA-5635-4B68-A9A6-708FDAC20B6B Content-Disposition: attachment; filename=0001-More-thorough-check-for-aligned_alloc-on-macOS.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-More-thorough-check-for-aligned_alloc-on-macOS.patch" Content-Transfer-Encoding: quoted-printable =46rom=20491b19f50014cf03a7cc9085568a10bbefed1812=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2022=20Sep=202019=2019:01:52=20+0200=0A= Subject:=20[PATCH]=20More=20thorough=20check=20for=20aligned_alloc=20on=20= macOS=0AMIME-Version:=201.0=0AContent-Type:=20text/plain;=20= charset=3DUTF-8=0AContent-Transfer-Encoding:=208bit=0A=0A*=20= configure.ac=20(HAVE_ALIGNED_ALLOC):=20Use=20a=20executing=20check=20for=0A= aligned_alloc=20on=20macOS,=20since=20while=20that=20function=20is=20= only=20available=20in=0Aversion=20=E2=89=A510.15,=20it=20may=20be=20= present=20in=20the=20system=20headers=20and=20could=20be=0Alinked=20with=20= in=20earlier=20versions.=0A---=0A=20configure.ac=20|=2021=20= ++++++++++++++++++++-=0A=201=20file=20changed,=2020=20insertions(+),=201=20= deletion(-)=0A=0Adiff=20--git=20a/configure.ac=20b/configure.ac=0Aindex=20= e822b0b7b0..dfc7bdb883=20100644=0A---=20a/configure.ac=0A+++=20= b/configure.ac=0A@@=20-4179,8=20+4179,27=20@@=20AC_DEFUN=0A=20cfmakeraw=20= cfsetspeed=20__executable_start=20log2=20prctl)=0A=20LIBS=3D$OLD_LIBS=0A=20= =0A+if=20test=20"${opsys}"=20=3D=20darwin;=20then=0A+=20=20dnl=20= aligned_alloc=20is=20available=20in=20macOS=2010.15=20and=20later,=20but=20= may=20be=0A+=20=20dnl=20visible=20(but=20not=20functional)=20before=20= that,=20and=20there=20is=20no=0A+=20=20dnl=20telling=20without=20= actually=20running=20a=20test.=0A+=20=20AC_CACHE_CHECK([for=20= aligned_alloc],=20[ac_cv_func_aligned_alloc],=0A+=20=20=20=20= [AC_RUN_IFELSE([AC_LANG_PROGRAM([[#include=20]],=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20[[return=20!aligned_alloc=20(1,=201);]])],=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= [ac_cv_func_aligned_alloc=3Dyes],=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20[ac_cv_func_aligned_alloc=3Dno],=20[])])=0A+=20=20= if=20test=20$ac_cv_func_aligned_alloc=20=3D=20yes;=20then=0A+=20=20=20=20= AC_DEFINE([HAVE_ALIGNED_ALLOC],=201,=0A+=20=20=20=20=20=20=20=20=20=20=20= =20=20=20[Define=20to=201=20if=20you=20have=20the=20'aligned_alloc'=20= function.])=0A+=20=20fi=0A+else=0A+=20=20AC_CHECK_FUNCS([aligned_alloc])=0A= +fi=0A+=0A=20dnl=20No=20need=20to=20check=20for=20posix_memalign=20if=20= aligned_alloc=20works.=0A-AC_CHECK_FUNCS([aligned_alloc=20= posix_memalign],=20[break])=0A+if=20test=20"$ac_cv_func_aligned_alloc"=20= !=3D=20yes;=20then=0A+=20=20AC_CHECK_FUNCS([posix_memalign])=0A+fi=0A=20= AC_CHECK_DECLS([aligned_alloc],=20[],=20[],=20[[#include=20]])=0A= =20=0A=20#=20Dump=20loading=0A--=20=0A2.21.0=20(Apple=20Git-122)=0A=0A= --Apple-Mail=_AA071EEA-5635-4B68-A9A6-708FDAC20B6B--