From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59251: Acknowledgement (29.0.50; Fix-some-inconsistencies-in-ts-modes) Date: Sun, 13 Nov 2022 16:51:52 -0800 Message-ID: <6C5721BF-2FA2-45A4-A970-483D662A6414@gmail.com> References: <87k03ya8no.fsf@thornhill.no> <87cz9qa4ab.fsf@thornhill.no> <87a64u31d0.fsf@thornhill.no> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59251@debbugs.gnu.org To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 14 01:53:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouNit-0007lS-Rk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Nov 2022 01:53:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouNii-0001wT-Lj; Sun, 13 Nov 2022 19:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouNih-0001tt-5e for bug-gnu-emacs@gnu.org; Sun, 13 Nov 2022 19:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouNig-0007xe-Rs for bug-gnu-emacs@gnu.org; Sun, 13 Nov 2022 19:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouNig-0007mx-C3 for bug-gnu-emacs@gnu.org; Sun, 13 Nov 2022 19:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Nov 2022 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59251 X-GNU-PR-Package: emacs Original-Received: via spool by 59251-submit@debbugs.gnu.org id=B59251.166838712829875 (code B ref 59251); Mon, 14 Nov 2022 00:53:02 +0000 Original-Received: (at 59251) by debbugs.gnu.org; 14 Nov 2022 00:52:08 +0000 Original-Received: from localhost ([127.0.0.1]:48687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouNhn-0007ln-UD for submit@debbugs.gnu.org; Sun, 13 Nov 2022 19:52:08 -0500 Original-Received: from mail-pf1-f182.google.com ([209.85.210.182]:46802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouNhi-0007lF-AZ for 59251@debbugs.gnu.org; Sun, 13 Nov 2022 19:52:06 -0500 Original-Received: by mail-pf1-f182.google.com with SMTP id b29so9615285pfp.13 for <59251@debbugs.gnu.org>; Sun, 13 Nov 2022 16:52:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UELP9NcPLWRekmhgLojwpHZNQIZOBcTT7xT2bQ8C8RM=; b=ZcbzmgGOdRfjIpRmRpflPlGCN1braWlY5ODG7YKtEVEY3R0RlXB0NEQrHrqNYfsWw8 VK/u9v4n/49XCRAYSOHpJqtIDRVgKeynzSiYEoJkmlhVKPMUwxFvXDeGD8JKE74GHjDs YJKovcXRpigv57tex9DN3wiah9k79grQjxzAeC8ScoZmxNwE020O8+QBg6QBGUK/Y7AR 9fNW51zq6sc1jdAybaY48isx+dCUVthI/Tl71SriNSt/AfO6jdLxlMA0UGC7ckG61VaZ NmUTi5VBNI4COfEvNFUNxElFr+ojtm5tdJsrSo81Il9oeRXUrG7kW9WvtwHj8bekOq4e IIDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UELP9NcPLWRekmhgLojwpHZNQIZOBcTT7xT2bQ8C8RM=; b=hj/6XdNwecNOeX/ziholCnewaw6Yq9PK0B31A0SY2jdiibs79ndqBGn1AptOZSy4Yj Cy00lShlr/8k7u947WFGEmzriuBKE+fzE1N+a/B3p+31dOpbZ3vXq1QpMS13Tjc1EM3R yH2Txu7Qtz+Y8pY05P6HeEQe20oR/b+62+WQeF9sWcJRzW8f9XLNfmmyPZTRm8m0ZmqO HB99+zHEC4wUyn0qz864f7QiNVZSyp9+MxpB4qHgotIc5SUUujbVtsAB4ii0tSPnlydN s3E3IsN2UvxgOJgRWJWCQWMiD7nmuHfzbj0f1Orlgt/gLxY02zrljKRKfbfRyGuQqCO6 RthQ== X-Gm-Message-State: ANoB5plLAkvu5dbKEd0oAzcW3eoHtEGr/WcWMIs87JE/ZvXHoGEOJHL6 I3M9OzqLFzz5NiPLxcx/6X0= X-Google-Smtp-Source: AA0mqf7bLzoek9glDZMnMTAqpycGrJYioXR0/n4l5IQIHIISVyMOjviZhDHLkl/vetjTdzpQqDjU4w== X-Received: by 2002:a63:5650:0:b0:458:5e:5388 with SMTP id g16-20020a635650000000b00458005e5388mr9702480pgm.168.1668387113689; Sun, 13 Nov 2022 16:51:53 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id w2-20020a63d742000000b0046fb6e0e691sm4789875pgi.6.2022.11.13.16.51.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Nov 2022 16:51:53 -0800 (PST) In-Reply-To: <87a64u31d0.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247827 Archived-At: > On Nov 13, 2022, at 3:01 PM, Theodor Thornhill via Bug reports for GNU = Emacs, the Swiss army knife of text editors = wrote: >=20 > Theodor Thornhill writes: >=20 >> Added a few more finishes. >=20 > Aaand another. Last one for now. I promise=E2=80=A6 Cool! Some comments: +(defcustom c-ts-mode-font-lock-feature-list + '((comment preprocessor operator constant string literal keyword) + (type definition expression statement) + ()) + "Language constructs to font-lock. + +See `treesit-font-lock-feature-list' for description of how to +use this variable. Supported features are as defined in +`c-ts-mode--font-lock-settings'." + :version "29.1" + :type 'list + :safe 'listp + :group 'c) + I think Stefan M=E2=80=99s opinion is to make feature-list private, and = let users add/remove features. Right now they can add/remove features = with treesit-recompute-feature-list. I guess we can keep them as = defvar=E2=80=99s for now, so people as the option to redefine this list = should they want to. (One argument against having them as custom options = is that, if a user sets it as a custom option, they will miss out on = future changes to this variable.) + (setq-local comment-style c-ts-mode-comment-style) Why don=E2=80=99t we let users set comment style themselves? Does = cc-mode have a similar variable? Yuan