From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.devel Subject: Re: ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Date: Tue, 26 Oct 2010 08:07:58 +0300 Message-ID: <6B12217D-6FF2-42FE-A53C-AAA32C7AC510@gmail.com> References: <19651.37838.815906.240014@fencepost.gnu.org> <7seibdzmke.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1288069700 16204 80.91.229.12 (26 Oct 2010 05:08:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Oct 2010 05:08:20 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 26 07:08:18 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PAblg-0005YT-QR for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2010 07:08:17 +0200 Original-Received: from localhost ([127.0.0.1]:46919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAblg-0000Ay-8B for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2010 01:08:16 -0400 Original-Received: from [140.186.70.92] (port=53193 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAblZ-0000Ag-1B for emacs-devel@gnu.org; Tue, 26 Oct 2010 01:08:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAblX-0003d2-QM for emacs-devel@gnu.org; Tue, 26 Oct 2010 01:08:08 -0400 Original-Received: from mail-ey0-f169.google.com ([209.85.215.169]:38091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAblU-0003bn-Gu; Tue, 26 Oct 2010 01:08:04 -0400 Original-Received: by eydd26 with SMTP id d26so1963952eyd.0 for ; Mon, 25 Oct 2010 22:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=3K8mGG+hX5tOamr9Vp2y7Rei0cJJXl5AB2PbzYkM0fA=; b=prENe9j+/21y8OQD2qu2aD2Pd6XTJ4rJRnDJtUgEOUI2AD4fCmINWSDnnFtnSG4k9a dTa0S6+afcQBMSvJTOsNu23RbwIdJKDk2WzxcTQijipB6Zach7Z1tb+X46v0ZDSKnN1i NhwowtOztxFu8ynsHjMxUzQdXYdrUYTuVfNPU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=lWDY7UoWMs5Akj+5anmGvJ0QrwLTuvdTRLIs1H8xFHTFHyNjWOn4TFmGVrt1FoNXXF ndJGVC1VnRdhHoAOE71ZAh5QDzVIsLNZtmMa3u3u3RAKZRF4Tusvfqx9yVWZJNtXF6Si x/OqDXNHgaCtXjSZyk2KYLg52Yco57Il7YDrs= Original-Received: by 10.213.31.73 with SMTP id x9mr1154733ebc.36.1288069682788; Mon, 25 Oct 2010 22:08:02 -0700 (PDT) Original-Received: from [10.0.1.2] (dsl-hkibrasgw2-fe25de00-221.dhcp.inet.fi [80.222.37.221]) by mx.google.com with ESMTPS id w20sm8321844eeh.6.2010.10.25.22.07.59 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 25 Oct 2010 22:08:01 -0700 (PDT) In-Reply-To: <7seibdzmke.fsf@fencepost.gnu.org> X-Mailer: Apple Mail (2.1081) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132120 Archived-At: On 2010/10/26, at 5:59, Glenn Morris wrote: >=20 >>> I haven't looked at the ns-win code in a while so I'm a little = hesitant to >>> attempt the cleanup now, but if someone wants to try I'm happy to = answer >>> questions about "why the heck is this thing in there?" etc. and test = the >>> resulting changes. >=20 > I made ns load common-win. Thanks for tackling this. > The [x,ns]-handle-* stuff is still to be addressed. The 'nxopen' functions you removed fro ns-win are referenced from = startup.el. The -NSOpen argument is neither needed nor current any = longer under OS X, but I think it might still be used under GNUstep. > 1. Are the 'ns specific menu adjustments that are now in menu-bar.el > really necessary? They seem so trivial as to be pointless. >=20 > An extra "spell" menu "for platform consistency", renaming the "Paste > from Kill Menu" item, etc. They are minor, but make a significant difference in making the menus = seem less alien on the platform. On the other hand anything less minor = would deviate too much from the common emacs UI and confuse users coming = from other platforms. They are a compromise, but a reasonable one. On the other hand, they were moved from menu-bar.el TO ns-win.el during = the merge. It was desired to keep these platform-specific things in the = platform-specific file rather than cluttering up common files, and I've = come to agree myself this is the best way. > 2. Why all the wacky stuff in x-setup-function-keys? Why does the ns > port need to define the f1 key etc in system-key-alist, when no other > port does. If you're talking about the systen-key-alist stuff, as I understand it = that was there to define keys that existed on X platforms but not NeXT = keyboards. As such, some of it is obsolete. Macs and GNUstep boxes = have function keys now, so those can be removed. Also the special ns- = mappings that are no longer used can be removed. This evening I will = try removing as much as possible, and check the result in to trunk if it = tests OK. > 3. Why doesn't it define iso-lefttab in x-alternatives-map? I don't have any opinion on this, but there was a recent related bug = thread: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6616 . I don't = know enough to say if this is just something appropriate under X11 or if = NS should use iso-lefttab as well. > 4. Is the before-make-frame-hook in ns-win really necessary? > Surely this is a window manager's job? The result without doing that is making a new frame over the top one, = because the left/top parameters default to those from the frame-alist. = This behavior is confusing to the user, so we put in this offset. > 5. Does the ns port really need a special ns-print-buffer command? It's a good idea to confirm a non-undoable action like printing = beforehand. I'd rather recommend to add a print-buffer-with-confirm to = common code, or change the existing one to confirm. > 6. ns-ignore-2-arg seems unused? You are right, it can be removed. > 7. Can the 'mac- aliases be declared obsolete? I'd prefer to do so, but they are there for compatibility with the = earlier Carbon port, and presumably Yamamoto Mitsuharu's current ports = which are used by some people. The Aquamacs community also uses these = heavily. > 8. If running under GNUstep, rename "Help" to "Info". Is that really = needed? > More generally, can the remaining menu-bar fiddling be done more > elegantly in menu-bar.el? See above under (1). thanks, Adrian