From: Adrian Robert <adrian.b.robert@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: Dan Nicolaescu <dann@gnu.org>, emacs-devel@gnu.org
Subject: Re: ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.]
Date: Tue, 26 Oct 2010 08:07:58 +0300 [thread overview]
Message-ID: <6B12217D-6FF2-42FE-A53C-AAA32C7AC510@gmail.com> (raw)
In-Reply-To: <7seibdzmke.fsf@fencepost.gnu.org>
On 2010/10/26, at 5:59, Glenn Morris wrote:
>
>>> I haven't looked at the ns-win code in a while so I'm a little hesitant to
>>> attempt the cleanup now, but if someone wants to try I'm happy to answer
>>> questions about "why the heck is this thing in there?" etc. and test the
>>> resulting changes.
>
> I made ns load common-win.
Thanks for tackling this.
> The [x,ns]-handle-* stuff is still to be addressed.
The 'nxopen' functions you removed fro ns-win are referenced from startup.el. The -NSOpen argument is neither needed nor current any longer under OS X, but I think it might still be used under GNUstep.
> 1. Are the 'ns specific menu adjustments that are now in menu-bar.el
> really necessary? They seem so trivial as to be pointless.
>
> An extra "spell" menu "for platform consistency", renaming the "Paste
> from Kill Menu" item, etc.
They are minor, but make a significant difference in making the menus seem less alien on the platform. On the other hand anything less minor would deviate too much from the common emacs UI and confuse users coming from other platforms. They are a compromise, but a reasonable one.
On the other hand, they were moved from menu-bar.el TO ns-win.el during the merge. It was desired to keep these platform-specific things in the platform-specific file rather than cluttering up common files, and I've come to agree myself this is the best way.
> 2. Why all the wacky stuff in x-setup-function-keys? Why does the ns
> port need to define the f1 key etc in system-key-alist, when no other
> port does.
If you're talking about the systen-key-alist stuff, as I understand it that was there to define keys that existed on X platforms but not NeXT keyboards. As such, some of it is obsolete. Macs and GNUstep boxes have function keys now, so those can be removed. Also the special ns- mappings that are no longer used can be removed. This evening I will try removing as much as possible, and check the result in to trunk if it tests OK.
> 3. Why doesn't it define iso-lefttab in x-alternatives-map?
I don't have any opinion on this, but there was a recent related bug thread: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6616 . I don't know enough to say if this is just something appropriate under X11 or if NS should use iso-lefttab as well.
> 4. Is the before-make-frame-hook in ns-win really necessary?
> Surely this is a window manager's job?
The result without doing that is making a new frame over the top one, because the left/top parameters default to those from the frame-alist. This behavior is confusing to the user, so we put in this offset.
> 5. Does the ns port really need a special ns-print-buffer command?
It's a good idea to confirm a non-undoable action like printing beforehand. I'd rather recommend to add a print-buffer-with-confirm to common code, or change the existing one to confirm.
> 6. ns-ignore-2-arg seems unused?
You are right, it can be removed.
> 7. Can the 'mac- aliases be declared obsolete?
I'd prefer to do so, but they are there for compatibility with the earlier Carbon port, and presumably Yamamoto Mitsuharu's current ports which are used by some people. The Aquamacs community also uses these heavily.
> 8. If running under GNUstep, rename "Help" to "Info". Is that really needed?
> More generally, can the remaining menu-bar fiddling be done more
> elegantly in menu-bar.el?
See above under (1).
thanks,
Adrian
next prev parent reply other threads:[~2010-10-26 5:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1P9lT2-0005WD-37@internal.in.savannah.gnu.org>
[not found] ` <jwvmxq4pez1.fsf-monnier+emacs@gnu.org>
2010-10-24 2:02 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Glenn Morris
2010-10-24 5:08 ` Dan Nicolaescu
2010-10-24 19:45 ` Glenn Morris
2010-10-25 13:25 ` Adrian Robert
2010-10-25 14:51 ` Dan Nicolaescu
2010-10-26 2:59 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-26 4:25 ` ns-win.el Glenn Morris
2010-10-26 4:54 ` ns-win.el CHENG Gao
2010-10-26 5:10 ` ns-win.el Adrian Robert
2010-10-26 15:18 ` ns-win.el Stefan Monnier
2010-10-26 5:07 ` Adrian Robert [this message]
2010-10-26 6:45 ` ns-win.el Glenn Morris
2010-10-26 7:47 ` ns-win.el Eli Zaretskii
2010-10-26 10:49 ` ns-win.el Adrian Robert
2010-10-26 15:27 ` ns-win.el Stefan Monnier
2010-10-26 19:25 ` ns-win.el Glenn Morris
2010-10-26 19:57 ` ns-win.el Adrian Robert
2010-10-26 6:50 ` ns-win.el Glenn Morris
2010-10-26 7:49 ` ns-win.el Eli Zaretskii
2010-10-26 13:08 ` ns-win.el Ted Zlatanov
2010-10-26 14:42 ` ns-win.el Eli Zaretskii
2010-10-26 17:35 ` ns-win.el Ted Zlatanov
2010-10-26 7:32 ` ns-win.el Daniel Pittman
2010-10-24 7:55 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Eli Zaretskii
2010-10-24 19:47 ` Glenn Morris
2010-10-25 0:54 ` Stefan Monnier
2010-10-25 4:56 ` Glenn Morris
2010-10-25 8:03 ` Stephen J. Turnbull
2010-10-25 9:28 ` Eli Zaretskii
2010-10-25 8:20 ` Eli Zaretskii
2010-10-28 3:54 ` moving x-select* [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-28 4:06 ` Eli Zaretskii
2010-10-28 5:32 ` Jason Rumney
2010-10-28 6:40 ` Chad Brown
2010-10-28 13:54 ` moving x-select* Jason Rumney
2010-10-28 15:28 ` Chad Brown
2010-10-28 14:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6B12217D-6FF2-42FE-A53C-AAA32C7AC510@gmail.com \
--to=adrian.b.robert@gmail.com \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.