From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#10624: Dired-marking all files in the region Date: Thu, 22 Nov 2012 07:27:29 -0800 Message-ID: <6AEA16518F864D14983BCA3F42788FF0@us.oracle.com> References: <0F10A2A4C6E541469381BA91CB8AEEB3@us.oracle.com><60BBA8177B8C4157BBB5426B2F6A8204@us.oracle.com><87392k2ml9.fsf@mail.jurta.org><4200B2318C4140E68FA74B61375885B9@us.oracle.com><87sjaj2atc.fsf@mail.jurta.org><96319E709DC548DBADB263DA2DD11A82@us.oracle.com><87fw6his5w.fsf_-_@mail.jurta.org> <87ehjmrmzg.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1353598074 31230 80.91.229.3 (22 Nov 2012 15:27:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 22 Nov 2012 15:27:54 +0000 (UTC) To: "'Juri Linkov'" , <10624@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 22 16:28:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TbYh6-0005cH-JO for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2012 16:28:00 +0100 Original-Received: from localhost ([::1]:45678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbYgv-0004tS-Vz for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Nov 2012 10:27:49 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbYgt-0004sh-24 for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:27:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbYgn-0002Gx-B5 for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:27:46 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbYgn-0002Gt-7C for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:27:41 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TbYi5-000451-R8 for bug-gnu-emacs@gnu.org; Thu, 22 Nov 2012 10:29:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Nov 2012 15:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10624-submit@debbugs.gnu.org id=B10624.135359814115680 (code B ref 10624); Thu, 22 Nov 2012 15:29:01 +0000 Original-Received: (at 10624) by debbugs.gnu.org; 22 Nov 2012 15:29:01 +0000 Original-Received: from localhost ([127.0.0.1]:33295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYi4-00044n-GB for submit@debbugs.gnu.org; Thu, 22 Nov 2012 10:29:01 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:16931) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TbYi0-00044c-GM for 10624@debbugs.gnu.org; Thu, 22 Nov 2012 10:28:59 -0500 Original-Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qAMFRXo1017971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Nov 2012 15:27:34 GMT Original-Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qAMFRW6X007541 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Nov 2012 15:27:33 GMT Original-Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qAMFRW7s000919; Thu, 22 Nov 2012 09:27:32 -0600 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 22 Nov 2012 07:27:32 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehjmrmzg.fsf@mail.jurta.org> Thread-Index: Ac3IlwTQ4p5eXX3oSoWLqUNXr/V29gALd63g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:67313 Archived-At: > I noticed one potential problem > with marking all files in the region in the Dired buffer: > when the region is active before typing `C-c C-c' in WDired > it marks renamed files with the same marker, because currently > WDired uses `dired-add-entry' that calls `dired-mark'. > > This is a rare problem, but I'd like to fix it properly. > IIUC, the right way to enable functionality only for interactive use > is to add an `interactive' arg Just a quick reply - please excuse if my quick reading of this makes my reply off-the-mark (so to speak). What if some other function (perhaps a command) that someone has written takes advantage of the intended active-region behavior (by activating the region, and then...)? With your change, IIUC, that code would now need to be changed to add an additional argument to the call, to fake interactiveness. I don't see the problem you cite as having to do with interactiveness, but as having to do with WDired (or perhaps interactiveness when in WDired). (But again, I might be misunderstanding.) If the problem you refer to is really that _in WDired_ the active region should be handled this way only if interactive, then shouldn't you add an additional condition that tests for WDired mode? IOW, why change the behavior for Dired generally (i.e., including outside WDired mode), for a problem that you found only inside WDired? Again, excuse me if I've misunderstood the intention, behavior, or patch. I looked at your message quickly. Thx.