From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 67249@debbugs.gnu.org
Subject: bug#67249: 30.0.50; `same-frame` equivalent for `display-buffer-alist`
Date: Mon, 20 Nov 2023 10:15:55 +0100 [thread overview]
Message-ID: <69e6899b-9e93-9a97-a8bc-4ce9a9f0ae4c@gmx.at> (raw)
In-Reply-To: <jwvv89xesho.fsf-monnier+emacs@gnu.org>
> Right, so it should probably have been called something like "no new
> frame".
We should prominently mention that in the manual then. BTW creating a
new frame is always one last resort of 'display-buffer'.
> I don't see a big problem here: we could choose `same-frame` to imply
> that `reusable-frames` is nil, or we could choose to ignore
> `same-frame`. Since the code that adds `(same-frame . t)` could just as well
> also add `(reusable-frames)`, the first choice is less flexible
> than the second (tho it allows overriding a higher-precedence
> `reusable-frames` setting), so I'd go with the first choice, which also
> has the advantage of not requiring any code modification :-)
So a (same-frame . t) entry would simply auto-translate to a pair of
(reusable-frames . nil) (lru-frames . nil) entries?
> I don't necessarily want a particular behavior. I want to provide
> a similar functionality, within the constraints of what we can define
> and implement sanely.
>
> So no, I don't necessarily want it to prevail over those other entries.
With the conclusion above it would prevail.
>> mean that it should only inhibit popping up a new frame via
>> 'display-buffer-pop-up-frame'.
>
> That was my conclusion when I looked at the code (concretized in
> my PoC patch).
OK.
> Another approach is to provide a new action.
> This could be a `display-buffer-same-frame` action which tries its best
> to use the selected frame.
> I suspect in many cases the actual intention of `same-frame` was to keep
> the buffer nearby, so I suspect we could also replace `same-frame` with
> a `display-buffer-nearby` action.
>
> The advantage of an action is that we don't need to decide how existing
> actions interact with it.
We could add a 'display-buffer--same-frame-action' variable.
>> Again applications that want to pop up a new frame would then have to
>> provide a (same-frame . nil) entry.
>
> That would seem fair game, IMO.
It means a change in existing code. Till now, applications were on the
safe side in this regard since they could always blame others for using
an obsolete feature.
> I suspect the main exception would be minibuffer-only frames, but we
> could get fancier if we feel like it (like when the selected frame can't
> accommodate the `window-min-width` and `window-min-height`, or when we
> set `inhibit-same-window` (or the selected window is dedicated) and the
> frame's sole window can't be split).
Do you anywhere see 'display-buffer' choose a minibuffer-only frame?
I'm aware of the fact that the
(window--frame-usable-p (last-nonminibuffer-frame))
is broken when a minibuffer-only frame is the only frame left but so far
nobody complained ...
martin
next prev parent reply other threads:[~2023-11-20 9:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 21:41 bug#67249: 30.0.50; `same-frame` equivalent for `display-buffer-alist` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-18 8:36 ` martin rudalics
2023-11-19 3:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-19 10:35 ` martin rudalics
2023-11-19 14:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-20 9:15 ` martin rudalics [this message]
2023-11-20 13:33 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-21 17:14 ` martin rudalics
2023-11-21 19:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-22 8:02 ` martin rudalics
2023-11-22 16:03 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-23 9:59 ` martin rudalics
2023-11-24 2:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-24 9:05 ` martin rudalics
2023-11-24 13:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-24 16:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 9:00 ` martin rudalics
2023-11-25 14:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 19:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-04 7:23 ` martin rudalics
2023-12-09 22:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 22:40 ` Drew Adams
2023-12-09 22:52 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 23:17 ` Drew Adams
2023-12-10 6:00 ` Eli Zaretskii
2023-12-10 16:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-10 21:46 ` Drew Adams
2023-12-10 5:53 ` Eli Zaretskii
2023-12-10 17:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 17:13 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 22:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 18:16 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-25 9:00 ` martin rudalics
2023-11-25 14:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e6899b-9e93-9a97-a8bc-4ce9a9f0ae4c@gmx.at \
--to=rudalics@gmx.at \
--cc=67249@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.