all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Rasmusson <lars.rasmusson@gmail.com>
To: 1491@emacsbugs.donarmstrong.com
Subject: bug#1491: Info received (Same problem in 23.0.60)
Date: Sat, 6 Dec 2008 08:00:59 +0100	[thread overview]
Message-ID: <69E941AA-590F-43C4-ABEA-02B58022C311@gmail.com> (raw)
In-Reply-To: <handler.1491.B1491.12284348208436.ackinfo@emacsbugs.donarmstrong.com>

Isn't this a bug?
On line ebrowse.c:2037
           for (--p; p >= inbuffer && *p != '\n'; --p)
		;
I think it  should be
           for (--p; p > inbuffer && *p != '\n'; --p)
		;

otherwise p may point to one character before inbuffer.
The backwards scanning is done correctly nine lines
further up, on ebrowse.c:2028

(OS X really has some neat features to prevent accessing
data from screwed up pointers! :-) )

/Lars


Btw, is it really ok to write as in ebrowse.c:1530  ?

   /* Skip over white space.  The `#' has been consumed already.  */
   while (WHITEP (GET (c)))
     ;

GET(c) will eat up one character of the input, no matter whether it is a
white space or not...






      parent reply	other threads:[~2008-12-06  7:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 23:53 bug#1491: Same problem in 23.0.60 Lars Rasmusson
2008-12-05  3:48 ` richardeng
     [not found] ` <handler.1491.B1491.12284348208436.ackinfo@emacsbugs.donarmstrong.com>
2008-12-06  7:00   ` Lars Rasmusson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69E941AA-590F-43C4-ABEA-02B58022C311@gmail.com \
    --to=lars.rasmusson@gmail.com \
    --cc=1491@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.