From: Carsten Dominik <carsten.dominik@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: emacs-orgmode@gnu.org, Jambunathan K <kjambunathan@gmail.com>
Subject: Re: [PATCH 2/2] Fix broken CUSTOM_ID links
Date: Wed, 17 Nov 2010 14:26:08 +0100 [thread overview]
Message-ID: <69E5CC30-46A0-47E2-A8F7-0B36BB8B29F4@gmail.com> (raw)
In-Reply-To: <96CFDFB5-67D7-4FF4-901D-00353239DDFC@gmail.com>
Hi Jambunathan,
did you already react on this message? I cannot seem to find your
reply.
Thanks!
- Carsten
On Nov 12, 2010, at 4:50 PM, Carsten Dominik wrote:
> Hi Jambunata,
>
> this looks good, However, I would like you to make a change to the
> patch more more clarity.
>
> Could you please write
>
> (or preferred target)
>
> instead of
>
> remove
>
> as the ID to be inserted? Even though these are the same, the first
> version is a lot clearer.
>
> With this change, I will accept the patch.
>
> Thanks!
>
> - Carsten
>
> On Nov 8, 2010, at 7:39 AM, Jambunathan K wrote:
>
>>
>> Carsten
>>
>>> On Nov 5, 2010, at 6:53 PM, Jambunathan K wrote:
>>>
>>>>
>>>> Note the 'H:1' in options line. Export this to HTML. Note that
>>>> CUSTOMID
>>>> link is broken. A snippet of relevant HTML section is attached
>>>> below.
>>>>
>>>> Change 'H:1' to 'H:3' note that there is no more brokenness.
>>>>
>>>> Possible root cause: When headlines are turned to list 'extra-
>>>> targets'
>>>> are not identified correctly.
>>>
>>> That is correct - Org does not assign IDs or names to list items,
>>> so it has no place to link to. This could probably be fixed -
>>> anyone
>>> would
>>> like to fix this?
>>>
>>
>> I am attaching a patch. Hope it does the right thing.
>>
>> <tmp.org>--- before.html 2010-11-08 19:01:13.796875000 +0530
>> +++ after.html 2010-11-08 19:00:57.859375000 +0530
>> @@ -7,7 +7,7 @@
>> <title>tmp</title>
>> <meta http-equiv="Content-Type" content="text/
>> html;charset=iso-8859-1"/>
>> <meta name="generator" content="Org-mode"/>
>> - <meta name="generated" content="2010-11-08 18:57:46 "/>
>> + <meta name="generated" content="2010-11-08 18:56:05 "/>
>> <meta name="author" content="Jambunathan K"/>
>> <meta name="description" content=""/>
>> <meta name="keywords" content=""/>
>> @@ -101,7 +101,7 @@
>> </li>
>> </ul>
>> <ul>
>> - <li id="sec-1_1_2"><a name="sec-1_1_2" id="sec-1_1_2"></
>> a>Target with CUSTOMID <br/>
>> + <li id="aabbccddeeff"><a name="sec-1_1_2" id="sec-1_1_2"></
>> a>Target with CUSTOMID <br/>
>>
>> <p>
>> One
>> @@ -200,7 +200,7 @@
>> <p class="author"> Author: Jambunathan K
>> <a
>> href
>> ="mailto:kjambunathan@gmail.com"><kjambunathan@gmail.com></a>
>> </p>
>> - <p class="date"> Date: 2010-11-08 18:57:46 </p>
>> + <p class="date"> Date: 2010-11-08 18:56:05 </p>
>> <p class="creator">HTML generated by org-mode 7.3 in emacs 23</p>
>> </div>
>> </div>
>> <0002-Fix-broken-CUSTOM_ID-links-to-outline-levels-exporte.patch>
>>> - Carsten
>>>
>>>>
>>>> (This bug is unrelated to any of the previous internal link bugs
>>>> that I
>>>> have reported)
>>>>
>>>> # Input file
>>>>
>>>> #+OPTIONS: H:1
>>>>
>>>> * Links
>>>> ** Targets
>>>>
>>>> *** Fuzzy Target
>>>>
>>>> *** Target with CUSTOMID
>>>> :PROPERTIES:
>>>> :CUSTOM_ID: aabbccddeeff
>>>> :END:
>>>>
>>>> *** Dedicated Target
>>>> # <<Dedicated Target>>
>>>>
>>>> *** <<<Radioed Target>>>
>>>>
>>>> ** References
>>>>
>>>> *** References to Fuzzy Target
>>>> This is a link to [[Fuzzy Target]].
>>>>
>>>> *** References to CUSTOMID links
>>>> This link to [[#aabbccddeeff][CUSTOMID Target]] is broken.
>>>>
>>>> *** References to Dedicated Target
>>>> There is a link to nodesc [[Dedicated Target]] here. There is a
>>>> link
>>>> to [[Dedicated%20Target][Jump to Dedicated Target]] here.
>>>>
>>>> *** References to Radioed Links
>>>> This section has references to Radioed Target. One more reference
>>>> to Radioed Target.
>>>>
>>>>
>>>>
>>>> #+begin_src html
>>>> <!-- Headline defined here -->
>>>> <ul>
>>>> <li id="sec-1_1_2">
>>>> <a name="sec-1_1_2" id="sec-1_1_2">
>>>> </a>
>>>> Target with CUSTOMID
>>>> <br/>
>>>> </li>
>>>> </ul>
>>>>
>>>> <!-- Headline referenced here -->
>>>> <ul>
>>>> <li id="sec-1_2_2">
>>>> References to CUSTOMID links
>>>> <br/>
>>>> This link to
>>>> <a href="#aabbccddeeff">
>>>> CUSTOMID Target
>>>> </a>
>>>> is broken.
>>>> </li>
>>>> </ul>
>>>> #+end_src
>>>>
>>>>
>>>> Jambunathan K.
>>>>
>>>> _______________________________________________
>>>> Emacs-orgmode mailing list
>>>> Please use `Reply All' to send replies to the list.
>>>> Emacs-orgmode@gnu.org
>>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
- Carsten
next prev parent reply other threads:[~2010-11-17 13:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 17:53 Broken CUSTOMID links Jambunathan K
2010-11-06 19:36 ` Carsten Dominik
2010-11-08 13:39 ` [PATCH 2/2] Fix broken CUSTOM_ID links Jambunathan K
2010-11-12 15:50 ` Carsten Dominik
2010-11-17 13:26 ` Carsten Dominik [this message]
2010-11-17 15:22 ` [PATCH: RESUBMITTED] " Jambunathan K
2010-11-21 8:45 ` Carsten Dominik
2010-11-17 15:22 ` Jambunathan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69E5CC30-46A0-47E2-A8F7-0B36BB8B29F4@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=kjambunathan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.