From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#35968: Proposed clean-compile patches for release 26.3 Date: Thu, 30 May 2019 15:30:15 -0700 Organization: UCLA Computer Science Department Message-ID: <69996d68-0379-35f5-338b-a69ff4abaab5@cs.ucla.edu> References: <85h89ecmex.fsf@gmail.com> <70b1022c-d091-4c32-5683-df1d306baf4b@cs.ucla.edu> <83a7f4xcnf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236328"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 Cc: 35968@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 31 00:31:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWTZm-000zM5-2u for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2019 00:31:10 +0200 Original-Received: from localhost ([127.0.0.1]:59854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWTZl-00033K-51 for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 18:31:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWTZe-00032C-NP for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:31:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWTZd-0006wL-Tg for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48967) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWTZd-0006w7-QL for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWTZd-0005zT-Mp for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 18:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35968 X-GNU-PR-Package: emacs Original-Received: via spool by 35968-submit@debbugs.gnu.org id=B35968.155925542522976 (code B ref 35968); Thu, 30 May 2019 22:31:01 +0000 Original-Received: (at 35968) by debbugs.gnu.org; 30 May 2019 22:30:25 +0000 Original-Received: from localhost ([127.0.0.1]:34278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWTZ2-0005yV-Vc for submit@debbugs.gnu.org; Thu, 30 May 2019 18:30:25 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWTZ0-0005yB-CM for 35968@debbugs.gnu.org; Thu, 30 May 2019 18:30:23 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A3E04160877; Thu, 30 May 2019 15:30:16 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id sUrrdc_z172x; Thu, 30 May 2019 15:30:15 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E54A4160878; Thu, 30 May 2019 15:30:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8diuqNYsIP3A; Thu, 30 May 2019 15:30:15 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C249E160841; Thu, 30 May 2019 15:30:15 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <83a7f4xcnf.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159951 Archived-At: On 5/30/19 7:03 AM, Eli Zaretskii wrote: > This hunk seems to be just an aesthetic cleanup. Does it cause any=20 > warnings/errors during compilation? If not, I'd prefer to leave it=20 > out, for paranoia reasons. Yes, if the hunk is omitted, _fraghead is defined twice and GCC complains= : =C2=A0 gmalloc.c:353:20: error: redundant redeclaration of =E2=80=98_fra= ghead=E2=80=99=20 [-Werror=3Dredundant-decls] =C2=A0=C2=A0=C2=A0 353 | static struct list _fraghead[BLOCKLOG]; =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~ =C2=A0 gmalloc.c:185:20: note: previous declaration of =E2=80=98_fraghea= d=E2=80=99 was here =C2=A0=C2=A0=C2=A0 185 | static struct list _fraghead[BLOCKLOG]; =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~ So I installed the patches as-is.