From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 35968@debbugs.gnu.org
Subject: bug#35968: Proposed clean-compile patches for release 26.3
Date: Thu, 30 May 2019 15:30:15 -0700 [thread overview]
Message-ID: <69996d68-0379-35f5-338b-a69ff4abaab5@cs.ucla.edu> (raw)
In-Reply-To: <83a7f4xcnf.fsf@gnu.org>
On 5/30/19 7:03 AM, Eli Zaretskii wrote:
> This hunk seems to be just an aesthetic cleanup. Does it cause any
> warnings/errors during compilation? If not, I'd prefer to leave it
> out, for paranoia reasons.
Yes, if the hunk is omitted, _fraghead is defined twice and GCC complains:
gmalloc.c:353:20: error: redundant redeclaration of ‘_fraghead’
[-Werror=redundant-decls]
353 | static struct list _fraghead[BLOCKLOG];
| ^~~~~~~~~
gmalloc.c:185:20: note: previous declaration of ‘_fraghead’ was here
185 | static struct list _fraghead[BLOCKLOG];
| ^~~~~~~~~
So I installed the patches as-is.
prev parent reply other threads:[~2019-05-30 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 21:13 bug#35968: Release 26.3 npostavs
2019-05-28 22:25 ` Noam Postavsky
2019-05-30 23:07 ` Noam Postavsky
2019-06-06 1:27 ` Noam Postavsky
2019-06-06 2:35 ` Eli Zaretskii
2019-06-11 20:00 ` Nicolas Petton
2019-06-12 2:30 ` Eli Zaretskii
2019-05-29 16:04 ` Eli Zaretskii
2019-05-30 1:10 ` bug#35968: Proposed clean-compile patches for release 26.3 Paul Eggert
2019-05-30 14:03 ` Eli Zaretskii
2019-05-30 22:30 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69996d68-0379-35f5-338b-a69ff4abaab5@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=35968@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.