From: Daniel Mendler <mail@daniel-mendler.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 55205@debbugs.gnu.org
Subject: bug#55205: 28.1.50; completion--replace illegally mutates completion candidates
Date: Mon, 2 May 2022 18:38:37 +0200 [thread overview]
Message-ID: <698d2a57-db2a-1c8a-5fe1-305b1c37aea2@daniel-mendler.de> (raw)
In-Reply-To: <jwvsfprj3qj.fsf-monnier+emacs@gnu.org>
On 5/2/22 18:34, Stefan Monnier wrote:
>> Completion takes text typed by the user and produces strings that the
>> user could possibly mean by typing what he/she typed. Some part(s) of
>> the candidates can legitimately come from what the user typed, some
>> other part(s) could be invented by the completion machinery more or
>> less out of thin air. Why should anyone expect this meat-grinder to
>> refrain from destructively modifying any of the involved strings?
>
> Because the overwhelming majority of strings are never modified.
> It's very unusual to modify a string by side effect (as opposed to
> creating a new string object via `concat`, `substring`, ...).
> This is true in most languages, AFAICT, but it's definitely true in
> ELisp.
One should add that *by definition* of the completion API, mutations of
the supplied candidate strings don't take place. For example you can run
completion on strings from the obarray:
(completing-read "Symbol: " obarray)
It would be quite harmful if the symbol names are destroyed in the
process. I don't see the completion API as a meat-grinder. It is all
quite well-defined.
Daniel
next prev parent reply other threads:[~2022-05-02 16:38 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-01 8:27 bug#55205: 28.1.50; completion--replace illegally mutates completion candidates Daniel Mendler
2022-05-01 11:53 ` Lars Ingebrigtsen
2022-05-01 12:17 ` Eli Zaretskii
2022-05-01 20:11 ` Dmitry Gutov
2022-05-02 2:23 ` Eli Zaretskii
2022-05-02 9:46 ` Dmitry Gutov
2022-05-02 14:27 ` Eli Zaretskii
2022-05-02 21:06 ` Dmitry Gutov
2022-05-02 16:01 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 16:24 ` Eli Zaretskii
2022-05-02 16:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 16:38 ` Daniel Mendler [this message]
2022-05-02 16:47 ` Eli Zaretskii
2022-05-02 16:43 ` Eli Zaretskii
2022-05-02 16:48 ` Daniel Mendler
2022-05-02 16:53 ` Eli Zaretskii
2022-05-02 16:57 ` Daniel Mendler
2022-05-02 17:53 ` Eli Zaretskii
2022-05-02 18:35 ` Daniel Mendler
2022-05-02 21:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 12:40 ` Daniel Mendler
2022-05-01 12:49 ` Eli Zaretskii
2022-05-01 12:54 ` Daniel Mendler
2022-05-01 13:16 ` Eli Zaretskii
2022-05-01 13:19 ` Daniel Mendler
2022-05-01 13:21 ` Daniel Mendler
2022-05-01 12:50 ` Daniel Mendler
2022-05-01 17:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 17:26 ` Lars Ingebrigtsen
2022-05-01 17:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 17:48 ` Lars Ingebrigtsen
2022-05-01 18:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-01 18:27 ` Daniel Mendler
2022-05-01 18:39 ` Lars Ingebrigtsen
2022-05-01 19:01 ` Daniel Mendler
2022-05-01 19:07 ` Lars Ingebrigtsen
2022-05-01 20:52 ` Dmitry Gutov
2022-05-01 20:54 ` Lars Ingebrigtsen
2022-05-01 21:30 ` Dmitry Gutov
2022-05-01 21:43 ` Lars Ingebrigtsen
2022-05-02 6:31 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-02 8:11 ` Lars Ingebrigtsen
2022-05-02 9:00 ` Daniel Mendler
2022-05-02 12:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-03 10:13 ` Lars Ingebrigtsen
2022-05-03 12:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-04 7:48 ` Lars Ingebrigtsen
2022-05-04 8:24 ` Daniel Mendler
2022-05-04 8:51 ` Daniel Mendler
2022-05-02 8:49 ` Daniel Mendler
2022-05-02 9:04 ` Lars Ingebrigtsen
2022-05-02 9:57 ` Daniel Mendler
2022-05-02 10:07 ` Lars Ingebrigtsen
2022-05-02 10:17 ` Daniel Mendler
2022-05-01 17:39 ` Eli Zaretskii
2022-05-01 18:06 ` Daniel Mendler
2022-05-02 0:34 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698d2a57-db2a-1c8a-5fe1-305b1c37aea2@daniel-mendler.de \
--to=mail@daniel-mendler.de \
--cc=55205@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.