[ELPA] New package: vertico-posframe

[ELPA] New package: vertico-posframe

[tumashu]

** What is vertico-posframe
vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.

** How to enable vertico-posframe
  (require 'vertico-posframe)
  (vertico-posframe-mode 1)

URL: https://github.com/tumashu/vertico-posframe

Re: [ELPA] New package: vertico-posframe

[Philip Kaludercic]

tumashu <tumashu@163.com> writes:

> ** What is vertico-posframe
> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>
> ** How to enable vertico-posframe
>   (require 'vertico-posframe)
>   (vertico-posframe-mode 1)
>
> URL: https://github.com/tumashu/vertico-posframe

Would it make sense to bundle this directly in Vertico?

-- 
	Philip Kaludercic

Re:Re: [ELPA] New package: vertico-posframe

[tumashu]

At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>tumashu <tumashu@163.com> writes:
>
>> ** What is vertico-posframe
>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>
>> ** How to enable vertico-posframe
>>   (require 'vertico-posframe)
>>   (vertico-posframe-mode 1)
>>
>> URL: https://github.com/tumashu/vertico-posframe
>
>Would it make sense to bundle this directly in Vertico?

I think vertico prefer keep  simple and less code, so we should see the opinion of Daniel Mendler 

>
>-- 
>	Philip Kaludercic

Re: [ELPA] New package: vertico-posframe

[Iñigo Serna]

Hi,

On 26 October 2021 at 02:45 +02, tumashu  <tumashu@163.com> wrote:

> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> 
> wrote:
>>> ** What is vertico-posframe
>>
>>Would it make sense to bundle this directly in Vertico?
>
> I think vertico prefer keep  simple and less code, so we should 
> see the opinion of Daniel Mendler 

It would also add an unneeded dependency of an extenal package not 
used
by most vertico users.
Daniel prefered that these extensions be in their own packages and 
keep
core clean.

-- 
Iñigo Serna



On 26 October 2021 at 02:45 +02, tumashu  <tumashu@163.com> wrote:

> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> 
> wrote:
>>tumashu <tumashu@163.com> writes:
>>
>>> ** What is vertico-posframe
>>> vertico-posframe is an vertico extension, which lets vertico 
>>> use posframe to show its candidate menu.
>>> NOTE: vertico-posframe requires Emacs 26 and do not support 
>>> mouse click.
>>>
>>> ** How to enable vertico-posframe
>>>   (require 'vertico-posframe)
>>>   (vertico-posframe-mode 1)
>>>
>>> URL: https://github.com/tumashu/vertico-posframe
>>
>>Would it make sense to bundle this directly in Vertico?
>
> I think vertico prefer keep  simple and less code, so we should 
> see the opinion of Daniel Mendler 
>
>>
>>-- 
>>	Philip Kaludercic

Re: [ELPA] New package: vertico-posframe

[Daniel Mendler]

On 10/26/21 9:25 AM, Iñigo Serna wrote:
> Hi,
> 
> On 26 October 2021 at 02:45 +02, tumashu  <tumashu@163.com> wrote:
> 
>> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> 
>> wrote:
>>>> ** What is vertico-posframe
>>>
>>> Would it make sense to bundle this directly in Vertico?
>>
>> I think vertico prefer keep  simple and less code, so we should 
>> see the opinion of Daniel Mendler 
> 
> It would also add an unneeded dependency of an extenal package not 
> used
> by most vertico users.
> Daniel prefered that these extensions be in their own packages and 
> keep
> core clean.

Indeed, the packages should not be bundled together. vertico-posframe is
an independent component, which pulls in a third-party dependency.

Daniel

Re: [ELPA] New package: vertico-posframe

[Stefan Monnier]

> Indeed, the packages should not be bundled together.  vertico-posframe is
> an independent component, which pulls in a third-party dependency.

I don't have an opinion on how those should be packaged, but I'll just
point out that Vertico would not needed to have `posframe` in its
`Package-Requires` in order to provide support for Posframe.


        Stefan

Re: [ELPA] New package: vertico-posframe

[Philip Kaludercic]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Indeed, the packages should not be bundled together.  vertico-posframe is
>> an independent component, which pulls in a third-party dependency.
>
> I don't have an opinion on how those should be packaged, but I'll just
> point out that Vertico would not needed to have `posframe` in its
> `Package-Requires` in order to provide support for Posframe.

Yes, this was what I was thinking about. A soft dependency that would
raise an error of the posframe part were actually required, but would
otherwise ignore it.

But as Daniel has said he prefers not to do it this way, we can add
vertico-posframe as a separate package.

-- 
	Philip Kaludercic

Re: [ELPA] New package: vertico-posframe

[Stefan Monnier]

Philip Kaludercic [2021-10-26 16:51:10] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>>> Indeed, the packages should not be bundled together.  vertico-posframe is
>>> an independent component, which pulls in a third-party dependency.
>>
>> I don't have an opinion on how those should be packaged, but I'll just
>> point out that Vertico would not needed to have `posframe` in its
>> `Package-Requires` in order to provide support for Posframe.
>
> Yes, this was what I was thinking about. A soft dependency that would
> raise an error of the posframe part were actually required, but would
> otherwise ignore it.
>
> But as Daniel has said he prefers not to do it this way, we can add
> vertico-posframe as a separate package.

Yes, either way is fine.


        Stefan

Re: [ELPA] New package: vertico-posframe

[Philip Kaludercic]

tumashu  <tumashu@163.com> writes:

> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>>tumashu <tumashu@163.com> writes:
>>
>>> ** What is vertico-posframe
>>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>>
>>> ** How to enable vertico-posframe
>>>   (require 'vertico-posframe)
>>>   (vertico-posframe-mode 1)
>>>
>>> URL: https://github.com/tumashu/vertico-posframe
>>
>>Would it make sense to bundle this directly in Vertico?
>
> I think vertico prefer keep  simple and less code, so we should see the opinion of Daniel Mendler 

No problem, then it should be possible to add your package too.  I will
look over the code later today to check if there is anything that might
be worth discussing.

-- 
	Philip Kaludercic

Re: [ELPA] New package: vertico-posframe

[Philip Kaludercic]

Philip Kaludercic <philipk@posteo.net> writes:

> tumashu  <tumashu@163.com> writes:
>
>> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>>>tumashu <tumashu@163.com> writes:
>>>
>>>> ** What is vertico-posframe
>>>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>>>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>>>
>>>> ** How to enable vertico-posframe
>>>>   (require 'vertico-posframe)
>>>>   (vertico-posframe-mode 1)
>>>>
>>>> URL: https://github.com/tumashu/vertico-posframe
>>>
>>>Would it make sense to bundle this directly in Vertico?
>>
>> I think vertico prefer keep  simple and less code, so we should see the opinion of Daniel Mendler 
>
> No problem, then it should be possible to add your package too.  I will
> look over the code later today to check if there is anything that might
> be worth discussing.

The package builds as expected so I'll add it with auto-syncing as there
haven't been any objections.  I'd just question why you are requiring
cl-lib? It seems you aren't using it?

-- 
	Philip Kaludercic

Re:Re: [ELPA] New package: vertico-posframe

[tumashu]

At 2021-10-28 02:00:23, "Philip Kaludercic" <philipk@posteo.net> wrote:
>Philip Kaludercic <philipk@posteo.net> writes:
>
>> tumashu  <tumashu@163.com> writes:
>>
>>> At 2021-10-26 00:13:16, "Philip Kaludercic" <philipk@posteo.net> wrote:
>>>>tumashu <tumashu@163.com> writes:
>>>>
>>>>> ** What is vertico-posframe
>>>>> vertico-posframe is an vertico extension, which lets vertico use posframe to show its candidate menu.
>>>>> NOTE: vertico-posframe requires Emacs 26 and do not support mouse click.
>>>>>
>>>>> ** How to enable vertico-posframe
>>>>>   (require 'vertico-posframe)
>>>>>   (vertico-posframe-mode 1)
>>>>>
>>>>> URL: https://github.com/tumashu/vertico-posframe
>>>>
>>>>Would it make sense to bundle this directly in Vertico?
>>>
>>> I think vertico prefer keep  simple and less code, so we should see the opinion of Daniel Mendler 
>>
>> No problem, then it should be possible to add your package too.  I will
>> look over the code later today to check if there is anything that might
>> be worth discussing.
>
>The package builds as expected so I'll add it with auto-syncing as there
>haven't been any objections.  I'd just question why you are requiring
>cl-lib? It seems you aren't using it?

Removed, thanks!
>
>-- 
>	Philip Kaludercic