From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, silent2600@gmail.com, emacs-devel@gnu.org
Subject: Re: emacs26, ucs-normalize.el, Symbol’s function definition is void: regexp-opt-charset
Date: Wed, 13 Feb 2019 15:04:18 -0800 [thread overview]
Message-ID: <69347b44-3ccd-bbcb-4589-d5e221ca2737@cs.ucla.edu> (raw)
In-Reply-To: <e84l97h2u3.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
On 2/13/19 12:04 PM, Glenn Morris wrote:
> There is a problem, however, as shown by the fact that in a
> --without-x build post-bootstrap, this fails:
>
> ./src/emacs -Q -batch -f batch-byte-compile lisp/international/ucs-normalize.el
>
> Error: Symbol's function definition is void: regexp-opt-charset
Yes, I observe that problem too. I fixed it by installing the attached
patch into the master branch. It's not clear to me whether it's worth
backporting this into emacs-26, as the problem occurs only with unusual
actions after unusual builds.
[-- Attachment #2: 0001-Add-missing-dependency-to-ucs-normalize.el.patch --]
[-- Type: text/x-patch, Size: 908 bytes --]
From d1dc424721e5d13fc1ddf69ab4057517e4e77c64 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 13 Feb 2019 15:03:01 -0800
Subject: [PATCH] Add missing dependency to ucs-normalize.el
* lisp/international/ucs-normalize.el:
Require regexp-opt when compiling. Problem reported by hx in:
https://lists.gnu.org/r/emacs-devel/2019-02/msg00334.html
---
lisp/international/ucs-normalize.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/international/ucs-normalize.el b/lisp/international/ucs-normalize.el
index 9d55470d94..6f1e770c09 100644
--- a/lisp/international/ucs-normalize.el
+++ b/lisp/international/ucs-normalize.el
@@ -109,7 +109,9 @@
(defconst ucs-normalize-version "1.2")
-(eval-when-compile (require 'cl-lib))
+(eval-when-compile
+ (require 'cl-lib)
+ (require 'regexp-opt))
(declare-function nfd "ucs-normalize" (char))
--
2.20.1
next prev parent reply other threads:[~2019-02-13 23:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 1:21 emacs26, ucs-normalize.el, Symbol’s function definition is void: regexp-opt-charset hx
2019-02-11 16:39 ` Eli Zaretskii
2019-02-12 0:16 ` hx
2019-02-11 23:39 ` Paul Eggert
2019-02-12 3:35 ` Eli Zaretskii
2019-02-13 18:49 ` Paul Eggert
2019-02-13 19:18 ` Eli Zaretskii
2019-02-13 20:04 ` Glenn Morris
2019-02-13 20:15 ` Stefan Monnier
2019-02-14 3:32 ` Eli Zaretskii
2019-02-14 4:21 ` Stefan Monnier
2019-02-13 23:04 ` Paul Eggert [this message]
2019-02-14 3:37 ` Eli Zaretskii
2019-02-14 18:48 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69347b44-3ccd-bbcb-4589-d5e221ca2737@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
--cc=silent2600@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.