From: Gergely Czuczy <gergely.czuczy@harmless.hu>
To: Noam Postavsky <npostavs@users.sourceforge.net>,
Eli Zaretskii <eliz@gnu.org>
Cc: 28308@debbugs.gnu.org
Subject: bug#28308: Build failure on FreeBSD/aarch64
Date: Wed, 1 Nov 2017 17:14:20 +0100 [thread overview]
Message-ID: <6927f701-035c-3267-3be6-0436b00d2a3d@harmless.hu> (raw)
In-Reply-To: <CAM-tV-_y_kpZkKnHqFpcmGyJmartzF9duQ1Ags8QkymZAmYNNg@mail.gmail.com>
On 2017. 10. 31. 18:31, Noam Postavsky wrote:
> tags 28308 + patch
> quit
>
> On Tue, Oct 24, 2017 at 2:43 PM, Noam Postavsky
> <npostavs@users.sourceforge.net> wrote:
>
>> It seems that the memory pointer to by float_block->floats becomes
>> invalid following the dumping process.
> The following patch which makes FreeBSD use the hybrid malloc scheme fixes it:
>
> diff --git a/configure.ac b/configure.ac
> index d294412dc4..2e690987a6 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2206,7 +2206,7 @@ AC_DEFUN
> case "$opsys" in
> ## darwin ld insists on the use of malloc routines in the System framework.
> darwin | mingw32 | nacl | sol2-10) ;;
> - cygwin) hybrid_malloc=yes
> + freebsd | cygwin) hybrid_malloc=yes
> system_malloc= ;;
> *) test "$ac_cv_func_sbrk" = yes &&
> system_malloc=$emacs_cv_sanitize_address;;
> esac
> diff --git a/src/gmalloc.c b/src/gmalloc.c
> index baaff58050..8fd05fe845 100644
> --- a/src/gmalloc.c
> +++ b/src/gmalloc.c
> @@ -1509,9 +1509,13 @@ gdefault_morecore (ptrdiff_t increment)
> return bss_sbrk (increment);
> }
> #endif
> +#ifdef HAVE_SBRK
> result = (void *) __sbrk (increment);
> if (result == (void *) -1)
> return NULL;
> +#else
> + result = NULL;
> +#endif
> return result;
> }
Is 2e690987a6 the commit id I can try? I would like to test it.
Thanks,
-czg
next prev parent reply other threads:[~2017-11-01 16:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 16:34 bug#28308: Build failure on FreeBSD/aarch64 Gergely Czuczy
2017-08-31 16:47 ` Glenn Morris
2017-08-31 17:02 ` Gergely Czuczy
2017-09-02 3:13 ` npostavs
2017-09-04 12:32 ` Gergely Czuczy
2017-09-08 23:52 ` npostavs
2017-09-09 5:01 ` Gergely Czuczy
2017-09-09 7:07 ` Eli Zaretskii
2017-09-11 6:07 ` npostavs
2017-09-11 7:26 ` Gergely Czuczy
2017-09-11 14:45 ` Eli Zaretskii
2017-09-11 15:10 ` Gergely Czuczy
2017-09-11 15:31 ` Eli Zaretskii
2017-09-11 17:12 ` Gergely Czuczy
2017-09-11 17:17 ` Eli Zaretskii
2017-09-11 19:57 ` Gergely Czuczy
2017-09-11 20:33 ` Gergely Czuczy
2017-09-12 5:22 ` npostavs
2017-09-12 5:57 ` Gergely Czuczy
2017-09-12 14:59 ` Eli Zaretskii
2017-09-12 15:13 ` Gergely Czuczy
2017-09-20 5:51 ` Gergely Czuczy
2017-09-20 19:29 ` Noam Postavsky
2017-10-19 23:39 ` Noam Postavsky
2017-10-20 7:07 ` Eli Zaretskii
2017-10-24 18:43 ` Noam Postavsky
2017-10-31 17:31 ` Noam Postavsky
2017-10-31 20:21 ` Eli Zaretskii
2017-11-01 16:14 ` Gergely Czuczy [this message]
2017-11-01 16:51 ` Noam Postavsky
2017-11-01 18:27 ` Gergely Czuczy
2017-11-01 18:52 ` Noam Postavsky
2017-11-02 21:03 ` Gergely Czuczy
2017-11-04 23:14 ` Noam Postavsky
2017-11-05 18:10 ` Gergely Czuczy
2017-11-06 23:14 ` Noam Postavsky
2017-09-14 0:51 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6927f701-035c-3267-3be6-0436b00d2a3d@harmless.hu \
--to=gergely.czuczy@harmless.hu \
--cc=28308@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.