From: Dmitry Gutov <dmitry@gutov.dev>
To: Wilhelm Kirschbaum <wkirschbaum@gmail.com>,
Basil Contovounesios <contovob@tcd.ie>
Cc: 64275@debbugs.gnu.org
Subject: bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode
Date: Sun, 30 Jul 2023 05:06:37 +0300 [thread overview]
Message-ID: <68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev> (raw)
In-Reply-To: <87y1k7j4ov.fsf@gmail.com>
On 25/06/2023 12:00, Wilhelm Kirschbaum wrote:
> "~" @font-lock-string-face
> (sigil_name) @elixir-ts-font-sigil-name-face
> (:match "^[rR]$" @elixir-ts-font-sigil-name-face))
> @font-lock-regexp-face
> - (sigil
> - "~" @font-lock-string-face
> - (sigil_name) @elixir-ts-font-sigil-name-face
> - quoted_start: _ @font-lock-string-face
> - quoted_end: _ @font-lock-string-face
> - (:match "^[HF]$" @elixir-ts-font-sigil-name-face)))
> -
> + (sigil) @font-lock-string-face)
Hi Wilhelm!
Should we continue to use elixir-ts-font-sigil-name-face, though?
With the new patch, it will continue highlight the sigil name ("r") in
regexps, but no in other sigil types (s/c/w).
What's your opinion on that?
next prev parent reply other threads:[~2023-07-30 2:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 20:14 bug#64275: 30.0.50; [PATCH] Improve sigil font-lock match for elixir-ts-mode Wilhelm Kirschbaum
2023-06-25 8:53 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 9:00 ` Wilhelm Kirschbaum
2023-07-29 18:31 ` Wilhelm Kirschbaum
2023-07-30 2:06 ` Dmitry Gutov [this message]
2023-07-30 7:53 ` Wilhelm Kirschbaum
2023-07-30 12:09 ` Dmitry Gutov
2023-07-31 7:22 ` Wilhelm Kirschbaum
2023-08-01 11:59 ` Dmitry Gutov
2023-08-02 6:38 ` Wilhelm Kirschbaum
2023-08-16 2:11 ` Dmitry Gutov
2023-10-07 8:46 ` Wilhelm Kirschbaum
2023-10-07 9:59 ` Wilhelm Kirschbaum
2023-10-07 10:10 ` Wilhelm Kirschbaum
2023-10-21 7:39 ` Wilhelm Kirschbaum
2023-10-26 0:27 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d19873-5c5f-894a-080f-b2e1bacc449a@gutov.dev \
--to=dmitry@gutov.dev \
--cc=64275@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.