Build error: "nmake info" in "emacs/man"

Build error: "nmake info" in "emacs/man"

[Dhruva Krishnamurthy]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Hello,
 I am trying to build GNU Emacs from CVS Head on W2K using MSVC
compiler. I get problems in "nmake info" in "emacs/man" directory. I
have diagnosed the cause and made a patch. Please review it and
install the same. This affects only the MSVC build on MS-Windows OS.

with best regards,
dhruva

-- 
________________________________________
Dhruva Krishnamurthy
Proud FSF member: #1935
http://schemer.fateback.com/

[-- Attachment #2: man.patch --]
[-- Type: application/octet-stream, Size: 1024 bytes --]

*** makefile.w32-in	2004-09-06 09:11:19.040345400 +0530
--- makefile.w32-in.patched	2004-09-08 11:32:37.753233100 +0530
*************** $(infodir)/emacs-mime: emacs-mime.texi
*** 207,219 ****
  emacs-mime.dvi: emacs-mime.texi
  	$(ENVADD) $(TEXI2DVI) $(srcdir)/emacs-mime.texi
  ../info/sieve: sieve.texi
! 	cd $(srcdir); $(MAKEINFO) sieve.texi
  sieve.dvi: sieve.texi
! 	$(ENVADD) $(TEXI2DVI) ${srcdir}/sieve.texi
  ../info/pgg: pgg.texi
! 	cd $(srcdir); $(MAKEINFO) pgg.texi
  pgg.dvi: pgg.texi
! 	$(ENVADD) $(TEXI2DVI) ${srcdir}/pgg.texi
  
  $(infodir)/mh-e: mh-e.texi
  	$(MAKEINFO) mh-e.texi
--- 207,219 ----
  emacs-mime.dvi: emacs-mime.texi
  	$(ENVADD) $(TEXI2DVI) $(srcdir)/emacs-mime.texi
  ../info/sieve: sieve.texi
! 	$(MAKEINFO) sieve.texi
  sieve.dvi: sieve.texi
! 	$(ENVADD) $(TEXI2DVI) $(srcdir)/sieve.texi
  ../info/pgg: pgg.texi
! 	$(MAKEINFO) pgg.texi
  pgg.dvi: pgg.texi
! 	$(ENVADD) $(TEXI2DVI) $(srcdir)/pgg.texi
  
  $(infodir)/mh-e: mh-e.texi
  	$(MAKEINFO) mh-e.texi

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Build error: "nmake info" in "emacs/man"

[Reiner Steib]

On Wed, Sep 08 2004, Dhruva Krishnamurthy wrote:

>  I am trying to build GNU Emacs from CVS Head on W2K using MSVC
> compiler. I get problems in "nmake info" in "emacs/man" directory. I
> have diagnosed the cause and made a patch.

I have installed you patch.  Thanks.  (My entries for the Gnus related
texi files have not been correct.)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Build error: "nmake info" in "emacs/man"

[Eli Zaretskii]

> Date: Wed, 8 Sep 2004 11:40:14 +0530
> From: Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com>
> 
>  I am trying to build GNU Emacs from CVS Head on W2K using MSVC
> compiler. I get problems in "nmake info" in "emacs/man" directory. I
> have diagnosed the cause and made a patch. Please review it and
> install the same. This affects only the MSVC build on MS-Windows OS.

I don't think this patch is good to install: it breaks the build
outside the source tree.

Why do you need to do that?

Re: Build error: "nmake info" in "emacs/man"

[Reiner Steib]

On Wed, Sep 08 2004, Eli Zaretskii wrote:

>> From: Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com>
>> 
>>  I am trying to build GNU Emacs from CVS Head on W2K using MSVC
>> compiler. I get problems in "nmake info" in "emacs/man" directory. I
>> have diagnosed the cause and made a patch. Please review it and
>> install the same. This affects only the MSVC build on MS-Windows OS.
>
> I don't think this patch is good to install: it breaks the build
> outside the source tree.

Do you refer to "../info" instead of "$(infodir)"?  Then it was my
mistake when adding the new Gnus manuals.

Probably it should read as follows (as the other entries
e.g. emacs-mime):

--8<---------------cut here---------------start------------->8---
$(infodir)/sieve: sieve.texi
	$(MAKEINFO) sieve.texi
sieve.dvi: sieve.texi
	$(ENVADD) $(TEXI2DVI) $(srcdir)/sieve.texi
$(infodir)/pgg: pgg.texi
	$(MAKEINFO) pgg.texi
pgg.dvi: pgg.texi
	$(ENVADD) $(TEXI2DVI) $(srcdir)/pgg.texi
--8<---------------cut here---------------end--------------->8---

> Why do you need to do that?

Note that Dhruva's change uses $(...) instead of ${...}.  Maybe nmake
(MSVC) doesn't accept the latter.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Build error: "nmake info" in "emacs/man"

[Eli Zaretskii]

> Cc: Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com>, emacs-devel@gnu.org
> From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
> Date: Wed, 08 Sep 2004 18:59:44 +0200
> 
> > I don't think this patch is good to install: it breaks the build
> > outside the source tree.
> 
> Do you refer to "../info" instead of "$(infodir)"?

No, I mean the fact that "cd ${srcdir}" was omitted from the commands
that build the Info manuals.

Re: Build error: "nmake info" in "emacs/man"

[Dhruva Krishnamurthy]

On Thu, 09 Sep 2004 06:47:18 +0300, Eli Zaretskii <eliz@gnu.org> wrote:
> > Cc: Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com>, emacs-devel@gnu.org
> > From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
> > Date: Wed, 08 Sep 2004 18:59:44 +0200
> >
> > > I don't think this patch is good to install: it breaks the build
> > > outside the source tree.
> >
> > Do you refer to "../info" instead of "$(infodir)"?
> 
> No, I mean the fact that "cd ${srcdir}" was omitted from the commands
> that build the Info manuals.

The value of srcdir is ".". And a "cd ." on W2K using MSVC gives and error:

        cd .; makeinfo pgg.texi
The system cannot find the path specified.
NMAKE : fatal error U1077: 'cd' : return code '0x1'
Stop.
NMAKE : fatal error U1077: 'C:\PROGRA~1\MICROS~2\VC98\BIN\NMAKE.EXE' :
return code '
Stop. 

To avoid this, I had to remove the 'cd' part.

with regards,
dhruva
-- 
________________________________________
Dhruva Krishnamurthy
Proud FSF member: #1935
http://schemer.fateback.com/

Re: Build error: "nmake info" in "emacs/man"

[Peter 'Luna' Runestig]

On 2004-09-08 18:59, Reiner Steib wrote:
> Do you refer to "../info" instead of "$(infodir)"?  Then it was my
> mistake when adding the new Gnus manuals.

Maybe only use one or the other (not mix them), and add a few empty
lines (as per the rest of the file), to make it neat:

RCS file: /cvsroot/emacs/emacs/man/makefile.w32-in,v
retrieving revision 1.13
diff -u -r1.13 makefile.w32-in
--- makefile.w32-in     8 Sep 2004 12:49:08 -0000       1.13
+++ makefile.w32-in     9 Sep 2004 07:32:48 -0000
@@ -198,19 +198,23 @@
        $(ENVADD) $(TEXI2DVI) gnustmp.texi
        cp gnustmp.dvi $*.dvi
        rm gnustmp.*
+
 $(infodir)/message: message.texi
        $(MAKEINFO) message.texi
 message.dvi: message.texi
        $(ENVADD) $(TEXI2DVI) $(srcdir)/message.texi
+
 $(infodir)/emacs-mime: emacs-mime.texi
        $(MAKEINFO) emacs-mime.texi
 emacs-mime.dvi: emacs-mime.texi
        $(ENVADD) $(TEXI2DVI) $(srcdir)/emacs-mime.texi
-../info/sieve: sieve.texi
+
+$(infodir)/sieve: sieve.texi
        $(MAKEINFO) sieve.texi
 sieve.dvi: sieve.texi
        $(ENVADD) $(TEXI2DVI) $(srcdir)/sieve.texi
-../info/pgg: pgg.texi
+
+$(infodir)/pgg: pgg.texi
        $(MAKEINFO) pgg.texi
 pgg.dvi: pgg.texi
        $(ENVADD) $(TEXI2DVI) $(srcdir)/pgg.texi


-- 
Peter 'Luna' Runestig (fd. Altberg), Sweden <peter@runestig.com>
PGP Key ID: 0xD07BBE13
Fingerprint: 7B5C 1F48 2997 C061 DE4B  42EA CB99 A35C D07B BE13
AOL Instant Messenger Screen name: PRunestig
Yahoo! Messenger profile name: altberg

Re: Build error: "nmake info" in "emacs/man"

[Reiner Steib]

On Thu, Sep 09 2004, Eli Zaretskii wrote:

>> From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
[...]
>> Do you refer to "../info" instead of "$(infodir)"?
>
> No, I mean the fact that "cd ${srcdir}" was omitted from the commands
> that build the Info manuals.

But "cd ${srcdir}" isn't present for the other entries neither:

--8<---------------cut here---------------start------------->8---
$(infodir)/pcl-cvs: pcl-cvs.texi
	$(MAKEINFO) pcl-cvs.texi
pcl-cvs.dvi: pcl-cvs.texi
	$(ENVADD) $(TEXI2DVI) $(srcdir)/pcl-cvs.texi
--8<---------------cut here---------------end--------------->8---

"cd ${srcdir}" was erroneously introduced by me when adding sieve and
pgg (more or less C&P from Makefile.in).  There was no "cd ${srcdir}"
in revision 1.11 of Makefile.w32-in.  If building outside of the
source tree doesn't work now, it most probably didn't work before (<=
1.11) neither, AFAICS.

I have replaced "../info" with "$(infodir)" (in sieve and pgg) now to
make everything uniform.


On Thu, Sep 09 2004, Peter 'Luna' Runestig wrote:

> Maybe only use one or the other (not mix them), and add a few empty
> lines (as per the rest of the file), to make it neat:

Well, I omitted the empty to make it more clear that the following
files come from Gnus.   (I have added a `#'.)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Build error: "nmake info" in "emacs/man"

[Eli Zaretskii]

> Date: Thu, 9 Sep 2004 10:28:13 +0530
> From: Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com>
> Cc: Reiner Steib <reiner.steib@gmx.de>, emacs-devel@gnu.org
> 
> The value of srcdir is ".".

Only as long as you don't say "nmake srcdir=/something/else".

> And a "cd ." on W2K using MSVC gives and error:
> 
>         cd .; makeinfo pgg.texi
> The system cannot find the path specified.
> NMAKE : fatal error U1077: 'cd' : return code '0x1'

I can hardly believe that the reason is "cd .", because the same
command works fine on Windows from the CMD's prompt.  Can you try that
on your system and see if it fails from CMD's prompt as well (I don't
have NMAKE to try it here).

Re: Build error: "nmake info" in "emacs/man"

[Eli Zaretskii]

> Cc: eliz@gnu.org, dhruva.krishnamurthy@gmail.com, peter@runestig.com
> From: Reiner Steib <4.uce.03.r.s@nurfuerspam.de>
> Date: Thu, 09 Sep 2004 12:44:12 +0200
> 
> > No, I mean the fact that "cd ${srcdir}" was omitted from the commands
> > that build the Info manuals.
> 
> But "cd ${srcdir}" isn't present for the other entries neither:
> 
> --8<---------------cut here---------------start------------->8---
> $(infodir)/pcl-cvs: pcl-cvs.texi
> 	$(MAKEINFO) pcl-cvs.texi
> pcl-cvs.dvi: pcl-cvs.texi
> 	$(ENVADD) $(TEXI2DVI) $(srcdir)/pcl-cvs.texi
> --8<---------------cut here---------------end--------------->8---

There's no need for srcdir in the rules that produce DVI files: those
files are not installed by "make install", so they are produced in
place, even if that is outside the source tree.  By contrast, Info
files _must_ be inside the source tree, because that is where "make
install" looks for them.  You will see that the original file
man/Makefile.in, from which makefile.w32-in was copied, does that on
Unix as well.

> "cd ${srcdir}" was erroneously introduced by me when adding sieve and
> pgg (more or less C&P from Makefile.in).  There was no "cd ${srcdir}"
> in revision 1.11 of Makefile.w32-in.  If building outside of the
> source tree doesn't work now, it most probably didn't work before (<=
> 1.11) neither, AFAICS.

The question is: does the Windows build support building outside the
source tree in the other directories?  If it doesn't, then I won't
object removing the "cd ." thing in man/makefile.w32-in.  But if a
build outside the source tree _is_ supported in `src' and `lisp'
directories, then I think we should fix `man' to support it as well.

Re: Build error: "nmake info" in "emacs/man"

[Dhruva Krishnamurthy]

On Thu, 09 Sep 2004 22:06:51 +0300, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Thu, 9 Sep 2004 10:28:13 +0530
> > From: Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com>
> > Cc: Reiner Steib <reiner.steib@gmx.de>, emacs-devel@gnu.org
> >
> > The value of srcdir is ".".
> 
> Only as long as you don't say "nmake srcdir=/something/else".
> 
> > And a "cd ." on W2K using MSVC gives and error:
> >
> >         cd .; makeinfo pgg.texi
> > The system cannot find the path specified.
> > NMAKE : fatal error U1077: 'cd' : return code '0x1'
> 
> I can hardly believe that the reason is "cd .", because the same
> command works fine on Windows from the CMD's prompt.  Can you try that
> on your system and see if it fails from CMD's prompt as well (I don't
> have NMAKE to try it here).
> 

The combination of commands fails in CMD.exe. A simple way to test is
as follows:
D:\tmp\build\emacs\emacs\lisp
dky@MATRIXDEI$ cd . ; dir
The system cannot find the path specified.

If you need "cd .", we have to do it on seperate lines.
ex:
cd $(srcdir)
$(MAKEINFO) pgg.texi

and not:
cd $(srcdir) ;$(MAKEINFO) pgg.texi


-dhruva
-- 
________________________________________
Dhruva Krishnamurthy
Proud FSF member: #1935
http://schemer.fateback.com/

Re: Build error: "nmake info" in "emacs/man"

[Jason Rumney]

Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com> writes:

> The combination of commands fails in CMD.exe. A simple way to test is
> as follows:
> D:\tmp\build\emacs\emacs\lisp
> dky@MATRIXDEI$ cd . ; dir
> The system cannot find the path specified.
>
> If you need "cd .", we have to do it on seperate lines.

Right, and that fails in GNU make, which is why the Windows build does
not support building Emacs out of the tree.

Re: Build error: "nmake info" in "emacs/man"

[Eli Zaretskii]

> Cc: Eli Zaretskii <eliz@gnu.org>, reiner.steib@gmx.de, emacs-devel@gnu.org
> From: Jason Rumney <jasonr@gnu.org>
> Date: Fri, 10 Sep 2004 08:36:10 +0100
> 
> Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com> writes:
> 
> > The combination of commands fails in CMD.exe. A simple way to test is
> > as follows:
> > D:\tmp\build\emacs\emacs\lisp
> > dky@MATRIXDEI$ cd . ; dir
> > The system cannot find the path specified.
> >
> > If you need "cd .", we have to do it on seperate lines.
> 
> Right, and that fails in GNU make, which is why the Windows build does
> not support building Emacs out of the tree.

Okay, if out-of-source builds are not supported on Windows, then I
withdraw my objections.

(One way to support the out of source tree build is to invoke CMD
explicitly and use the CMD's method of chaining multiple commands on
the same command line.  A project for a volunteer, I guess.)

Re: Build error: "nmake info" in "emacs/man"

[Dhruva Krishnamurthy]

On Fri, 10 Sep 2004 12:22:04 +0300, Eli Zaretskii <eliz@gnu.org> wrote:
> > Cc: Eli Zaretskii <eliz@gnu.org>, reiner.steib@gmx.de, emacs-devel@gnu.org
> > From: Jason Rumney <jasonr@gnu.org>
> > Date: Fri, 10 Sep 2004 08:36:10 +0100
> 
> 
> >
> > Dhruva Krishnamurthy <dhruva.krishnamurthy@gmail.com> writes:
> >
> > > The combination of commands fails in CMD.exe. A simple way to test is
> > > as follows:
> > > D:\tmp\build\emacs\emacs\lisp
> > > dky@MATRIXDEI$ cd . ; dir
> > > The system cannot find the path specified.
> > >
> > > If you need "cd .", we have to do it on seperate lines.

I found an alternate way to do that:
cd $(srcdir) & $(MAKEINFO) pgg.texi
Replace the ';' with '&' and things works with nmake! I tried it in
the makefile.w32-in

> > Right, and that fails in GNU make, which is why the Windows build does
> > not support building Emacs out of the tree.
> 
> Okay, if out-of-source builds are not supported on Windows, then I
> withdraw my objections.
> 
> (One way to support the out of source tree build is to invoke CMD
> explicitly and use the CMD's method of chaining multiple commands on
> the same command line.  A project for a volunteer, I guess.)
> 

Let me know the desired behaviour (what out of source build means), I
will be able to do that.

-dhruva

-- 
Proud FSF member: #1935
http://schemer.fateback.com/

Re: Build error: "nmake info" in "emacs/man"

[Jason Rumney]

Dhruva Krishnamurthy wrote:

>I found an alternate way to do that:
>cd $(srcdir) & $(MAKEINFO) pgg.texi
>Replace the ';' with '&' and things works with nmake! I tried it in
>the makefile.w32-in
>
>  
>
It looks like you may have found a way to support out of source builds 
on Windows. If that works on all the variations of make (Mingw GNU make 
and MS nmake) and shell (cmd.exe and Cygwin bash) that the Windows build 
supports, then we should use it.

>Let me know the desired behaviour (what out of source build means), I
>will be able to do that.
>  
>
It means that you can do something like the following:

mkdir emacs-build
cd emacs-build
make -f ../emacs-src/nt/Makefile

and all the output files of the build process end up in emacs-build, 
keeping the source tree clean.


In addition to needing cd $(srcdir) in places, the fact that the nt 
build files are in emacs-src/nt may compilcate matters.

If you want to work on this, I'd do it on a branch for now, as changes 
to the build system might disrupt any pretest that should be starting soon.

Re: Build error: "nmake info" in "emacs/man"

[Dhruva Krishnamurthy]

On Fri, 10 Sep 2004 12:20:22 +0100, Jason Rumney <jasonr@gnu.org> wrote:
> Dhruva Krishnamurthy wrote:
> 
> >I found an alternate way to do that:
> >cd $(srcdir) & $(MAKEINFO) pgg.texi
> >Replace the ';' with '&' and things works with nmake! I tried it in
> >the makefile.w32-in
> >
> >
> >
> It looks like you may have found a way to support out of source builds
> on Windows. If that works on all the variations of make (Mingw GNU make
> and MS nmake) and shell (cmd.exe and Cygwin bash) that the Windows build
> supports, then we should use it.

The '&' works  with MinGW GNU make (gmake), MSVC nmake. I have tried
this both on cmd and bash shells.

> >Let me know the desired behaviour (what out of source build means), I
> >will be able to do that.
> >
> >
> It means that you can do something like the following:
> 
> mkdir emacs-build
> cd emacs-build
> make -f ../emacs-src/nt/Makefile
> 
> and all the output files of the build process end up in emacs-build,
> keeping the source tree clean.
> 
> In addition to needing cd $(srcdir) in places, the fact that the nt
> build files are in emacs-src/nt may compilcate matters.
> 
> If you want to work on this, I'd do it on a branch for now, as changes
> to the build system might disrupt any pretest that should be starting soon.

I thought it was not working only for "info" target. Since it does not
work for any of the other targets, I guess it needs lot of work. I do
not have write access to CVS , so I will work on a local copy and give
it a try.

-dhruva

-- 
Proud FSF member: #1935
http://schemer.fateback.com/

Re: Build error: "nmake info" in "emacs/man"

[Reiner Steib]

On Fri, Sep 10 2004, Dhruva Krishnamurthy wrote:

>> >cd $(srcdir) & $(MAKEINFO) pgg.texi
>> >Replace the ';' with '&' and things works with nmake! I tried it in
>> >the makefile.w32-in
[...]
> The '&' works  with MinGW GNU make (gmake), MSVC nmake. I have tried
> this both on cmd and bash shells.

Are you sure that `&' gives you the desired behavior?  At least with
bash on GNU/Linux, the makeinfo command would be execute in the
previous directory instead of $(srcdir), I think:

$ cd /tmp/current-dir
$ pwd
/tmp/current-dir
$ cd /tmp/srcdir & pwd
[1] 20342
/tmp/current-dir
[1]   Done                    cd /tmp/srcdir

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Build error: "nmake info" in "emacs/man"

[Benjamin Riefenstahl]

Hi Reiner,

Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
> Are you sure that `&' gives you the desired behavior?  At least with
> bash on GNU/Linux, the makeinfo command would be execute in the
> previous directory instead of $(srcdir), I think:

The difference is the shell used.  & is documented as a command
separator for CMD.EXE.   I don't know if COMMAND.COM also supports it
(on 98/Me). 

benny

Re: Build error: "nmake info" in "emacs/man"

[Peter 'Luna' Runestig]

On 2004-09-10 20:08, Benjamin Riefenstahl wrote:
> Hi Reiner,
> 
> Reiner Steib <4.uce.03.r.s@nurfuerspam.de> writes:
>> Are you sure that `&' gives you the desired behavior?  At least with
>> bash on GNU/Linux, the makeinfo command would be execute in the
>> previous directory instead of $(srcdir), I think:
> 
> The difference is the shell used.  & is documented as a command
> separator for CMD.EXE.   I don't know if COMMAND.COM also supports it
> (on 98/Me). 

But '&' is like "fork of in the background" with bash, right? That would
not be what you want then... Maybe use '&&' instead?

-- 
Peter 'Luna' Runestig (fd. Altberg), Sweden <peter@runestig.com>
PGP Key ID: 0xD07BBE13
Fingerprint: 7B5C 1F48 2997 C061 DE4B  42EA CB99 A35C D07B BE13
AOL Instant Messenger Screen name: PRunestig
Yahoo! Messenger profile name: altberg

Re: Build error: "nmake info" in "emacs/man"

[Benjamin Riefenstahl]

Hi Peter,

Sorry I wasn't following too closely, so I missed some context before.

> On 2004-09-10 20:08, Benjamin Riefenstahl wrote:
>> The difference is the shell used.  & is documented as a command
>> separator for CMD.EXE.  I don't know if COMMAND.COM also supports
>> it (on 98/Me).

"Peter 'Luna' Runestig" <peter@runestig.com> writes:
> But '&' is like "fork of in the background" with bash, right? That
> would not be what you want then... Maybe use '&&' instead?

Yes, right.  So if you are using bash "a & b" would mean something
else.

OTOH "&&" is AND in both shells, so "a && b" might work, assuming that
the first command doesn't return some error code.

benny