From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7112: 24.0.50; [PATCH] `ls-lisp-insert-directory' should be no-op for empty FILE Date: Sun, 26 Sep 2010 17:21:58 -0700 Message-ID: <68BA79A0F7304F01870834FE12F89A36@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1285548089 4684 80.91.229.12 (27 Sep 2010 00:41:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Sep 2010 00:41:29 +0000 (UTC) To: 7112@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 27 02:41:27 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P01mX-00069j-04 for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Sep 2010 02:41:25 +0200 Original-Received: from localhost ([127.0.0.1]:60752 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P01mV-0003el-TJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 Sep 2010 20:41:23 -0400 Original-Received: from [140.186.70.92] (port=53777 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P01mQ-0003eg-39 for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 20:41:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P01mO-0003Iu-TQ for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 20:41:17 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42259) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P01mO-0003Iq-Pm for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 20:41:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P01Rr-0008Oc-Fr; Sun, 26 Sep 2010 20:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Sep 2010 00:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.128554677332263 (code B ref -1); Mon, 27 Sep 2010 00:20:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Sep 2010 00:19:33 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P01RM-0008OK-DF for submit@debbugs.gnu.org; Sun, 26 Sep 2010 20:19:32 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P01RK-0008OF-Qh for submit@debbugs.gnu.org; Sun, 26 Sep 2010 20:19:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P01U0-0001e2-7v for submit@debbugs.gnu.org; Sun, 26 Sep 2010 20:22:17 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:36437) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P01U0-0001dy-67 for submit@debbugs.gnu.org; Sun, 26 Sep 2010 20:22:16 -0400 Original-Received: from [140.186.70.92] (port=33214 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P01Tz-0006BS-6t for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 20:22:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P01Ty-0001do-1Z for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 20:22:15 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:37180) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P01Tx-0001dg-Pv for bug-gnu-emacs@gnu.org; Sun, 26 Sep 2010 20:22:13 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id o8R0MBWP032237 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 27 Sep 2010 00:22:12 GMT Original-Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o8QMWhST025977 for ; Mon, 27 Sep 2010 00:22:11 GMT Original-Received: from abhmt012.oracle.com by acsmt354.oracle.com with ESMTP id 631233361285546911; Sun, 26 Sep 2010 17:21:51 -0700 Original-Received: from dradamslap1 (/10.159.219.230) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 26 Sep 2010 17:21:51 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: Actd2f9MaGri1c/kQ2yEHhVgTGt67w== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 26 Sep 2010 20:20:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40471 Archived-At: You can call `dired' passing a cons arg that includes a list of file names. An empty file name causes this ugly error: (error "Args out of range: \"\", -1") The reason is the following code near the end of `ls-lisp-insert-directory': ;; If not full-directory-p, FILE *must not* end in /, as ;; file-attributes will not recognize a symlink to a directory, ;; so must make it a relative filename as ls does: (if (file-name-absolute-p file) (setq file (expand-file-name file))) (if (eq (aref file (1- (length file))) ?/) (setq file (substring file 0 -1))) `ls-lisp-insert-directory' should in fact do nothing at all (no-op) if FILE is "". The entire body should be wrapped in this: (when (> (length file) 0) ...) In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-09-20 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include'