From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: jasonr@btinternet.com
Newsgroups: gmane.emacs.devel
Subject: Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows]
Date: Thu, 24 Oct 2002 09:25:58 +0100 (BST)
Sender: emacs-devel-admin@gnu.org
Message-ID: <6871334.1035447958158.JavaMail.root@127.0.0.1>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 7bit
X-Trace: main.gmane.org 1035448060 1678 80.91.224.249 (24 Oct 2002 08:27:40 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Thu, 24 Oct 2002 08:27:40 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 184dL9-0000Qv-00
	for <emacs-devel@main.gmane.org>; Thu, 24 Oct 2002 10:27:39 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 184dNF-0007G2-00
	for <emacs-devel@quimby.gnus.org>; Thu, 24 Oct 2002 10:29:49 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 184dKl-0005xD-00; Thu, 24 Oct 2002 04:27:15 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 184dJr-0005Qm-00
	for emacs-devel@gnu.org; Thu, 24 Oct 2002 04:26:19 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 184dJn-0005GN-00
	for emacs-devel@gnu.org; Thu, 24 Oct 2002 04:26:18 -0400
Original-Received: from thorium.btinternet.com ([194.73.73.67])
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 184dJn-0005CH-00
	for emacs-devel@gnu.org; Thu, 24 Oct 2002 04:26:15 -0400
Original-Received: from lanthanum ([194.75.226.97])
	by thorium.btinternet.com with esmtp (Exim 3.22 #8)
	id 184dJW-0000iU-00; Thu, 24 Oct 2002 09:25:58 +0100
Original-Received: from 193.192.75.200 by lanthanum ([194.75.226.97]); Thu, 24 Oct 02 09:25:58 BST
Original-To: lektu@terra.es
X-Mailer: talk21.com WAS v2
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:8718
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8718


> XColor is needed in some platforms (like Mac OS 9, Windows and DOS) and
> not in others (like X or Mac OS X), so either you put it in a include
> used by every build and guard it through #ifdef's, or put it in
> platform-specific includes. That's what I chose because it seems
> cleaner/simpler.

Having just one definition seems cleaner to me. Multiple
identical definitions lead to maintainence problems.
It has long been a goal to merge as much of the platform
specific display code as possible. So far only xfaces.c
has benefited due to lack of time. But we should at
least try to avoid introducing new duplicated code.