From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jean-Christophe Helary Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Wed, 3 May 2017 10:13:52 +0900 Message-ID: <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> References: <87vapij1l7.fsf@holos> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1493774054 1089 195.159.176.226 (3 May 2017 01:14:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 3 May 2017 01:14:14 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 03:14:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5irg-0008Oh-S1 for ged-emacs-devel@m.gmane.org; Wed, 03 May 2017 03:14:00 +0200 Original-Received: from localhost ([::1]:34269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5irm-000613-5J for ged-emacs-devel@m.gmane.org; Tue, 02 May 2017 21:14:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5irf-00060o-WF for emacs-devel@gnu.org; Tue, 02 May 2017 21:14:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5irc-0003Ye-Pc for emacs-devel@gnu.org; Tue, 02 May 2017 21:13:59 -0400 Original-Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:34136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5irc-0003YP-Jx; Tue, 02 May 2017 21:13:56 -0400 Original-Received: by mail-pg0-x244.google.com with SMTP id t7so25434518pgt.1; Tue, 02 May 2017 18:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=WypSGV20gtbe7nRZxwGJj+FQfdUBFoThxIOnBF0S56I=; b=HRaLZDp1fKFA+TWnXmYiXJry9IjQsVNJ3uV6K7MKSaV/FPwJ6tKb+8wX7O+W8E0xyO Q3AKneICv8dm2r/E4Lgb93XNDCy6+vR2Q6NBnq/mqmVhWzKawu0+DXv3NxdA2Elc5OIn sHa3LlbivCSVkZPuhOh1gz8T1enTOHISGR8o0w7PJLSBWHDmKl+AqclvPyIuMF3vaAiO 5DYR5ShZCZ6wUFoLRHCo6vvO6NJeKEC4d1Xt76hFqjqIc2LAo0GG76TlbGyDMWQ4Vp8p XK19eUiq9gBm6mENTsWSWI2YOsHAc5j99qjjcJSje4Li5TTGNvWb6Av/ve3K/2LEYG96 MCXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=WypSGV20gtbe7nRZxwGJj+FQfdUBFoThxIOnBF0S56I=; b=gsC7p+tBBriNRA6d0Stlm2ztAUY7kkw0e6tL0dYljCiEM8fZFACnAQCzpvKT6u36uL c+X/Hva83T6/0T42j4t3qvxOWam2RIfYMzOH2T/lphQbnG1dL2RS8XoEm9wg1SL9XNyM yO7XOWMT/KSjOwMR9gyYYPjMV8mIM/g2a8y1WCJDzkng1wmmFiT8eTW6Oiz3EmaElglB D1QZiIUYxC0HKY+UxFaOuHL8cZD8BMR3IUqQWqIXcGWCc6Vy8s5YVHYdvFmRXhHYJdc9 DIFYNDeSpLz7ohqIWswN8l44aGr57vsYFE5SFSn18H2+tkYI6qkKyFyBCmXnG897hl63 hMkQ== X-Gm-Message-State: AN3rC/6tKEOz4KV3j+iKtLJdKK/2uzJONbElfdlTP8Gn48lAWC/vX9n1 rYLC64voaGk9lA== X-Received: by 10.98.213.138 with SMTP id d132mr2030157pfg.172.1493774035535; Tue, 02 May 2017 18:13:55 -0700 (PDT) Original-Received: from [192.168.24.54] (pl25298.ag0304.nttpc.ne.jp. [133.232.153.210]) by smtp.gmail.com with ESMTPSA id o5sm38759930pga.64.2017.05.02.18.13.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 18:13:54 -0700 (PDT) In-Reply-To: <87vapij1l7.fsf@holos> X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214535 Archived-At: > On May 3, 2017, at 8:11, Mark Oteiza wrote: > Basically everything in subr-x is either a macro or a defsubst, > > As such, most uses of subr-x are done with (eval-when-compile (require > 'subr-x)). Won't the use of a global variable break these? (defconst string-trim-default-regex "[ \t\n\r]+") "The default value of the trimmed string for `string-trim'." I have no idea what the effects would be. What would you suggest? Jean-Christophe