xwidget-webkit-browse-url run error (newest xwidget code).

xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 2569 bytes --]

Hello:


I try newest xwidget feature today, and show error:


feng@tumashu:~/project/emacs $ ./src/emacs
Overriding existing handler for signal 10. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different signal

** (emacs:54828): ERROR **: 13:10:24.349: GApplication is required for xdg-desktop-portal access in the WebKit sandbox.
Fatal error 5: Trace/breakpoint trap
Backtrace:
./src/emacs(+0x152f41)[0x562c3cf2af41]
./src/emacs(+0x49aa0)[0x562c3ce21aa0]
./src/emacs(+0x49f74)[0x562c3ce21f74]
./src/emacs(+0x15152d)[0x562c3cf2952d]
./src/emacs(+0x151619)[0x562c3cf29619]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x14140)[0x7fe521655140]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_log_structured_array+0x117)[0x7fe527dadca7]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_log_default_handler+0xb5)[0x7fe527dae0b5]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_logv+0x219)[0x7fe527dae309]
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_log+0x8f)[0x7fe527dae59f]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xb369e3)[0x7fe5241429e3]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xb37fa4)[0x7fe524143fa4]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xb3c256)[0x7fe524148256]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0x9bbda0)[0x7fe523fc7da0]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xa52978)[0x7fe52405e978]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xa5ab72)[0x7fe524066b72]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xa5afcc)[0x7fe524066fcc]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xa1f009)[0x7fe52402b009]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(+0xa1f6d0)[0x7fe52402b6d0]
/lib/x86_64-linux-gnu/libwebkit2gtk-4.0.so.37(webkit_web_view_load_uri+0x1b3)[0x7fe5240ec933]
./src/emacs(+0x2273d9)[0x562c3cfff3d9]
./src/emacs(+0x1b76fa)[0x562c3cf8f6fa]
./src/emacs(+0x1b61a0)[0x562c3cf8e1a0]
./src/emacs(+0x1f2628)[0x562c3cfca628]
./src/emacs(+0x1b603f)[0x562c3cf8e03f]
./src/emacs(+0x1f2628)[0x562c3cfca628]
./src/emacs(+0x1b603f)[0x562c3cf8e03f]
./src/emacs(+0x1f2628)[0x562c3cfca628]
./src/emacs(+0x1b603f)[0x562c3cf8e03f]
./src/emacs(+0x1f2628)[0x562c3cfca628]
./src/emacs(+0x1b603f)[0x562c3cf8e03f]
./src/emacs(+0x1b2761)[0x562c3cf8a761]
./src/emacs(+0x1b61a0)[0x562c3cf8e1a0]
./src/emacs(+0x1b7e78)[0x562c3cf8fe78]
./src/emacs(+0x1b3e1a)[0x562c3cf8be1a]
./src/emacs(+0x1b61a0)[0x562c3cf8e1a0]
./src/emacs(+0x1f2628)[0x562c3cfca628]
./src/emacs(+0x1b603f)[0x562c3cf8e03f]
./src/emacs(+0x1f2628)[0x562c3cfca628]
./src/emacs(+0x1b603f)[0x562c3cf8e03f]
./src/emacs(+0x1b2761)[0x562c3cf8a761]
...
追踪与中断点陷阱
feng@tumashu:~/project/emacs $


[-- Attachment #2: Type: text/html, Size: 2952 bytes --]

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Lars Ingebrigtsen]

tumashu <tumashu@163.com> writes:

> I try newest xwidget feature today, and show error:

From etc/PROBLEMS:

** Emacs crashes with SIGTRAP when trying to start a WebKit xwidget.

This could happen if the version of WebKitGTK installed on your system
is buggy, and errors out trying to start a subprocess through
Bubblewrap sandboxing.  You can avoid the crash by setting the
environment variables SNAP, SNAP_NAME and SNAP_REVISION, which will
make WebKit use GLib to launch subprocesses instead.


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

At 2021-11-07 13:33:25, "Lars Ingebrigtsen" <larsi@gnus.org> wrote:
>tumashu <tumashu@163.com> writes:
>
>> I try newest xwidget feature today, and show error:
>
>From etc/PROBLEMS:
>
>** Emacs crashes with SIGTRAP when trying to start a WebKit xwidget.
>
>This could happen if the version of WebKitGTK installed on your system
>is buggy, and errors out trying to start a subprocess through
>Bubblewrap sandboxing.  You can avoid the crash by setting the
>environment variables SNAP, SNAP_NAME and SNAP_REVISION, which will

What does SNAP mean?  any suggest value to three variables?

>make WebKit use GLib to launch subprocesses instead.
>
>
>-- 
>(domestic pets only, the antidote for overdose, milk.)
>   bloggy blog: http://lars.ingebrigtsen.no

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Po Lu]

tumashu  <tumashu@163.com> writes:

> What does SNAP mean?  any suggest value to three variables?

It tricks WebKitGTK into thinking it's running in Snap, which prevents
it from going down the buggy code path.

Any value should suffice, but all three variables must be set.  For
instance, you can do:

  $ SNAP=1 SNAP_NAME=1 SNAP_REVISION=1 emacs

Thanks.

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

At 2021-11-07 13:52:04, "Po Lu" <luangruo@yahoo.com> wrote:
>tumashu  <tumashu@163.com> writes:
>
>> What does SNAP mean?  any suggest value to three variables?
>
>It tricks WebKitGTK into thinking it's running in Snap, which prevents
>it from going down the buggy code path.
>
>Any value should suffice, but all three variables must be set.  For
>instance, you can do:
>
>  $ SNAP=1 SNAP_NAME=1 SNAP_REVISION=1 emacs

Works!  thanks very much.

>
>Thanks.

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

By the way:
1. header-line looks ugly when tab-line is enabled, what about add a custom variable.
2. I can not open a link when left-click with mouse,  any way to deal with it ?
3. right-click mouse will pop menu, but it's position can outside emacs.


















At 2021-11-07 13:52:04, "Po Lu" <luangruo@yahoo.com> wrote:
>tumashu  <tumashu@163.com> writes:
>
>> What does SNAP mean?  any suggest value to three variables?
>
>It tricks WebKitGTK into thinking it's running in Snap, which prevents
>it from going down the buggy code path.
>
>Any value should suffice, but all three variables must be set.  For
>instance, you can do:
>
>  $ SNAP=1 SNAP_NAME=1 SNAP_REVISION=1 emacs
>
>Thanks.

[-- Attachment #2: Type: text/html, Size: 1109 bytes --]

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Po Lu]

tumashu  <tumashu@163.com> writes:

> 2. I can not open a link when left-click with mouse, any way to deal
> with it ?

Could you give me a link to the site you are using?  Thanks.

> 3. right-click mouse will pop menu, but it's position can outside emacs.

That problem is something I've been trying to solve, but so far haven't
come up with a solution for yet.

I'll keep you posted on the progress though.

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

At 2021-11-07 18:49:17, "Po Lu" <luangruo@yahoo.com> wrote:
>tumashu  <tumashu@163.com> writes:
>
>> 2. I can not open a link when left-click with mouse, any way to deal
>> with it ?
>
>Could you give me a link to the site you are using?  Thanks.

Open:

1. http://cn.bing.com/search?q=emacs 
2. https://www.baidu.com/s?ie=utf-8&f=8&rsv_bp=1&rsv_idx=1&tn=baidu&wd=emacs

and I can not click most search results links


>
>> 3. right-click mouse will pop menu, but it's position can outside emacs.
>
>That problem is something I've been trying to solve, but so far haven't
>come up with a solution for yet.
>
>I'll keep you posted on the progress though.

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Po Lu]

tumashu  <tumashu@163.com> writes:

> 1. http://cn.bing.com/search?q=emacs 
> 2. https://www.baidu.com/s?ie=utf-8&f=8&rsv_bp=1&rsv_idx=1&tn=baidu&wd=emacs
>
> and I can not click most search results links

Thanks.  The links in those pages work here, but this stuff tends to
vary a great deal depending on the version and configuration of
WebKitGTK being used, so I suspect some kind of behind-the-scenes
filtering of the type that WebKit likes to do by default.

Can you tell me if these links open on your system with another
WebKitGTK based browser such as Epiphany?  (In Epiphany, also verify
that Settings -> General -> Block Popup Windows is enabled before
performing this test, as this is the default setting of a
WebKitWebView.)

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Po Lu]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

Po Lu <luangruo@yahoo.com> writes:

> Can you tell me if these links open on your system with another
> WebKitGTK based browser such as Epiphany?  (In Epiphany, also verify
> that Settings -> General -> Block Popup Windows is enabled before
> performing this test, as this is the default setting of a
> WebKitWebView.)

Alternatively, could you try this patch and see if it resolves your
problem?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Handle-WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION.patch --]
[-- Type: text/x-patch, Size: 1813 bytes --]

From 2e045963c82606b90530e319e6cc4c6993de3fbf Mon Sep 17 00:00:00 2001
From: Po Lu <luangruo@yahoo.com>
Date: Sun, 7 Nov 2021 19:51:39 +0800
Subject: [PATCH] Handle WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION
 appropriately

* src/xwidget.c (webkit_decide_policy_cb): Send an xwidget display
event when a webpage asks to create a new window.
---
 src/xwidget.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/src/xwidget.c b/src/xwidget.c
index 0692d0022c..f95f5f1d7f 100644
--- a/src/xwidget.c
+++ b/src/xwidget.c
@@ -1196,6 +1196,33 @@ webkit_decide_policy_cb (WebKitWebView *webView,
       break;
     }
   case WEBKIT_POLICY_DECISION_TYPE_NEW_WINDOW_ACTION:
+    {
+      WebKitNavigationPolicyDecision *navigation_decision =
+        WEBKIT_NAVIGATION_POLICY_DECISION (decision);
+      WebKitNavigationAction *navigation_action =
+        webkit_navigation_policy_decision_get_navigation_action (navigation_decision);
+      WebKitURIRequest *request =
+        webkit_navigation_action_get_request (navigation_action);
+      WebKitWebView *newview;
+      struct xwidget *xw = g_object_get_data (G_OBJECT (webView), XG_XWIDGET);
+      Lisp_Object val, new_xwidget;
+
+      XSETXWIDGET (val, xw);
+
+      new_xwidget = Fmake_xwidget (Qwebkit, Qnil, make_fixnum (0),
+				   make_fixnum (0), Qnil,
+				   build_string (" *detached xwidget buffer*"),
+				   val);
+
+      if (NILP (new_xwidget))
+	return FALSE;
+
+      newview = WEBKIT_WEB_VIEW (XXWIDGET (new_xwidget)->widget_osr);
+      webkit_web_view_load_request (newview, request);
+
+      store_xwidget_display_event (XXWIDGET (new_xwidget));
+      return TRUE;
+    }
   case WEBKIT_POLICY_DECISION_TYPE_NAVIGATION_ACTION:
     {
       WebKitNavigationPolicyDecision *navigation_decision =
-- 
2.31.1


[-- Attachment #3: Type: text/plain, Size: 9 bytes --]


Thanks.

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

At 2021-11-07 19:53:59, "Po Lu" <luangruo@yahoo.com> wrote:
>Po Lu <luangruo@yahoo.com> writes:
>
>> Can you tell me if these links open on your system with another
>> WebKitGTK based browser such as Epiphany?  (In Epiphany, also verify
>> that Settings -> General -> Block Popup Windows is enabled before
>> performing this test, as this is the default setting of a
>> WebKitWebView.)
>
>Alternatively, could you try this patch and see if it resolves your
>problem?

works, but it will split and open page in another window :-)

>

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

At 2021-11-07 19:37:56, "Po Lu" <luangruo@yahoo.com> wrote:
>tumashu  <tumashu@163.com> writes:
>
>> 1. http://cn.bing.com/search?q=emacs 
>> 2. https://www.baidu.com/s?ie=utf-8&f=8&rsv_bp=1&rsv_idx=1&tn=baidu&wd=emacs
>>
>> and I can not click most search results links
>
>Thanks.  The links in those pages work here, but this stuff tends to
>vary a great deal depending on the version and configuration of
>WebKitGTK being used, so I suspect some kind of behind-the-scenes
>filtering of the type that WebKit likes to do by default.
>
>Can you tell me if these links open on your system with another
>WebKitGTK based browser such as Epiphany?  (In Epiphany, also verify
>that Settings -> General -> Block Popup Windows is enabled before
>performing this test, as this is the default setting of a
>WebKitWebView.)

It will open links in new tab, no matter Block Popup Windows is enable or not.

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Po Lu]

tumashu  <tumashu@163.com> writes:

> works, but it will split and open page in another window :-)

That's intended behavior.  You'll notice that Baidu also opens search
results in a new tab, in other browsers.

Lars, could you install this patch?  Thanks.

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> That's intended behavior.  You'll notice that Baidu also opens search
> results in a new tab, in other browsers.
>
> Lars, could you install this patch?  Thanks.

Sure; pushed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

How to remove fringes of xwidget window? I try the below code, seem to not work.

(add-hook 'xwidget-webkit-mode-hook
          #'eh-xwidget-webkit-mode-hook)

(defun eh-xwidget-webkit-mode-hook ()
  (setq-local left-fringe-width 0)
  (setq-local right-fringe-width 0))



At 2021-11-07 20:25:35, "Po Lu" <luangruo@yahoo.com> wrote:
>tumashu  <tumashu@163.com> writes:
>
>> works, but it will split and open page in another window :-)
>
>That's intended behavior.  You'll notice that Baidu also opens search
>results in a new tab, in other browsers.
>
>Lars, could you install this patch?  Thanks.

Re: xwidget-webkit-browse-url run error (newest xwidget code).

[Po Lu]

tumashu  <tumashu@163.com> writes:

> How to remove fringes of xwidget window? I try the below code, seem to not work.
>
> (add-hook 'xwidget-webkit-mode-hook
>           #'eh-xwidget-webkit-mode-hook)
>
> (defun eh-xwidget-webkit-mode-hook ()
>   (setq-local left-fringe-width 0)
>   (setq-local right-fringe-width 0))

You should call `set-window-buffer' after changing `left-fringe-width'
or something.

I don't remember the details, but those variables don't take effect
immediately!  Thanks.

Re:Re: xwidget-webkit-browse-url run error (newest xwidget code).

[tumashu]

At 2021-11-07 21:21:05, "Po Lu" <luangruo@yahoo.com> wrote:
>tumashu  <tumashu@163.com> writes:
>
>> How to remove fringes of xwidget window? I try the below code, seem to not work.
>>
>> (add-hook 'xwidget-webkit-mode-hook
>>           #'eh-xwidget-webkit-mode-hook)
>>
>> (defun eh-xwidget-webkit-mode-hook ()
>>   (setq-local left-fringe-width 0)
>>   (setq-local right-fringe-width 0))
>
>You should call `set-window-buffer' after changing `left-fringe-width'
>or something.

The below code works, thanks!

(defun eh-xwidget-webkit-mode-hook ()
  (setq-local left-fringe-width 0)
  (setq-local right-fringe-width 0)
  (set-window-buffer (selected-window) (current-buffer)))


>
>I don't remember the details, but those variables don't take effect
>immediately!  Thanks.
>