From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Lopez Newsgroups: gmane.emacs.bugs Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer Date: Thu, 14 Feb 2019 16:05:10 +0000 Message-ID: <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> References: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------8B668070BB89DD156950B088" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46048"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 To: 34479@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 14 17:08:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1guJYd-000Br5-M3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2019 17:08:15 +0100 Original-Received: from localhost ([127.0.0.1]:50852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guJYc-0000LI-Lv for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2019 11:08:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guJYT-0000L1-Ln for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1guJYR-0004Cc-6E for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:08:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49061) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1guJYQ-0004B5-LX for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1guJYQ-0004d4-9o for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2019 11:08:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com> Resent-From: Daniel Lopez Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Feb 2019 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34479 X-GNU-PR-Package: emacs Original-Received: via spool by 34479-submit@debbugs.gnu.org id=B34479.155016042417697 (code B ref 34479); Thu, 14 Feb 2019 16:08:02 +0000 Original-Received: (at 34479) by debbugs.gnu.org; 14 Feb 2019 16:07:04 +0000 Original-Received: from localhost ([127.0.0.1]:48342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guJXU-0004bM-3T for submit@debbugs.gnu.org; Thu, 14 Feb 2019 11:07:04 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:35332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1guJXQ-0004an-Hz for 34479@debbugs.gnu.org; Thu, 14 Feb 2019 11:07:03 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id t200so6650318wmt.0 for <34479@debbugs.gnu.org>; Thu, 14 Feb 2019 08:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=iq4TOxXpA6fJ3VI2jTeC0BtyMJV62Nxy8DDG6/zZFao=; b=KcuankFhh2XyczJikaRBdgl8/vY9xpuDFg2TcpYgtzVTm+OYtByphTERAcUm/m10JW T68dIWDH1rU55uiEyZDldR3YIpC18GrjFUHJ0IP4+9MvI2X6Iv2I6DJZva9j6iS9rMOF VfZqdroqE0fFlfhyPMxPhr35aIyn1XWQMAGW8kWGq2WS51lRrcr8hFZaukL6lK2nUxha XdXFPMDdjf4kF7GxYNUufK53Oz/Qi4UQ8QSEGIfLGHIgjCWCK0HqT1bKDzNGzpegM1fi PyrHy6v3LZIj+KDNZP+qWjQpiqTIGywuUde5ztejTf/1BG+yEqSIy1poW0rhJdlAxFQ2 k4lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=iq4TOxXpA6fJ3VI2jTeC0BtyMJV62Nxy8DDG6/zZFao=; b=g+YmcWEu+S/fCjlkMGQCZEfkzrBhp9njoGnAxEjU25M4fDh7ZdJwAHVwBWmTKAb1G8 0NVM6AX0J1wVkGnOrQztK7oBn+C2MrVNAsL+DfXJgE1iFU/IxAYFX2JxGgCD/tELEDMI FoqpuxxkpZPT4vba1CMiuoQB2iwgZMHcvHf0H6xQsGyc87exko1FnvJmIsg3kJwJzyOD 5HrQ5Bl6+kRrl46Fd2R5GhYLTT/wNOlB0v4wtSwF5aa0ajhEritUA60JolbjNBoH88Re OHycEfIM/eVSQiympqD4GuVUbm7LNOPD/6J+cXLfequdPMytgKI2ogc0RN0QI2BmCuBB 8SvA== X-Gm-Message-State: AHQUAubkSX/U9TMDXgbKfAIzo4gVl18Q2QeCvoyeFRWWw11Reduea0Bh RYdY3SjEYm/SFoW9u7SSlorJYiPS X-Google-Smtp-Source: AHgI3IZxzmR7HriqLnWv60LbnVajtSsoKJBSDcwY0tsbfw1t66PHD4C4XO8fE1+8qhsnapPOmfo0Pg== X-Received: by 2002:a1c:4844:: with SMTP id v65mr3505910wma.66.1550160414184; Thu, 14 Feb 2019 08:06:54 -0800 (PST) Original-Received: from [192.168.2.2] (w-79.cust-5765.ip.static.uno.uk.net. [95.172.231.79]) by smtp.googlemail.com with ESMTPSA id 126sm3599849wmd.1.2019.02.14.08.06.52 for <34479@debbugs.gnu.org> (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 08:06:53 -0800 (PST) Content-Language: en-US-large X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155421 Archived-At: This is a multi-part message in MIME format. --------------8B668070BB89DD156950B088 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Argh, I forgot to attach the patch. Here it is! Daniel --------------8B668070BB89DD156950B088 Content-Type: text/x-patch; name="fix_compilation_message_type.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_compilation_message_type.patch" diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 581a98d56c..0303314c59 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1425,17 +1425,17 @@ compilation-parse-errors file line end-line col end-col (or type 2) fmt)) (when (integerp file) - (setq type (if (consp type) - (compilation-type type) - (or type 2))) - (compilation--note-type type) - - (compilation--put-prop - file 'font-lock-face - (symbol-value (aref [compilation-info-face - compilation-warning-face - compilation-error-face] - type)))) + (let ((this-type (if (consp type) + (compilation-type type) + (or type 2)))) + (compilation--note-type type) + + (compilation--put-prop + file 'font-lock-face + (symbol-value (aref [compilation-info-face + compilation-warning-face + compilation-error-face] + this-type))))) (compilation--put-prop line 'font-lock-face compilation-line-face) --------------8B668070BB89DD156950B088--