From: Daniel Lopez <daniel.lopez999@gmail.com>
To: 34479@debbugs.gnu.org
Subject: bug#34479: Incorrect classification of messages in compilation-mode buffer
Date: Thu, 14 Feb 2019 16:05:10 +0000 [thread overview]
Message-ID: <6859a1c7-132d-3076-963f-25e177086f44@gmail.com> (raw)
In-Reply-To: <483a94fa-e01c-f81e-ca33-44acc4ba33dd@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 56 bytes --]
Argh, I forgot to attach the patch. Here it is!
Daniel
[-- Attachment #2: fix_compilation_message_type.patch --]
[-- Type: text/x-patch, Size: 1443 bytes --]
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 581a98d56c..0303314c59 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1425,17 +1425,17 @@ compilation-parse-errors
file line end-line col end-col (or type 2) fmt))
(when (integerp file)
- (setq type (if (consp type)
- (compilation-type type)
- (or type 2)))
- (compilation--note-type type)
-
- (compilation--put-prop
- file 'font-lock-face
- (symbol-value (aref [compilation-info-face
- compilation-warning-face
- compilation-error-face]
- type))))
+ (let ((this-type (if (consp type)
+ (compilation-type type)
+ (or type 2))))
+ (compilation--note-type type)
+
+ (compilation--put-prop
+ file 'font-lock-face
+ (symbol-value (aref [compilation-info-face
+ compilation-warning-face
+ compilation-error-face]
+ this-type)))))
(compilation--put-prop
line 'font-lock-face compilation-line-face)
next prev parent reply other threads:[~2019-02-14 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:00 bug#34479: Incorrect classification of messages in compilation-mode buffer Daniel Lopez
2019-02-14 16:05 ` Daniel Lopez [this message]
2019-02-15 8:02 ` Eli Zaretskii
2019-02-25 13:26 ` Tobias Bading
2019-02-25 16:03 ` Daniel Lopez
2019-03-01 10:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6859a1c7-132d-3076-963f-25e177086f44@gmail.com \
--to=daniel.lopez999@gmail.com \
--cc=34479@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.