From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#25816: Emacs xwidget GC issue with callback Date: Mon, 20 Feb 2017 13:05:35 -0800 Organization: UCLA Computer Science Department Message-ID: <685382da-69ef-c683-d6b1-d18fff00b8cf@cs.ucla.edu> References: <87h93oeo6o.fsf@linux-m68k.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------31DA8D0BAD16CE5BFB10396C" X-Trace: blaine.gmane.org 1487624777 23848 195.159.176.226 (20 Feb 2017 21:06:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2017 21:06:17 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 Cc: Ricardo Wurmus , Joakim Verona , 25816@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 20 22:06:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfv9u-0005cE-Ff for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 22:06:10 +0100 Original-Received: from localhost ([::1]:41102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfvA0-0008R4-2b for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 16:06:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfv9q-0008Pw-JA for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 16:06:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfv9m-0006hg-J9 for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 16:06:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49649) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cfv9m-0006hW-H9 for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 16:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cfv9m-0007nA-2a for bug-gnu-emacs@gnu.org; Mon, 20 Feb 2017 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2017 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25816-submit@debbugs.gnu.org id=B25816.148762474529929 (code B ref 25816); Mon, 20 Feb 2017 21:06:02 +0000 Original-Received: (at 25816) by debbugs.gnu.org; 20 Feb 2017 21:05:45 +0000 Original-Received: from localhost ([127.0.0.1]:47848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfv9V-0007mf-CY for submit@debbugs.gnu.org; Mon, 20 Feb 2017 16:05:45 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfv9T-0007mS-86 for 25816@debbugs.gnu.org; Mon, 20 Feb 2017 16:05:43 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3F3A11600E6; Mon, 20 Feb 2017 13:05:36 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 1e3C1TRQf8F3; Mon, 20 Feb 2017 13:05:35 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 60ED01600E8; Mon, 20 Feb 2017 13:05:35 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dRgU59Nj-_LL; Mon, 20 Feb 2017 13:05:35 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3F41C1600E6; Mon, 20 Feb 2017 13:05:35 -0800 (PST) In-Reply-To: <87h93oeo6o.fsf@linux-m68k.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129597 Archived-At: This is a multi-part message in MIME format. --------------31DA8D0BAD16CE5BFB10396C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Andreas Schwab wrote: > When --with-wide-int, EMACS_INT may be wider than a pointer, and this > discards the type bits. Thanks, I installed the attached to document this limitation. Fixing the = GC bug=20 should remove the limitation. --------------31DA8D0BAD16CE5BFB10396C Content-Type: text/x-diff; name="0001-Verify-xwidget-USE_LSB_TAG-assumption.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Verify-xwidget-USE_LSB_TAG-assumption.patch" =46rom 57a8346edfbaa7a4002f2ed8cad041588dfcdd9c Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 20 Feb 2017 13:03:12 -0800 Subject: [PATCH] Verify xwidget USE_LSB_TAG assumption * src/xwidget.c (Fxwidget_webkit_execute_script): Add verification. Problem reported by Andreas Schwab (Bug#25816#8). --- src/xwidget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xwidget.c b/src/xwidget.c index dc705bb..e6de5da 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -720,6 +720,8 @@ argument procedure FUN.*/) GAsyncReadyCallback callback =3D FUNCTIONP (fun) ? webkit_javascript_finished_cb : NULL; =20 + /* FIXME: The following hack assumes USE_LSB_TAG. */ + verify (USE_LSB_TAG); /* FIXME: This hack might lead to disaster if FUN is garbage collected before store_xwidget_js_callback_event makes it visible to Lisp again. See the FIXME in webkit_javascript_finished_cb. */= --=20 2.7.4 --------------31DA8D0BAD16CE5BFB10396C--