From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Wed, 28 Dec 2022 16:01:39 -0800 Message-ID: <6829F6A2-C6FD-4807-B3D2-1E740ED496BC@gmail.com> References: <87ilhy1dub.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32551"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60338@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 29 01:02:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAgNM-0008Gn-52 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Dec 2022 01:02:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAgN6-0005sC-3c; Wed, 28 Dec 2022 19:02:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAgN0-0005rt-S2 for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 19:02:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAgN0-00074P-DV for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 19:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAgN0-0003Ib-4b for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 19:02:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ilhy1dub.fsf@posteo.net> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Dec 2022 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60338-submit@debbugs.gnu.org id=B60338.167227210812658 (code B ref 60338); Thu, 29 Dec 2022 00:02:02 +0000 Original-Received: (at 60338) by debbugs.gnu.org; 29 Dec 2022 00:01:48 +0000 Original-Received: from localhost ([127.0.0.1]:59015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAgMl-0003I5-UW for submit@debbugs.gnu.org; Wed, 28 Dec 2022 19:01:48 -0500 Original-Received: from mail-pl1-f180.google.com ([209.85.214.180]:45683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAgMk-0003Hk-BE for 60338@debbugs.gnu.org; Wed, 28 Dec 2022 19:01:47 -0500 Original-Received: by mail-pl1-f180.google.com with SMTP id g16so7762924plq.12 for <60338@debbugs.gnu.org>; Wed, 28 Dec 2022 16:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=/hvsmBYS8W2ZE6pmuBbeQRwUCzOj0szH9OWCM+ZPy2M=; b=J6ZlyYfWBmkEDue8VLxCFOKEriyjMJ43rk+Y5H9N4T95J2bAKNe9dezLVhGVCnL370 YMF8ljaCjnEsts2VZoRH8sxTUkXxY/TNVAotPMxco9ALkV7kaIho8OwItFzXqLABkdFD ea3x3HGFlme773VDlKpnuuDYYMLLuJGpBG3tU9UVdnZLGrS8UjRcp9A0Sc765TNtIKsf mvw965eOf7mPWbLz6rVnJ7eL+z6GUehr62d+u9JQWy0ZdfcQKYQ9rkV/6TE5os5C8pzq 80jF9aKOsuJe3eootjLbFpPb9tgYfc/yEPtxMfGH4/6kY8E6P9mocKT3oUQcY9q667AM AvLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/hvsmBYS8W2ZE6pmuBbeQRwUCzOj0szH9OWCM+ZPy2M=; b=lww30tboyDcPBnlp3jajrQsJ/vQV0keJk+nD95k1vlBcByh/XEzhFNisCksd9uicMo udvQZPfaKHlAr3un+6rWXIuzlr9r5bDCDdnx24Whe6D36GnP6TzEgiYfjwWA+b3Qq7Ou WSAtDTIL1RqgmWnveHjt8uFEID0AI+ae1s01tdf2VcDiqprwgfpIAjDww4i9MD7qUc6i AyQTa7bDlbZdoC12OLfzYarfvC/ao1YK/M49UjgfzMJy+qY9d/FGu4Cw5BwuTR3k7Azd OQBR8tqNWKkzdfUz+o1eVF4H43LaZRxi9qcsiJrHFWP22q6od+P3wxbqwWSW/gPVjH5i eWtQ== X-Gm-Message-State: AFqh2ko4VoCVV1U7415c2IE9yc2KPnD/q+7dXRckWlm/+tScJMxBpbFu iTQQddhByFw0zxw4JmAR9Hw= X-Google-Smtp-Source: AMrXdXtfYG4N41icL0KMGvUgB8MQgXRRYU9BEvj2djzOVFLP+GMMJzsQFHHO7ZB6yk8Rsq//UVveDg== X-Received: by 2002:a17:903:24b:b0:187:282d:6990 with SMTP id j11-20020a170903024b00b00187282d6990mr13812302plh.28.1672272100632; Wed, 28 Dec 2022 16:01:40 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e2-20020a17090301c200b001868981a18esm11565082plh.6.2022.12.28.16.01.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Dec 2022 16:01:40 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252006 Archived-At: Philip Kaludercic writes: > X-CC-Debbugs: Jo=C3=A3o T=C3=A1vora > > I'd like to propose adding an option that makes server modifications = by > Eglot less invasive. The current behaviour is to make the changes > directly in a buffer and open the remaining files to make the > modifications in those as well (?). If `eglot-use-diffs' is enabled, > all confirmations are prepared as patches in a pop-up buffer that the > user can review and apply at will. To my knowledge there is no = general > `diff-apply-hunk' that will apply all the changes from a buffer, but > that is a separate issue that can be fixed in a separate patch. > > (Note, I'm still testing emacs-29, so the patch was developed on that > branch. But it should be applied to master) This seems really nice :-) Yuan