From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tobias Gerdin Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse' Date: Mon, 9 Jul 2018 21:52:49 +0200 Message-ID: <6821c870-e955-ec96-dd73-a2950a0ba4f6@gmail.com> References: <20180707090050.359.98328@vcs0.savannah.gnu.org> <20180707090052.4B7F9204E8@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1531165863 7455 195.159.176.226 (9 Jul 2018 19:51:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 9 Jul 2018 19:51:03 +0000 (UTC) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 09 21:50:59 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fccBR-0001i7-Q6 for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 21:50:53 +0200 Original-Received: from localhost ([::1]:44149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fccDX-00006E-6M for ged-emacs-devel@m.gmane.org; Mon, 09 Jul 2018 15:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fccDR-000068-78 for emacs-devel@gnu.org; Mon, 09 Jul 2018 15:52:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fccDO-0003MX-6M for emacs-devel@gnu.org; Mon, 09 Jul 2018 15:52:57 -0400 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:33671) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fccDN-0003MP-UU for emacs-devel@gnu.org; Mon, 09 Jul 2018 15:52:54 -0400 Original-Received: by mail-lj1-x22b.google.com with SMTP id t21-v6so14983759lji.0 for ; Mon, 09 Jul 2018 12:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=h4Bunj6cqJLo0YMrYq+f+2ZWS+h9SeOM8EIXOL1p/gw=; b=a/IbfkglF4JXuH5DpjjJawUP2HkeONsi3HP3g+CmsuAbvAvkVn1wi7+yp8KSEebruj uV7Q4zCWFA+gZ4+U8oHGdV1dHBtYy/+Jj/cDRqM03pYFfIhGXekney2j4pZJ3Kn/QLZm uXW+EMaOQaNRLVq23O5qfPCCmo2ZH2xCUzJBSh4P+UeruNd8ZMn4aCbjnvAIM2uL1tac 5HQo5dD1JdDoWYmqdKyV8MoKqpyj+2nyjvXU+F40izDDa3tSdilXj1Ps8uI3R3AjHmqK VXSoKVOvd9tIJZrCYhyz5GHBSuh5YR4ZEFqdJMuE95WzdRC4+GEu+pc/xx1Y4eVRj/pt oyKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=h4Bunj6cqJLo0YMrYq+f+2ZWS+h9SeOM8EIXOL1p/gw=; b=HafQncAa+pji4iEsCqhg12jV3fSozxh8gBUNanBpq92nqjdnSqvUKvJ0f3M5flDQHS 0N7e6eUkTgcSZ3x3ggelfSBwBA4zEJvAr5JTzVLBMQWuzYbAOtIC3A8OdYtM1cP+ygga bpeH2SAWB7U03sH/awkAtOVYy6acS/RBaWelNbWPq0dkBK/dqZKh4tRWVnDetAlL9gUb 2tu71f6QEznvmSHjktP5HL7nAYgVLmLS2IKZv1ubYi2jQy2lqNCUIKOTe8PQg0zyFocn 3RP1kONG7lBlU46C//MYkGAN9G+HffR+uBoRn6+TloTV6TyATy2LfLqW/bckx9nSvWDn yH6Q== X-Gm-Message-State: APt69E3fAnZAv8h8j43L8LSTu2b4SFopYuAep6m/1LQ6UGeVQP+tg02j Yijq3iwHrwNnj5zLxsJU6I5lxylu X-Google-Smtp-Source: AAOMgpcPqzH6Xhk8F4B3qibezyzPlV4Kn2E0YPkOKkuj/52tquFPkpW4kqGtJqZvu8fKJIqYT+2IFQ== X-Received: by 2002:a2e:144f:: with SMTP id 15-v6mr12884812lju.122.1531165971956; Mon, 09 Jul 2018 12:52:51 -0700 (PDT) Original-Received: from Tobias-MBP.lan (h83-209-121-192.cust.se.alltele.net. [83.209.121.192]) by smtp.gmail.com with ESMTPSA id g28-v6sm2581306lfh.92.2018.07.09.12.52.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 12:52:50 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227177 Archived-At: Den 2018-07-09 kl. 15:55, skrev Stefan Monnier: >> +(defun xref-find-definitions-at-mouse (event) >> + "Find the definition of identifier at or around mouse click. >> +This command is intended to be bound to a mouse event." >> + (interactive "e") > If we use > > (defun xref-find-definitions-at-mouse (&optional event) > "Find the definition of identifier at or around mouse click. > This command is intended to be bound to a mouse event." > (interactive (list last-nonmenu-event)) > > then this command will also work with non-mouse events. > > > Stefan > > > PS: No, I don't know why we usually use last-nonmenu-event rather > than last-command-event or last-input-event for those commands. I'm afraid I do not see the point of making it work without mouse events? Would that be in the interest of merging it with 'xref-find-definitions' somehow? -Tobias