From: Tobias Gerdin <tgerdin@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse'
Date: Mon, 9 Jul 2018 21:52:49 +0200 [thread overview]
Message-ID: <6821c870-e955-ec96-dd73-a2950a0ba4f6@gmail.com> (raw)
In-Reply-To: <jwvy3ekecye.fsf-monnier+emacsdiffs@gnu.org>
Den 2018-07-09 kl. 15:55, skrev Stefan Monnier:
>> +(defun xref-find-definitions-at-mouse (event)
>> + "Find the definition of identifier at or around mouse click.
>> +This command is intended to be bound to a mouse event."
>> + (interactive "e")
> If we use
>
> (defun xref-find-definitions-at-mouse (&optional event)
> "Find the definition of identifier at or around mouse click.
> This command is intended to be bound to a mouse event."
> (interactive (list last-nonmenu-event))
>
> then this command will also work with non-mouse events.
>
>
> Stefan
>
>
> PS: No, I don't know why we usually use last-nonmenu-event rather
> than last-command-event or last-input-event for those commands.
I'm afraid I do not see the point of making it work without mouse
events? Would that be in the interest of merging it with
'xref-find-definitions' somehow?
-Tobias
next prev parent reply other threads:[~2018-07-09 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180707090050.359.98328@vcs0.savannah.gnu.org>
[not found] ` <20180707090052.4B7F9204E8@vcs0.savannah.gnu.org>
2018-07-09 13:55 ` [Emacs-diffs] master 455a236: New function 'xref-find-definitions-at-mouse' Stefan Monnier
2018-07-09 19:52 ` Tobias Gerdin [this message]
2018-07-09 20:25 ` Stefan Monnier
2018-07-09 20:53 ` Helmut Eller
2018-07-10 14:03 Tobias Gerdin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6821c870-e955-ec96-dd73-a2950a0ba4f6@gmail.com \
--to=tgerdin@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.